fix(mobile): share settings control row layout

[juliusmarminge]

Targets main independently. This PR has no dependency on V2 or another UI audit PR.

Ordinary and mixed-value settings switches had separate row styling, causing Android font, icon, spacing, and disabled-state drift. SettingsControlRow now owns both layouts while each switch retains its value and fanout behavior.

Validation: settings-scoped-server tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.

Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.

Model: GPT-6. Harness: Codex.

Summary by CodeRabbit

• Improvements
  • Standardized the appearance and spacing of settings rows across the mobile app.
  • Settings controls now consistently support icons, labels, optional subtitles, and trailing switches or other controls.
  • Disabled settings display with consistent visual treatment across supported platforms.
  • Updated mixed-value controls to use the same layout and styling as other settings controls.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+30 B (+0.2%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	+1 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+29 B (+0.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.3 KiB	56.3 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	0 B (0.0%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	+3 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: 53510d4 · PR result: 1603ddc · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 114.0 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at 1603ddc

Macroscope's review found this PR approvable — This is a contained mobile settings UI fix that consolidates duplicated row styling while preserving switch and fanout interactions. Its runtime impact is limited to consistent layout, typography, icon, and disabled-state presentation, with no data, API, security, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: bcf179ae-dc33-4310-89f3-072e57522145

📥 Commits

Reviewing files that changed from the base of the PR and between 53510d4 and 1603ddc.

📒 Files selected for processing (3)

• apps/mobile/src/features/settings/SettingsServerControlsRouteScreen.tsx
• apps/mobile/src/features/settings/components/SettingsControlRow.tsx
• apps/mobile/src/features/settings/components/SettingsSwitchRow.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds a shared SettingsControlRow component and uses it in SettingsSwitchRow and FanoutSwitchRow. The shared component handles row layout, icon and text rendering, disabled opacity, and Android-specific sizing.

Changes

Settings row consolidation

Layer / File(s)	Summary
Shared control row apps/mobile/src/features/settings/components/SettingsControlRow.tsx	Adds SettingsControlRow with props for disabled state, icon, label, subtitle, and child controls. It renders the shared row layout and applies platform-specific sizing and disabled opacity.
Settings control integrations apps/mobile/src/features/settings/components/SettingsSwitchRow.tsx, apps/mobile/src/features/settings/SettingsServerControlsRouteScreen.tsx	Updates SettingsSwitchRow and FanoutSwitchRow to use SettingsControlRow. Their switch values, handlers, labels, disabled states, accessibility behavior, and mixed-value action remain in place.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1603d

The settings-row consolidation has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: sharing the settings control row layout on mobile.
Description check	✅ Passed	The description explains what changed, why it changed, validation performed, and the scope exclusions. It does not use the template headings or include the required before-and-after screenshots for th…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}