fix(clients): keep backslashes in copied Codex citations

[Lucenx9]

What Changed

Copied Codex file citations now encode backslashes in the Markdown link destination, so the literal file path survives a round trip through any Markdown parser.

Why

The serializer escaped angle brackets and line endings but left backslashes in place. Markdown reads a backslash as an escape character even inside <...> destinations, so reparsing a copied citation corrupted the path:

• C:\repo\[draft].txt copied back as C:\repo[draft].txt
• \\server\share\report.txt lost one leading backslash and stopped parsing as a file link

The copy adapters in web, desktop, and mobile all use this serializer.

Flow

flowchart LR
    A["Codex file citation directive"] --> B["renderCodexDirectivesForCopy / renderCodexFileCitationsAsMarkdown"]
    B --> C["markdownDestination encodes backslash as %5C"]
    C --> D["Copied Markdown"]
    D --> E["Markdown parser"]
    E --> F["parseMarkdownFileLink"]
    F --> G["Same literal path and line"]

Loading

Testing

• New round-trip tests in codexMarkdownDirectives.test.ts cover a Windows bracketed path, a UNC path, a plain relative path, and a literal %5C filename. They fail on main and pass with the fix.
• Targeted tests: 28/28 passed.
• Targeted lint, client-runtime typecheck, and git diff --check pass.

Model: openrouter/stealth/union-alpha
Harness: opencode

Summary by CodeRabbit

• Bug Fixes
  • Fixed Markdown file citations so paths containing Windows backslashes, UNC prefixes, and Unix-style paths are preserved correctly.
  • File citation links now retain their original path when copied or rendered as Markdown, including the associated line number or range.
  • Special characters in citation destinations continue to be safely encoded for reliable link handling.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d3cc9d8c-fc8c-447b-a179-fb97834ef61e

📥 Commits

Reviewing files that changed from the base of the PR and between 1ab2dfb and b5ea4e6.

📒 Files selected for processing (2)

• packages/client-runtime/src/codexFileCitations.ts
• packages/client-runtime/src/codexMarkdownDirectives.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Changes

The citation destination now percent-encodes backslashes. New round-trip tests verify Windows, UNC, relative, and backslash-containing paths while preserving line 7.

File citation path encoding

Layer / File(s)	Summary
Citation destination and round-trip validation packages/client-runtime/src/codexFileCitations.ts, packages/client-runtime/src/codexMarkdownDirectives.test.ts	markdownDestination encodes backslashes as %5C. Tests parse rendered citations and verify the original path and line range through both rendering functions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b5ea4

The citation rendering change preserves supported file paths and line ranges through Markdown parsing, with no known merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: preserving backslashes in copied Codex citations.
Description check	✅ Passed	The description explains what changed, why the change is needed, the affected flow, and the test results. The UI Changes section is not needed because this is not a UI change. The checklist is omitted…

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at b5ea4e6

Macroscope's review found this PR approvable — The production change is limited to percent-encoding backslashes in copied Codex citation destinations, preserving Windows and UNC paths without altering normal rendered links. Focused round-trip tests cover both copy adapters and the relevant path forms.

^{You can add or adjust custom eligibility rules. Learn more.}