fix(release): Windows CLI smoke test no longer fails on temp dir cleanup

[t3dotgg]

The nightly release run 36826019423 failed on Windows arm64. The CLI smoke test passed (--version and serve both worked), but deleting its scratch directory then failed with EBUSY on t3.exe. Windows can keep the file locked for a moment after the server process exits.

The scratch directory is now removed in a finalizer that retries for up to 5 seconds, then logs a warning instead of failing. A leftover temp directory on a CI runner is harmless, so cleanup no longer decides whether the smoke test passes.

Made by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at a718df4

Macroscope's review found this PR approvable — This PR only adjusts the release smoke-test harness to retry transient Windows temp-directory locks and log cleanup failures without changing the CLI checks or product runtime. Its scope is small, self-contained, and limited to CI/release verification.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+40 B (+0.3%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	−3 B (−0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.5 KiB	+43 B (+0.7%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.2 KiB	56.3 KiB	+44 B (+0.1%)	66.4 KiB	✅
Codex	Live turn messages	9	10	+1 (+11.1%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	−17 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−18 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: 71a90ae · PR result: a718df4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 114.0 KiB
• Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 5d85e4d4-cd2b-424e-b4dd-c922d6422c3e

📥 Commits

Reviewing files that changed from the base of the PR and between 71a90ae and a718df4.

📒 Files selected for processing (1)

• scripts/smoke-cli-archive.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The smoke CLI archive script now retries temporary-directory removal during cleanup. It logs a warning if removal still fails after 10 attempts.

Changes

Smoke test cleanup

Layer / File(s)	Summary
Retry temporary-directory cleanup scripts/smoke-cli-archive.ts	The script uses a finalizer to retry recursive removal up to 10 times at 500 ms intervals. If removal still fails, it logs a warning. The script imports Schedule for the retry configuration.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to a718d

The cleanup finalizer runs when the smoke operation succeeds or fails. No concrete merge-blocking risk is established; the change is mergeable under normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the Windows EBUSY failure and the retry-based cleanup change. It does not provide the required Scope and approval information, and it does not clearly document focused verific…	Add a Scope and approval section with the triaged issue, maintainer approval, or an explanation of why this focused obvious-bug fix does not require prior approval. Add a Verification section that lists the commands or checks run, their obs…

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the Windows CLI smoke-test cleanup fix and follows a concise conventional-commit format.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the Windows EBUSY failure and the retry-based cleanup change. It does not provide the required Scope and approval information, and it does not clearly document focused verification results beyond the referenced nightly run.

Resolution

Add a Scope and approval section with the triaged issue, maintainer approval, or an explanation of why this focused obvious-bug fix does not require prior approval. Add a Verification section that lists the commands or checks run, their observed results, and any checks not performed.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

_{Comment @coderabbitai help to get the list of available commands.}