Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughWorkspace-root paths now resolve to ChangesWorkspace-root navigation
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant MarkdownLinkResolver
participant FilePreviewPanel
participant RightPanelStore
MarkdownLinkResolver->>FilePreviewPanel: provide workspace-root path as "."
FilePreviewPanel->>FilePreviewPanel: resolve path to null
FilePreviewPanel->>RightPanelStore: route root request to files surface
RightPanelStore-->>FilePreviewPanel: activate singleton "files" surface
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The workspace-root navigation behavior matches the repository’s Windows path contract, with no actionable current-head risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped workspace-link bug fix that reuses the existing file explorer, leaves non-root files and attachments unchanged, and includes targeted coverage for path normalization and panel state. It does not alter product defaults, schemas, deployment, or static-analysis configuration. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
What Changed
Clicking a chat link to the project directory now opens the workspace file explorer in the web/desktop file panel.
Why
Workspace membership recognized descendants but missed the root itself. The root link was consequently treated as an external file and displayed “Failed to read workspace file.” Recognize the root as
.and route it to the explorer without issuing a file read or a basename search. Root links reuse the existing Files tab, including repeat opens. Other absolute paths retain their existing behavior.Verification
Merged upstream
mainat7445aa733ada33e45289e5aa5055f79142556513(20 September 2026).vp test run packages/client-runtime/src/markdownLinks.test.ts apps/web/src/markdown-links.test.ts apps/web/src/components/files/FilePreviewPanel.test.ts apps/web/src/workspaceBasenameLookup.test.ts apps/web/src/rightPanelStore.test.ts --maxWorkers 1: 247 passed.vp exec tsc --noEmit -p apps/web/tsconfig.json: passed.git diff --check: passed (existing warnings/suggestions may remain).The existing captures show the same root-link resolver and Files-tab behavior. This refresh changes no root-link behavior; the captures retain their original revisions and are not new recordings.
Independent review was attempted before the final upstream sync, directly with
devin -p --model swe-2-maxusing a frozen diff and repository standards. The noninteractive tool-based attempt returned without reviewing; bounded no-tool attempts timed out (status 124) without a verdict. No new independent approval is claimed.UI Changes
Live web verification used the same isolated, seeded conversation and disposable workspace at 1280 × 800. The base is
52e4b4429359904441039a286c61eaafe8474451; the recorded candidate is7737c37654. The subsequent merge from upstream changes diff rendering only; the root-link behavior shown here is unchanged. The actual link was activated through the attached preview’s DOM API. GIFs are sampled at 8 fps with original timing; the MP4 recordings are linked below. This proves shared web behavior, not native Electron IPC. Mobile was not changed or exercised.Before: clicking the project directory opens a file tab with a read error.
File-panel detail:
After: the same link opens the Files explorer with
srcandREADME.md.File-panel detail:
Before recording · After recording
Additional live checks confirmed that README.md renders its actual contents and the root link returns to the explorer. These follow-through checks are not in the comparison recordings.
Checklist
Implemented with GPT-6 Astra in the Codex harness (T3 Code).
Current upstream integration and focused verification: GPT-6 Astra in the Codex harness (T3 Code).