Conversation
shardmods
marked this pull request as ready for review
September 20, 2026 22:32
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe file explorer now supports host directories outside the chat workspace. It resolves entry paths for links, file opening, and drag mentions while preserving original tree paths for deselection. ChangesExternal File Paths
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant FilePreviewPanel
participant FileBrowserPanel
participant DragMentionController
participant Composer
FilePreviewPanel->>FileBrowserPanel: Pass host directory CWD and absolutePaths
FileBrowserPanel->>FileBrowserPanel: Resolve entry path against CWD
FileBrowserPanel->>DragMentionController: Provide resolved path callback
DragMentionController->>Composer: Create mention with resolved path
DragMentionController->>FileBrowserPanel: Deselect original tree path
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Absolute folder links in chat now open a file explorer rooted at the linked folder. Opening a child file or copying/dragging a mention keeps its absolute path, so it continues to refer to the correct location outside the chat's workspace. Directory suffixes are stripped before Windows path conversion when dragging mentions.
Why
Clicking a link to
/Users/user/Coding/t3code-localfrom a chat in/Users/user/Amethyst/designopened a file preview and failed because the target was a directory. The existing directory fallback excluded absolute paths. This extends that fallback by giving the explorer the linked directory as its root.Related: #10909 added the workspace-relative folder fallback. #12449 handles links to the current workspace root; this fix also handles directories outside that workspace.
UI Changes
Captured in an isolated web development instance using the same seeded chat. Before: the folder link produces a read error. After: it opens the folder's contents; selecting a child file opens its contents from that folder. The shared web/desktop panel changed; native desktop and mobile were not separately exercised. Captured at 1280 × 800 against the upstream base and the PR patch.
Before/after interaction recording — the fixed flow starts at 0:10; an idle pause is cut at 0:20.
Validation
FilePreviewPanel.test.ts,projectFilesQueryState.test.tsx, andfileTreeDragMention.test.ts.git diff --checkpassed.Checklist
Implemented and reviewed with GPT-6 through the Codex harness in T3 Code.
Summary by CodeRabbit
New Features
Bug Fixes