Skip to content

fix(release): Windows CLI smoke test no longer fails on temp dir cleanup #14553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3dotgg merged 1 commit into from
Oct 1, 2026
Merged

fix(release): Windows CLI smoke test no longer fails on temp dir cleanup #14553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion scripts/smoke-cli-archive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import * as FileSystem from "effect/FileSystem";
import * as Layer from "effect/Layer";
import * as Logger from "effect/Logger";
import * as Path from "effect/Path";
import * as Schedule from "effect/Schedule";
import * as Schema from "effect/Schema";
import * as Stream from "effect/Stream";
import { Command, Flag } from "effect/unstable/cli";
Expand Down Expand Up @@ -73,7 +74,18 @@ const smokeCliArchive = Effect.fn("smokeCliArchive")(function* (input: {
const path = yield* Path.Path;
const platform = yield* HostProcessPlatform;
const spawner = yield* ChildProcessSpawner.ChildProcessSpawner;
const scratch = yield* fs.makeTempDirectoryScoped({ prefix: "t3-cli-smoke-" });
const scratch = yield* fs.makeTempDirectory({ prefix: "t3-cli-smoke-" });
// Windows can keep t3.exe locked (EBUSY) for a moment after the server
// exits. A leftover scratch directory on a CI runner is harmless, so
// cleanup retries briefly and never fails a smoke test that passed.
yield* Effect.addFinalizer(() =>
fs.remove(scratch, { recursive: true }).pipe(
Effect.retry({ times: 10, schedule: Schedule.spaced("500 millis") }),
Effect.catch((error) =>
Effect.logWarning(`[cli-smoke] could not remove ${scratch}: ${error.message}`),
),
),
);

// On Windows the archive is a zip and the Git Bash `tar` on PATH is GNU
// tar; use the bsdtar Windows ships, which reads both formats.
Expand Down
Loading