fix: cloned projects show their favicon instead of a monogram

[t3dotgg]

Cloning a repo into T3 Code showed a generated monogram instead of the repo's favicon. The same repo on other machines showed the right icon. Only a reload fixed it.

The server creates the project before git writes any files. Clients ask for the icon at once, the server finds nothing in the empty folder and caches that miss for a minute, and the client keeps the "missing" answer for up to 30 minutes. In the case that prompted this, the lookup ran 1 s before the clone wrote its files, and nothing asked again.

Fix

• Server: while a project's clone is unfinished, assets.createUrl answers "missing" without running the favicon resolver, so no miss is cached.
• Clients: the shared project favicon family asks again whenever the phase of the clone into that folder changes. Web, desktop, and mobile all use it. Progress updates do not trigger a lookup.

Holding the request open until the clone lands was simpler, but web shows a slow-request toast for any RPC pending over 15 s.

Related: #13121 fixes the same bug on t3code/codex-turn-mapping with a different approach. This one targets main.

Reviewed with sol-loop: 2 rounds with gpt-6.1-sol on high.

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	−39 B (−0.3%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	−5 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−34 B (−0.5%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.3 KiB	56.2 KiB	−44 B (−0.1%)	66.4 KiB	✅
Codex	Live turn messages	10	9	−1 (−10.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.5 KiB	−25 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	−2 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	−23 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.1 KiB	57.0 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	10	9	−1 (−10.0%)	21	✅

Baseline: bed69f6 · PR result: 11f26aa · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 114.0 KiB
• Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at 11f26aa

Macroscope's review found this PR approvable — This is a narrowly scoped cross-client fix that prevents cloned-project favicon misses from being cached and refreshes the icon after the checkout completes, with targeted server and client tests. An unresolved Medium finding notes that failed or cancelled clones may still suppress an existing favicon, which should be addressed separately.

Notes:

• This verdict was updated automatically after the outstanding correctness findings were resolved. Macroscope did not re-review the code.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: ef07249a-4338-4ace-8314-600f0e98d9ac

📥 Commits

Reviewing files that changed from the base of the PR and between bed69f6 and 11f26aa.

📒 Files selected for processing (9)

• apps/mobile/src/state/assets.ts
• apps/mobile/src/state/projectClones.ts
• apps/server/src/assets/AssetAccess.ts
• apps/server/src/server.test.ts
• apps/server/src/ws.ts
• apps/web/src/state/assets.ts
• apps/web/src/state/projectClones.ts
• packages/client-runtime/src/state/assets.test.ts
• packages/client-runtime/src/state/assets.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The client refreshes project favicon URL requests when the matching clone phase changes. The server treats the favicon as missing while a clone targeting the project workspace is unfinished, then resolves it after checkout completes.

Changes

Project favicon refresh

Layer / File(s)	Summary
Handle favicon requests during checkout apps/server/src/ws.ts, apps/server/src/assets/AssetAccess.ts, apps/server/src/server.test.ts	The WebSocket handler marks a favicon lookup as pending for an unfinished clone whose destination matches the workspace root. Asset URL issuance skips favicon path resolution while pending. An integration test checks requests during and after cloning.
Refresh client favicon URLs from clone state packages/client-runtime/src/state/assets.ts, packages/client-runtime/src/state/assets.test.ts, apps/web/src/state/projectClones.ts, apps/web/src/state/assets.ts, apps/mobile/src/state/projectClones.ts, apps/mobile/src/state/assets.ts	The runtime refreshes the favicon URL request when the matching clone phase changes. Web and mobile supply clone state to the runtime; tests cover matching and non-matching destinations and an initially completed clone.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant WebSocketClient
  participant projectFaviconHandler
  participant CloneState
  participant issueAssetUrl
  WebSocketClient->>projectFaviconHandler: request project-favicon URL
  projectFaviconHandler->>CloneState: read clone phase and destination
  CloneState-->>projectFaviconHandler: matching clone is unfinished
  projectFaviconHandler->>issueAssetUrl: issue URL with checkout pending
  issueAssetUrl-->>WebSocketClient: missing-resource URL
  WebSocketClient->>projectFaviconHandler: request project-favicon URL again
  projectFaviconHandler->>CloneState: read clone phase and destination
  CloneState-->>projectFaviconHandler: matching clone is done
  projectFaviconHandler->>issueAssetUrl: issue URL without checkout pending
  issueAssetUrl-->>WebSocketClient: URL for resolved favicon

Loading

Suggested reviewers: juliusmarminge, maria-rcks

Merge Risk: ⚪ Minimal · up to 11f26

Cloned projects should now show their favicon once the clone finishes. No merge-blocking risk was found in the reviewed changes.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description clearly explains the problem and implementation, but it omits the required Scope and approval section and focused Verification results.	Add a Scope and approval section with the issue, maintainer approval, or a clear explanation of why this focused bug fix qualifies without prior approval. Add a Verification section with the specific tests or manual checks run, observed res…
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 9 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary fix: cloned projects display their favicon instead of a generated monogram.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Resolution

Add a Scope and approval section with the issue, maintainer approval, or a clear explanation of why this focused bug fix qualifies without prior approval. Add a Verification section with the specific tests or manual checks run, observed results, and any checks that were not performed.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

_{Comment @coderabbitai help to get the list of available commands.}