Skip to content

fix(web): let command menu descriptions use the full row width - #8865

Open
jakaskerjanc wants to merge 3 commits into
pingdotgg:mainfrom
jakaskerjanc:fix/composer-command-description-width
Open

jakaskerjanc wants to merge 3 commits into
pingdotgg:mainfrom
jakaskerjanc:fix/composer-command-description-width

Conversation

@jakaskerjanc

@jakaskerjanc jakaskerjanc commented Aug 31, 2026 •

Copy link
Copy Markdown

The description text in the composer / and $ menus was capped at max-w-[48ch]. Long descriptions truncated well before the row ran out of space, leaving a gap of dead space between the text and the right-aligned source badge.

This was especially bad for skills, whose descriptions are prefixed, prefix ate most of the 48ch budget.

This drops the cap. The description span keeps flex-1 and min-w-0 truncate, so it now grows to fill the row up to the badge before showing an ellipsis. The source badge stays pinned to the right edge in every case (it is the last child after a growing element and carries ms-auto), so row alignment is unchanged.

The max-w-[48ch] was added in #8009 as part of "shortened long descriptions"; it was a purely cosmetic clamp, not a layout requirement.

Before / After

Before:
image

After:
image

Validation

  • vp fmt apps/web/src/components/chat/ComposerCommandMenu.tsx apps/web/src/components/chat/ComposerCommandMenu.test.tsx --check
  • vp lint apps/web/src/components/chat/ComposerCommandMenu.tsx apps/web/src/components/chat/ComposerCommandMenu.test.tsx --report-unused-disable-directives
  • vp run --filter @t3tools/web typecheck
  • vp test run apps/web/src/components/chat/ComposerCommandMenu.test.tsx (4 tests pass)

This is shared web/desktop UI; native mobile has its own composer menu and is unchanged.

Built with Claude Sonnet 5 in T3 Code.

🤖 Generated with Claude Code

Note

Remove 48-character cap on ComposerCommandMenuItem descriptions

Removes the fixed max-width on the description span in ComposerCommandMenu.tsx. Descriptions now fill the available flex row width, with overflow still truncated.

Macroscope summarized bafbb0a.


Note

Low Risk
Single Tailwind class removal in shared composer menu UI with no logic or data-handling changes.

Overview
Removes the max-w-[48ch] cap on the description line in the composer / and $ command menu items so secondary text can use the space between the label and the skill source badge.

The description span still uses flex-1, min-w-0, and truncate, so long text ellipsizes only when the row is actually full; the right-aligned badge layout is unchanged.

Reviewed by Cursor Bugbot for commit bafbb0a. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Style
    • Improved command menu item descriptions to use available space more effectively while preserving text truncation.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f0b17fda-aba4-4a29-a2b2-c7d1d9256c49

📥 Commits

Reviewing files that changed from the base of the PR and between aff9318 and 358a6d4.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/ComposerCommandMenu.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The command menu description span no longer has a 48ch maximum width. It now uses available flex space before truncation.

Changes

Command menu layout

Layer / File(s) Summary
Description width adjustment
apps/web/src/components/chat/ComposerCommandMenu.tsx
The description span removes max-w-[48ch] while retaining flexible sizing and truncation.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: chrisdeeming

Merge Risk: ⚪ Minimal · up to 358a6

Command descriptions can use more available width while still truncating safely. No merge-blocking risk is currently identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: allowing command menu descriptions to use the full row width.
Description check ✅ Passed The description explains what changed, why it changed, the UI impact, screenshots, and validation results. It does not include the template's explicit Checklist section, but the required information i…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 31, 2026
Slash/skill menu descriptions were capped at max-w-[48ch], so long
descriptions truncated early and left dead space before the source badge.
Drop the cap; the description keeps flex-1 and min-w-0 so it now fills the
row up to the badge before showing an ellipsis. Badge stays right-aligned.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@jakaskerjanc
jakaskerjanc force-pushed the fix/composer-command-description-width branch from 8ae3f5a to 2f6e067 Compare August 31, 2026 07:14
@jakaskerjanc
jakaskerjanc marked this pull request as ready for review August 31, 2026 07:14
@macroscopeapp

macroscopeapp Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at bafbb0a

Macroscope's review found this PR approvable — This is a one-line, self-contained layout adjustment that allows command descriptions to consume unused row width while retaining truncation and badge alignment. It has no logic, data, API, security, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 31, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 2, 2026 08:15

Dismissing prior approval to re-evaluate bafbb0a

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant