Skip to content

fix(web): point V2LifecycleRow's AgentElapsed import at its new module - #12851

Closed
saphid wants to merge 605 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-lifecycle-agent-elapsed-import
Closed

saphid wants to merge 605 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-lifecycle-agent-elapsed-import

Conversation

@saphid

@saphid saphid commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

What Changed

One-line import fix: V2LifecycleRow.tsx imports AgentElapsed from ../AgentsPanel, but #12835 moved the component to chat/AgentElapsed.tsx. #12842, which added the row, merged after the move and kept the old path.

Why

The base branch tip currently fails the Check typecheck (TS2307: Cannot find module '../AgentsPanel') and the MessagesTimeline.test.tsx suite for every open branch, including its own commits.

Verification

  • pnpm typecheck (web): zero error TS at this commit; the same checkout without the fix reports the TS2307 above.

  • vp test run apps/web/src/components/chat/MessagesTimeline.test.tsx: 66 passed.

  • This PR is small and focused

  • I explained what changed and why

  • I included before/after screenshots for any UI changes

- Re-route steering that races completion into idempotent follow-up dispatches
- Preserve scheduled-task attribution and provider ownership history across clients
Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2.

Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.
Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip.

Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.
Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.
Adopt TypeScript 7 and Effect rc.112 across orchestration v2, including the TaggedError API migration and updated Effect-aware tests. Restore main's composer-aware scroll-to-end clearance while retaining selected-model settings sync, preview recording transfer, image galleries, desktop context menus, and layout hit targets. Regenerate the lockfile on the upgraded dependency baseline.
Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.
Restore pinned-thread shelf classification, server-owned unread state, hidden-subagent-safe project ordering, guarded jump hints, draft upload cleanup, and active-provider archive guards across the current and legacy sidebars.

Bring the surrounding current-main sidebar work forward as well: canonical project favicons, stable row layout, thread file drops, account-aware mobile provider badges, and deferred desktop keyring loading.
Keep collapsed model controls in a strip, contain transition overflow, and preserve timeline spacing. Render approval requests as regular grouped worklog entries.

Implemented with GPT-6-Astra via Codex.
Bil0000 and others added 23 commits September 20, 2026 20:04
…g#12491)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Vitalii Yehorov <vitalyiegorov@gmail.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 21, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at f7518be

Macroscope's review found this PR approvable — This one-line change redirects V2LifecycleRow to the existing AgentElapsed module after the old import path was removed. It restores module resolution without changing the component’s behavior or product defaults.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from a1f8051 to 0337dd6 Compare September 21, 2026 05:40
@saphid

saphid commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the base branch was force-pushed with the same repair (the stale ../AgentsPanel import is gone at the new tip), so this is no longer needed. Keeping the report: the tip between #12835 and this rewrite failed Check and Test for every open branch.

@saphid saphid closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants