Skip to content

fix(web): show subagent models and running count in Lineage - #12491

Merged
shivamhwp merged 5 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-subagent-model-tooltip
Sep 19, 2026
Merged

shivamhwp merged 5 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-subagent-model-tooltip

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

V2 sub-agent tooltips showed "Unknown" when the sub-agent record omitted its model, even when the child thread had a model selection.

Use the child thread as a fallback and resolve model aliases with the existing composer name helpers. Both Lineage and timeline tooltips open after 200 ms instead of the default 600 ms. The Lineage title shows the running sub-agent count across all pages, includes agents awaiting a child thread, and hides the count at zero.

If neither record provides a model, the tooltip says "Not reported" instead of guessing. This changes the shared web/desktop UI; mobile has no hover tooltip.

Verified with 47 focused tests, web typecheck, and lint. Reproduced the bug and checked the fix at 1280 px and 820 px in an isolated app; measured the tooltip opening at 226 ms.

Rebased onto the current t3code/codex-turn-mapping tip after the base branch was force-pushed. The previously noted Test Server 3 failure in the unchanged queued_cancelled_while_active/codex replay scenario is resolved by ea483d1b9 ("fix(server): unblock orchestrator CI checks") on the new base.

Before:
Unknown model before the fix

After:
Model name and running count after the fix

Hover timing:
Hover timing

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at f8b3940

Macroscope's review found this PR approvable — This is a small, self-contained web UI fix that improves existing subagent tooltips and Lineage status visibility without changing orchestration, schemas, product defaults, or static-analysis configuration. Focused tests cover the added display behavior.

No code changes detected at ebefc29. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 18, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 18, 2026 18:10

Dismissing prior approval to re-evaluate e323208

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from bda6344 to bb072a5 Compare September 18, 2026 18:48
@Bil0000
Bil0000 force-pushed the fix-subagent-model-tooltip branch from f8b3940 to b75d913 Compare September 18, 2026 18:58
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 6 times, most recently from 5ff0a93 to fd8ea2f Compare September 19, 2026 04:23
@Bil0000
Bil0000 force-pushed the fix-subagent-model-tooltip branch from b75d913 to ebefc29 Compare September 19, 2026 07:29
@Bil0000

Bil0000 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the current t3code/codex-turn-mapping tip (f180e95).

The base branch was force-pushed, which stranded this PR: GitHub compared it against a rewritten base, so it reported CONFLICTING with ~1400 changed files that were never part of this change. This PR's own commits were replanted onto the new base tip; every commit applied with no conflicts, and the diff against the new base is identical to the diff before the rebase. No behavior was changed as part of the rebase.

@shivamhwp
shivamhwp merged commit e969348 into pingdotgg:t3code/codex-turn-mapping Sep 19, 2026
22 checks passed
juliusmarminge pushed a commit that referenced this pull request Sep 21, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 21, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants