Skip to content

fix(chat): present and summarize all T3 tools - #12671

Merged
juliusmarminge merged 2 commits into
t3code/codex-turn-mappingfrom
fix/t3-tool-presentations
Sep 20, 2026
Merged

juliusmarminge merged 2 commits into
t3code/codex-turn-mappingfrom
fix/t3-tool-presentations

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

T3 MCP tools such as project listing and cloning currently show raw tool names and generic activity summaries. This gives all 70 published tools, plus the legacy thread-start tool, shared branding, readable lifecycle labels, and action summaries used by web, desktop, and mobile. Returned MCP errors now show failed activity and do not count as successful changes.

A toolkit inventory test prevents newly published tools from silently missing presentation or summary metadata.

Validation: 360 focused tests pass, targeted lint passes, and scoped shared, client-runtime, web, mobile, and server typechecks pass. The real web client was verified with an isolated demo thread covering project, queue, and pending-question tools. Desktop uses that web client; mobile has a focused activity-feed regression test.

Before:

Before: raw T3 tool names and generic activity summaries

After:

After: T3 branding, readable labels, and action summaries

Built with GPT-6 in Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.1 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 1 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.7 KiB — 29.3 KiB ✅
Claude Live turn messages — 1 — 8 ✅

Baseline: unavailable · PR result: de6bc06 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge marked this pull request as ready for review September 20, 2026 04:20
@macroscopeapp

macroscopeapp Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR substantially changes existing chat activity behavior across web, desktop, and mobile by adding structured presentation and summaries for nearly the entire T3 tool inventory, including new failure-state rendering. The implementation is tested and isolated from execution, schema, deployment, and security paths, but its broad user-visible runtime impact warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 7ec43fa into t3code/codex-turn-mapping Sep 20, 2026
24 checks passed
@juliusmarminge
juliusmarminge deleted the fix/t3-tool-presentations branch September 20, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant