Skip to content

feat(web): list linked PRs in workspace card - #12574

Merged
shivamhwp merged 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:t3code/e0e75938
Sep 20, 2026
Merged

shivamhwp merged 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:t3code/e0e75938

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

A thread can link several pull requests, but the Workspace card showed only one.

Keep the current PR row as it was. Add Show N more to reveal the other linked PRs in stack order. Each revealed PR uses the existing row, so its checks and available action come from that PR. Collapsing the list removes the extra rows and their host reads.

Verified with 8 focused tests, web typecheck, targeted lint, and the running web app with four linked PRs. The app check covered collapsed and expanded views, passing and failing checks, Fix, Resolve, and a merged PR.

Expanding the list makes one detail request per revealed PR; the collapsed card does not.

Before:

Workspace card with one linked PR

After:

Workspace card expanded to show linked PRs

Built with GPT-5 in Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 19, 2026
Comment thread apps/web/src/components/chat/ThreadDetailsPrRows.tsx
@macroscopeapp

macroscopeapp Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds an expandable linked-pull-request capability to workspace cards and causes each revealed row to use existing detail, check-refresh, and PR-action behavior. The change is localized and tested, but its new user-facing workflow and additional host reads warrant human review.

You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/web/src/components/chat/ThreadDetailsPrRows.tsx
@macroscopeapp

This comment has been minimized.

@Bil0000

Bil0000 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

CI needs a maintainer rerun: Test Server 2 failed in apps/server/src/vcs/GitVcsDriverCore.test.ts (keeps complete stats for files beyond the combined patch limit). This PR changes only three web files. I ran that exact test locally on the PR head and it passed. GitHub refused both failed-job rerun routes with 403 Must have admin rights to Repository. Could a maintainer rerun the failed job?

@shivamhwp
shivamhwp merged commit 7f32e0f into pingdotgg:t3code/codex-turn-mapping Sep 20, 2026
22 checks passed
juliusmarminge pushed a commit that referenced this pull request Sep 21, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 21, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 25, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants