Skip to content

fix(web): keep workspace card action hover uniform - #12766

Merged
maria-rcks merged 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:uniform-workspace-card-actions
Sep 20, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:uniform-workspace-card-actions

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Workspace card split actions added a second background when hovering their right-hand button. Keep both halves transparent so the row supplies one hover color, matching the branch selector. Apply the same shared style to PR checks.

Covers editor, project script, Git, PR action, and lineage split controls in the inline card and popover. This changes panel styles only; toolbar controls and action behavior stay the same.

Verified: 123 focused tests, web typecheck and build, targeted lint and formatting. Checked hover and pressed backgrounds in the real app in dark/light themes, at 1280px and 900px, and opened the action menus. The fixture did not expose every PR/lineage state; those use the shared styles reviewed here.

Before and after show the same Actions arrow hover. Other app content is hidden and the card is enlarged for clarity.

Before After
Before: extra tint on Actions arrow After: one hover color across the row

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 20, 2026
Comment thread apps/web/src/components/chat/ThreadDetailsPrRow.tsx
@macroscopeapp

macroscopeapp Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at eeab10c

Macroscope's review found this PR approvable — This is a narrowly scoped visual fix that standardizes hover and pressed backgrounds for existing thread-details controls without changing interaction behavior or broader product defaults. The remaining comment requests a component-variant refactor for consistency but does not identify a functional defect.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit 37671bd into pingdotgg:t3code/codex-turn-mapping Sep 20, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants