Skip to content

feat(web): clearer icons for the workspace panel controls - #12838

Merged
maria-rcks merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/workspace-control-icons
Sep 21, 2026
Merged

maria-rcks merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/workspace-control-icons

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

replaces the filter glyph on thread details with square-menu. the terminal drawer keeps its original panel-bottom; PanelRight and Maximize2 / Minimize2 stay unchanged.

before and after: actual title-bar controls in dark and light, unpressed

original candidate galleries below use the actual control components. each candidate appears at 16px in the app's ghost toggle, unpressed then pressed.

dark theme: current and proposed workspace controls with 28 details and 14 terminal candidates

light theme: current and proposed workspace controls with 28 details and 14 terminal candidates

runner-ups:

  • Info: readable, but suggests passive information; thread details also contains workspace and git actions.
  • LayoutList: conveys organized content, but the small boxes add visual noise at 16px.
  • PanelRightOpen: suggests a one-way opening action and resembles the adjacent right-panel toggle.
  • Terminal / SquareTerminal: considered for the terminal drawer; the original PanelBottom is retained.

verification: web typecheck and scoped lint passed on blacksmith for 63d995b018. captured the actual unpressed control row in dark and light. details and right-panel toggles open and close. the terminal drawer opens and closes with the correct pressed state; terminal session content remains unavailable in the copied dev state. no matching action icons needed changes in the command palette, keybinding help, mobile, or user docs. desktop shares this component; native desktop was not separately exercised. provider adapters and contracts are unchanged.

Written by gpt-6-astra (Codex) in T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 21, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 21, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 63d995b

Macroscope's review found this PR approvable — This single-file change only replaces an existing panel-control icon while preserving the toggle’s state, interactions, labels, and panel behavior. It introduces no schema, configuration, deployment, or sensitive-data changes.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 21, 2026 04:34

Dismissing prior approval to re-evaluate 63d995b

@maria-rcks
maria-rcks merged commit 283fe9c into pingdotgg:t3code/codex-turn-mapping Sep 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant