Skip to content

refactor(web): remove the agents right panel - #12835

Merged
maria-rcks merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/remove-agents-panel-current
Sep 21, 2026
Merged

maria-rcks merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/remove-agents-panel-current

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

The thread's lineage control already shows its subagents, so the duplicate Agents right-panel surface is removed. This deletes the tab, launcher/menu entry and shortcut, roster, and panel-toggle badge; the badge existed only to point at that surface. The elapsed helper moves unchanged beside lineage, and persisted Agents selections fall back to a surviving tab or close an empty panel.

Verified on Blacksmith: web typecheck, targeted lint (0 errors), and all 92 tests across the two affected existing test files. Browser checks with a real-data snapshot covered Files/Diff switching, the add menu, lineage expansion and child navigation, and legacy persisted state migration (including preserving a closed panel's surviving selection). No new test files.

All required checks pass on 71820f35433c5a2eed87db5467c6acd89dd7faa4, including all server shards. Two independent final code reviews approved this head.

Known follow-up: lineage excludes native subagents without a child thread. This pass follows the explicit request to delete the roster and leave lineage unchanged; transcript subagent rendering is preserved.

Before, dark:

before: agents right panel in dark theme

Before, light:

before: agents right panel in light theme

After, dark:

after: right panel without agents in dark theme

After, light:

after: right panel without agents in light theme

Written by gpt-6-astra (Codex) in T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 21, 2026
Comment thread apps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeapp Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change removes the dedicated Agents right-panel workflow, including its roster, workflow/script details, token summaries, shortcut, and live-status affordances, while migrating persisted panel state to the remaining surfaces. The replacement lineage display and cleanup are coherent, but the user-facing behavior change is substantial enough to require human review.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit a7d42df into pingdotgg:t3code/codex-turn-mapping Sep 21, 2026
27 checks passed
juliusmarminge added a commit to Bil0000/t3code that referenced this pull request Sep 21, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bil0000 pushed a commit to Bil0000/t3code that referenced this pull request Sep 23, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bil0000 pushed a commit to Bil0000/t3code that referenced this pull request Sep 23, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bil0000 pushed a commit to Bil0000/t3code that referenced this pull request Sep 24, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
juliusmarminge added a commit to Bil0000/t3code that referenced this pull request Sep 24, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bil0000 pushed a commit to Bil0000/t3code that referenced this pull request Sep 25, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bil0000 pushed a commit to Bil0000/t3code that referenced this pull request Sep 25, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
juliusmarminge added a commit to Bil0000/t3code that referenced this pull request Sep 25, 2026
AgentsPanel was removed on the v2 branch (pingdotgg#12835); the Lineage workflow row
now imports AgentElapsed from ./AgentElapsed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant