feat(web): show a turn's subagents as one collapsible card - #12839
juliusmarminge merged 7 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes the production chat timeline by filtering delegation rows and replacing existing subagent rendering with a live collapsible card containing new status, timing, result, and navigation behavior. The multi-file user-facing change is broader than a bounded additive option and merits human review. You can add or adjust custom eligibility rules. Learn more. |
|
UI consistency review posted one inline finding. Posted via Macroscope — UI Consistency |
|
Note Written by taking over this pr for a design pass on the card. plan before touching code:
|
This comment has been minimized.
This comment has been minimized.
a1f8051 to
0337dd6
Compare
round provider avatars with the agents panel's status dots, an overlapped stack in the collapsed header with status counts and elapsed time, one clean row per subagent inside a single bordered card, and the agents panel's status words instead of the raw child-task sentence. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…own group durations
AgentsPanel was removed on v2, so the status visuals and elapsed timer the card reused now live in V2LifecycleRow and AgentElapsed; the hover card from pingdotgg#12842 is kept inside the new SubagentAvatar rows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
99e49fa to
a629461
Compare
|
Rebased this PR onto Conflicts resolved
These are in one extra commit on top ( Verified
Notes for reviewers
Rebased and touched up by a maintainer's agent; a human will re-review. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
All clear Posted via Macroscope — UI Consistency |
5ccb2a5
into
pingdotgg:t3code/codex-turn-mapping
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
consecutive subagent launches were split by duplicate
delegate_taskrows in the work log. this groups matched launches into one collapsible card with stacked provider avatars, status, progress/results, and the existing child-thread link and tooltip. failed and unmatched delegation calls remain visible.the card follows the pr tab's collapsed-comments block and the agents panel: round provider avatars with the panel's status dots, an overlapped stack in the collapsed header with status counts (
1 done · 2 failed) and elapsed time, one row per subagent inside a single bordered card with the panel's status words instead of the raw child-task sentence, and a single truncated result line with markdown stripped. static dots only, no repainting animation. grouping, persisted expansion state, and child-thread navigation are unchanged.verified: web typecheck, scoped lint, and 197 existing timeline tests on blacksmith; real persisted provider data through the dev server/client in dark and light, full width and with the right panel open, expand/collapse, and child-thread navigation. a live working subagent was not exercised. native desktop and mobile are not in scope.
Written by gpt-6-astra (Codex) and claude-fable-5-1 (Claude Code) in T3 Code
🤖 Generated with Claude Code