Skip to content

feat(web): give lineage subagent hovers the thread hover card - #12842

Merged
maria-rcks merged 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/lineage-hover-card
Sep 21, 2026
Merged

maria-rcks merged 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/lineage-hover-card

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Subagent hovers in Lineage showed label/value rows and wrapping activity text. They now reuse the sidebar thread hover's glass shell, title spacing, and compact provider/model row, with sidebar-style status, elapsed time, and a single middle-truncated detail line. The timeline uses the same content; existing result selection, differing-project/workspace metadata, and triggers are preserved.

Verified web typecheck, web lint (existing warnings, no errors), and all 72 existing timeline and relationship tests on Blacksmith. Inspected Lineage in dark/light and the timeline hover against a snapshot of real provider data. The sampled agent has completed, so these captures show its result; a live running-provider transition remains unverified.

before, dark:

lineage hover before, dark

after, dark:

lineage hover after, dark

before, light:

lineage hover before, light

after, light:

lineage hover after, light

existing sidebar reference:

sidebar thread hover reference

Written by gpt-6-astra (Codex) in T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 21, 2026
Comment thread apps/web/src/components/chat/SubagentTooltipContent.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new shared hover-card component and changes existing lineage and timeline subagent hovers with provider, status, elapsed-time, metadata, and preview behavior. The change is isolated to web UI and has no schema or infrastructure impact, but its always-active user-facing behavior across multiple production surfaces warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp

This comment has been minimized.

@maria-rcks
maria-rcks merged commit a1f8051 into pingdotgg:t3code/codex-turn-mapping Sep 21, 2026
24 checks passed
juliusmarminge added a commit to maria-rcks/t3libre that referenced this pull request Sep 21, 2026
AgentsPanel was removed on v2, so the status visuals and elapsed timer the
card reused now live in V2LifecycleRow and AgentElapsed; the hover card from
pingdotgg#12842 is kept inside the new SubagentAvatar rows.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant