Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped server bug fix that aligns V2 linked-pull-request settlement with the existing settlement policy while preserving unlinked-thread behavior. A focused regression test covers the previously missed merged-link case. You can add or adjust custom eligibility rules. Learn more. |
shivamhwp
merged commit Sep 19, 2026
76288a3
into
pingdotgg:t3code/codex-turn-mapping
24 checks passed
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
V2 stores PR links in
pullRequests, but automatic settlement checked only the older single-PR fields. A merged link could remain active when those fields were empty.Change
Use visible linked PR snapshots for settlement, matching main's open-link and latest-merge rules. Skip branch lookups when visible links already own the settlement decision.
Verification
Risk
A linked PR settles after its snapshot syncs, as on main. This changes only V2 server settlement.
Model: GPT-5 in the native Codex harness.