fix(web): hide raw image markup in queue previews - #12820
Merged
maria-rcks merged 2 commits intoSep 21, 2026
Merged
maria-rcks merged 2 commits into
maria-rcks merged 2 commits into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This narrowly scoped web UI fix only changes queued-message preview rendering, replacing raw context links with readable text while preserving the original content for editing. It introduces no schema, configuration, security, billing, deployment, or production workflow changes. You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
September 21, 2026 01:19
Dismissing prior approval to re-evaluate 2f3ec0c
maria-rcks
merged commit Sep 21, 2026
a74e160
into
pingdotgg:t3code/codex-turn-mapping
22 of 25 checks passed
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 21, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 23, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 24, 2026
juliusmarminge
pushed a commit
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued image attachments exposed raw
markup in the message preview and tooltip. Remove image references already represented by thumbnails and show readable labels for other context references. Preserve the original compact thumbnail layout and the raw message used for editing.Verified saved image attachments through the real web client. The thumbnails retain their original size, cropping, spacing, and placement. Blacksmith: 11 existing queue/edit tests, scoped lint, and web typecheck passed. Both independent reviewers approved head
2f3ec0c.before:
after:
Latest CI is blocked by the unchanged base branch: server typecheck at
apps/server/src/orchestration-v2/ProjectionStore.ts:3413(effect/preferSchemaOverJsonforJSON.stringify). The file is identical to basee8345a471c4533f227fba12447e15728d75b2217; this PR only changes the queue component. Two server test shards are still running.Model: gpt-6-astra. Harness: Codex.