Skip to content

fix(web): hide raw image markup in queue previews - #12820

Merged
maria-rcks merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/ov2-queue-images
Sep 21, 2026
Merged

maria-rcks merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/ov2-queue-images

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Queued image attachments exposed raw ![...](t3-context://...) markup in the message preview and tooltip. Remove image references already represented by thumbnails and show readable labels for other context references. Preserve the original compact thumbnail layout and the raw message used for editing.

Verified saved image attachments through the real web client. The thumbnails retain their original size, cropping, spacing, and placement. Blacksmith: 11 existing queue/edit tests, scoped lint, and web typecheck passed. Both independent reviewers approved head 2f3ec0c.

before:

before: compact queue with raw image markup

after:

after: original compact queue with readable message text

Latest CI is blocked by the unchanged base branch: server typecheck at apps/server/src/orchestration-v2/ProjectionStore.ts:3413 (effect/preferSchemaOverJson for JSON.stringify). The file is identical to base e8345a471c4533f227fba12447e15728d75b2217; this PR only changes the queue component. Two server test shards are still running.

Model: gpt-6-astra. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 21, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 21, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2f3ec0c

Macroscope's review found this PR approvable — This narrowly scoped web UI fix only changes queued-message preview rendering, replacing raw context links with readable text while preserving the original content for editing. It introduces no schema, configuration, security, billing, deployment, or production workflow changes.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 21, 2026 01:19

Dismissing prior approval to re-evaluate 2f3ec0c

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 21, 2026
@maria-rcks maria-rcks changed the title fix(web): render queued image previews without raw context links fix(web): hide raw image markup in queue previews Sep 21, 2026
@maria-rcks
maria-rcks merged commit a74e160 into pingdotgg:t3code/codex-turn-mapping Sep 21, 2026
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant