Skip to content

fix(web): make PR badge hover lists easy to click - #12378

Merged
shivamhwp merged 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-pr-link-mouse-access
Sep 20, 2026
Merged

shivamhwp merged 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
Bil0000:fix-pr-link-mouse-access

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Moving the mouse from a PR badge into its list crossed a 4px gap. In the sidebar, the thread tooltip could take over there and close the list before a PR could be clicked.

Remove the gap in the shared sidebar/composer PR control. Use the same clickable list row and glass popup for a single PR, including branch PRs with no saved links. Keep the existing badge actions and modified-click behavior.

Verification

  • Reproduced the mouse failure in the real app before the change; the same automated Chromium path passes after it.
  • Checked all five linked PRs and a single branch PR at 1280px and 900px widths, plus the composer footer, keyboard focus/Escape, and Ctrl-click.
  • All 53 focused ThreadStatusIndicators tests pass; targeted lint, format check, and web typecheck pass.

Scope: one shared web component, used by web and desktop. No server, contract, or mobile changes.

Single PR

Before After
Single PR before Single PR after

Multiple PRs

Before After
Multiple PRs before Multiple PRs after

Mouse path before and after

t3-pr-hover-before-after.mp4

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at b745c15

Macroscope's review found this PR approvable — This is a contained one-file web UI fix that removes the hover gap and makes existing single- and multi-PR tooltip rows clickable while preserving current navigation behavior. It introduces no schema, infrastructure, security-sensitive, product-default, or static-analysis changes.

No code changes detected at 196cbdd. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 73bbe82 to c267746 Compare September 18, 2026 06:36
@Bil0000
Bil0000 force-pushed the fix-pr-link-mouse-access branch from b745c15 to 8a778f7 Compare September 18, 2026 08:38
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from c267746 to 934da57 Compare September 18, 2026 08:57
@Bil0000
Bil0000 force-pushed the fix-pr-link-mouse-access branch from 8a778f7 to 76d2aa1 Compare September 18, 2026 09:46
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 8 times, most recently from 5ff0a93 to fd8ea2f Compare September 19, 2026 04:23
@Bil0000
Bil0000 force-pushed the fix-pr-link-mouse-access branch from 76d2aa1 to 665a6df Compare September 19, 2026 07:29
@Bil0000

Bil0000 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the current t3code/codex-turn-mapping tip (f180e95).

The base branch was force-pushed, which stranded this PR: GitHub compared it against a rewritten base, so it reported CONFLICTING with ~1400 changed files that were never part of this change. This PR's own commits were replanted onto the new base tip; every commit applied with no conflicts, and the diff against the new base is identical to the diff before the rebase. No behavior was changed as part of the rebase.

@shivamhwp
shivamhwp merged commit a9b49a7 into pingdotgg:t3code/codex-turn-mapping Sep 20, 2026
24 checks passed
juliusmarminge pushed a commit that referenced this pull request Sep 21, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 21, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 23, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 24, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
juliusmarminge pushed a commit that referenced this pull request Sep 25, 2026
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants