Skip to content

fix(mobile): preserve native send choices and keyboard - #12770

Merged
juliusmarminge merged 3 commits into
t3code/codex-turn-mappingfrom
fix-mobile-steer-submit
Sep 20, 2026
Merged

juliusmarminge merged 3 commits into
t3code/codex-turn-mappingfrom
fix-mobile-steer-submit

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

The mobile send button's long-press menu dropped the selected Queue/Steer action and hid the keyboard while the menu was open.

Forward the selected action through the thread screen. Reuse UIButton's built-in menu interaction for long press in the existing native menu patch, preserving its compact presentation and keyboard state. Return that interaction to the button when leaving long-press mode.

Validation: 37 focused composer and dispatch tests passed, mobile typecheck passed, and the iOS native client built successfully with the updated patch. An iOS 26.5 simulator pass on head 79b2ccf3a2d confirmed that opening and cancelling the native menu keeps the keyboard visible and preserves the draft without sending. Selecting Steer with Queue as the default delivered exactly one follow-up into the existing active Codex run. A normal tap after cancellation still sent using the default. Selecting Queue with Steer as the default created exactly one queued run while the current run stayed active. Android device verification was not run; the native patch changes only iOS.

Before, base a9b49a7df0a: the native long-press menu hides the keyboard.

Before: native long-press menu hides keyboard

After, head 79b2ccf3a2d: the native menu keeps the keyboard visible.

After: native long-press menu retains keyboard

Recording: open, cancel, reopen, and select Steer with the keyboard retained

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 79b2ccf · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge marked this pull request as ready for review September 20, 2026 19:13
Comment thread apps/mobile/src/features/threads/ComposerFollowUpMenu.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 79b2ccf

Macroscope's review found this PR approvable — This is a focused mobile bug fix that forwards explicitly selected Queue/Steer actions while preserving the existing default send path. The accompanying iOS patch only adjusts the existing native menu interaction to preserve keyboard behavior, with no schema, deployment, security, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Sep 20, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 20, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 20, 2026 20:09

Dismissing prior approval to re-evaluate 79b2ccf

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:S 10-29 changed lines (additions + deletions). labels Sep 20, 2026
@juliusmarminge juliusmarminge changed the title fix(mobile): honor queue and steer send choices fix(mobile): preserve native send choices and keyboard Sep 20, 2026
@juliusmarminge
juliusmarminge merged commit f43a9c1 into t3code/codex-turn-mapping Sep 20, 2026
23 checks passed
@juliusmarminge
juliusmarminge deleted the fix-mobile-steer-submit branch September 20, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant