Skip to content

feat(web): color handoff model names with their provider brand color - #12834

Merged
maria-rcks merged 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/handoff-brand-colors
Sep 21, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
maria-rcks:maria/handoff-brand-colors

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Context handoff model names inherited the divider's muted color. Match each model label to its provider logo color in light and dark themes and use medium weight, preserving the divider's failed-handoff tone.

Verified on Blacksmith: web typecheck, web lint, and all 66 MessagesTimeline tests passed. Before/after captures use the same real handoff in both themes. Failed-handoff appearance was not exercised because the snapshot contains only ready handoffs.

before, dark theme

after, dark theme

before, light theme

after, light theme

Codex → Claude handoff, where the color difference is visible (Claude's #d97757; OpenAI, Grok, Pi, Cursor and OpenCode logos are near-black / near-white, so their names match the foreground):

after, dark theme: gpt-6-astra to claude fable 5.1 handoff

after, light theme: gpt-6-astra to claude fable 5.1 handoff

Written by gpt-6-astra (Codex) in T3 Code; claude evidence and rebase by claude-fable-5-1 (Claude Code) in T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 21, 2026
Comment thread apps/web/src/components/chat/V2LifecycleRow.tsx
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 61a3501 to 619623f Compare September 21, 2026 03:05
@macroscopeapp

macroscopeapp Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a small, self-contained presentation change that only colors existing handoff labels and does not alter handoff execution, schemas, or infrastructure. A Medium-severity finding remains about failed handoffs losing their destructive text tone when provider colors are applied.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

No code changes detected at ec85294. Prior analysis still applies.

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks force-pushed the maria/handoff-brand-colors branch from d5cea79 to 3d8be6a Compare September 21, 2026 03:10
@maria-rcks
maria-rcks force-pushed the maria/handoff-brand-colors branch from 3d8be6a to ec85294 Compare September 21, 2026 03:23
@maria-rcks
maria-rcks merged commit df54e61 into pingdotgg:t3code/codex-turn-mapping Sep 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant