fix(server): a Claude command you stop shows as interrupted

[SunkenInTime]

Replaces #14708. GitHub closed it when the V2 branch it targeted was merged into main (#2829) and deleted. Same change, now based on main.

Problem

When you stop a Claude turn while a command is running, the command is saved as failed. The run and the provider turn are correctly interrupted. Codex, Pi and (since #13806) Cursor record a stopped command as interrupted.

What it looks like

The visible difference is small: the stopped command's terminal icon is red ("failed") before this change and grey ("interrupted") after. That matches how Codex, Cursor and Pi show a stopped command. Agents reading the thread with t3_thread_read see the same status, so before this change they were told the command failed.

Full screenshots and the Stop interaction

Same prompt on a dev build of the V2 branch just before it merged (the status line this changes is the same on main), using Claude Haiku 4.5 on Windows. The thread runs a 60-second node command through the Bash tool, and I press Stop about 25 s in. For the "before" run I swapped in ClaudeAdapterV2.ts from the current base, which is slightly newer than this PR's base. The only change that matters here is the finalizeActiveTurn status.

Before	After

The projection rows for those two threads have command_execution with status failed before and interrupted after.

Evidence

Seen on my V2 install (Windows 11, T3 Code Alpha 0.0.43-preview.20260925.2234). Two Claude runs I stopped mid-command, cb27a173… run 1 and 25318ad4… run 1, show their in-flight tool items (toolu_01Dsw5XiGCxQMvQetAYPoZJJ, toolu_015FxSiZtU3XTHWstWE8Tr56) as failed. A Codex run stopped the same way on the same day (bbd82247…, exec-ca9958dc) shows interrupted.

The recorded turn_interrupt_mid_tool Claude fixture asserted this behavior: commandItem.status === "failed".

Change

finalizeActiveTurn in ClaudeAdapterV2 closes every tool that never got a result. It always closed them as failed. Now an interrupted or cancelled turn closes them with its own status. Tools on a turn that ends on its own stay failed, as before.

Scope and approval

Very small, focused fix for an obvious status bug: one line in the Claude adapter plus the three fixture assertions that encoded the old status, mirroring #13806 for Cursor. Julius asked for last small V2 bug fixes before the nightly merge.

Verification

• turn_interrupt_mid_tool/claude_output.ts now asserts commandItem.status === "interrupted". vp test run src/orchestration-v2/testkit/OrchestratorReplayFixtures.integration.test.ts -t turn_interrupt_mid_tool:
  • Before the fix: expected 'failed' to equal 'interrupted' (1 failed, 3 passed).
  • After: 4 passed.
• claude_background_task_interrupt/output.ts and turn_interrupt_restart/claude_output.ts asserted the same old failed status for a stopped command and now expect interrupted. The full OrchestratorReplayFixtures.integration.test.ts on main: 123 passed, 1 failed. The failure is stop_background_work_after_release/acpRegistry, an ACP fixture this doesn't touch, and it fails identically on main without this change.
• vp test run src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts on main: 125 passed, 1 failed. The failure, "names an expired Claude login instead of the terminal API error" (expected 'Claude could not authenticate…' to include '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/synthetic/project'), fails identically on the base without this change.
• vp exec tsc --noEmit -p . in apps/server on main: no error TS. vp lint on the touched files reports only the existing unused layer warning at the end of ClaudeAdapterV2.ts.
• Live Claude stop before and after the fix, shown above.

Diagnosed and implemented by Claude Opus 5.5 in Claude Code, running inside T3 Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at c1777e1

Macroscope's review found this PR approvable — This is a localized Claude adapter bug fix that corrects the status of open commands when a turn is stopped or cancelled, while preserving normal completion behavior. The accompanying fixture updates cover the affected interruption scenarios, with no schema, deployment, or static-analysis changes.

Notes:

• Diff unchanged. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate c1777e1

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

docs/internals/effect-services.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 37ed18e3-d665-4745-b3a7-e9815d1cc5e7

📥 Commits

Reviewing files that changed from the base of the PR and between 8bc40b4 and c1777e1.

📒 Files selected for processing (4)

• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts
• apps/server/src/orchestration-v2/testkit/fixtures/claude_background_task_interrupt/output.ts
• apps/server/src/orchestration-v2/testkit/fixtures/turn_interrupt_mid_tool/claude_output.ts
• apps/server/src/orchestration-v2/testkit/fixtures/turn_interrupt_restart/claude_output.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

Claude tool-call finalization now preserves the turn’s terminal status for open calls when the turn does not complete. The interruption fixtures expect foreground command execution items to be interrupted.

Changes

Claude tool-call status handling

Layer / File(s)	Summary
Propagate turn status to open tool calls apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts, apps/server/src/orchestration-v2/testkit/fixtures/claude_background_task_interrupt/output.ts, apps/server/src/orchestration-v2/testkit/fixtures/turn_interrupt_mid_tool/claude_output.ts, apps/server/src/orchestration-v2/testkit/fixtures/turn_interrupt_restart/claude_output.ts	The adapter accepts interrupted and cancelled artifact statuses. It marks open calls as failed for completed turns and otherwise uses the turn’s terminal status. Fixtures expect interrupted command execution items; the background launch remains completed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to c1777

The change correctly preserves interrupted and cancelled command outcomes without affecting completed turns.

Architecture Summary

Architecture risk: 🔵 Low · up to c1777

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 4 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts: The local tool-call artifact builder’s status type now also permits interrupted and cancelled.
• observed — Modified behavior in apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts: Finalization previously marked every still-open tool call as failed. It now marks them failed for a completed turn and uses the turn’s terminal status when the turn ended with another status.
• observed — Modified behavior in apps/server/src/orchestration-v2/testkit/fixtures/claude_background_task_interrupt/output.ts: The assertion now expects the foreground command to have status interrupted rather than failed, and updates its description accordingly; the background launch remains expected to be completed.
• observed — Modified behavior in apps/server/src/orchestration-v2/testkit/fixtures/turn_interrupt_mid_tool/claude_output.ts: The fixture assertion now expects the command execution item to be interrupted rather than failed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main fix: stopped Claude commands now show an interrupted status.
Description check	✅ Passed	The description includes the problem, change, scope justification, verification results, known base-branch failures, and agent attribution. It satisfies the required template.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

_{Comment @coderabbitai help to get the list of available commands.}