fix(build): validate Linux node-pty prebuilds in Windows artifacts

[Yash-Singh1]

What Changed

Windows artifact validation now accepts a node-pty Linux prebuild for the target architecture as an alternative to the source build. Tests cover valid x64 and arm64 prebuilds and reject a prebuild for the wrong architecture.

Why

The WSL runtime can include a Linux node-pty prebuild instead of build/Release/pty.node. Validation rejected those artifacts, which could fail Windows release builds.

UI Changes

Not applicable.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Summary by CodeRabbit

• Bug Fixes
  • Windows WSL runtime validation now accepts either a Linux node-pty source-build binary or a prebuilt binary matching the target architecture. Archives missing both options are reported as invalid.

[macroscopeapp]

Approvability

Verdict: Approved at 3fb7165

Macroscope's review found this PR approvable — This is a small, focused build-time validation fix that preserves existing artifact behavior while accepting the runtime's target-specific node-pty prebuild layout. Its accompanying tests cover both supported architectures and rejection of mismatches, with no production request-path or product-default changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	+1 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.3 KiB	56.3 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+10 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	+7 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	+3 B (+0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: d110f98 · PR result: 3fb7165 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 114.0 KiB
• Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 226230c2-95d7-4f59-8b20-c2f44b84df2d

📥 Commits

Reviewing files that changed from the base of the PR and between d110f98 and 3fb7165.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• scripts/build-desktop-artifact.test.ts
• scripts/build-desktop-artifact.ts

Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

---

📝 Walkthrough

Walkthrough

WSL archive validation now accepts either a source-build node-pty binary or a Linux prebuild matching the target architecture. Tests cover matching and mismatched prebuild architectures and missing binaries.

Changes

WSL node-pty validation

Layer / File(s)	Summary
Validate node-pty binaries in WSL archives scripts/build-desktop-artifact.ts, scripts/build-desktop-artifact.test.ts	Validation accepts the Release binary or the target architecture’s Linux prebuild. Tests cover matching and mismatched architectures and report both candidate paths when neither binary is present.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 3fb71

The Windows artifact validation change is ready to merge after normal checks; no unresolved issue is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: validating Linux node-pty prebuilds in Windows artifacts.
Description check	✅ Passed	The description explains what changed and why, covers the test scope, and identifies that there are no UI changes. The UI section remains instead of being deleted, and the screenshot and video checkli…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}