fix(server): load Cursor keyring with createRequire - #13678
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This focused server fix changes how Cursor access tokens are loaded from the macOS Keychain in packaged builds. Because it affects authentication-sensitive credential handling, the runtime change warrants human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe Cursor credential store now loads ChangesCursor credential loading
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The packaged server can resolve the Cursor keyring dependency, and keyring read failures degrade gracefully. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
## What's Changed * feat(usage): read cursor, opencode, and antigravity history by @maria-rcks in pingdotgg/t3code#10409 * fix(sqlite): retry failed statement preparations by @yashranaway in pingdotgg/t3code#10584 * fix(mobile): scale Android controls with appearance text size by @none23 in pingdotgg/t3code#13356 * fix(web): return focus to the composer after saving a citation note by @mackinleysmith in pingdotgg/t3code#13450 * feat(observability): honor the standard OTLP endpoint, headers, and protocol variables by @yordis in pingdotgg/t3code#13492 * fix(terminal): settling a thread closes its idle shells by @t3dotgg in pingdotgg/t3code#13673 * fix(server): load Cursor keyring with createRequire by @Yash-Singh1 in pingdotgg/t3code#13678 * perf(server): avoid rereading unchanged files in review previews by @shivamhwp in pingdotgg/t3code#13395 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260925.2251...v0.0.43-nightly.20260925.2269 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260925.2269
What Changed
Load
@napi-rs/keyringwithcreateRequirewhen reading Cursor credentials.Why
The package's dynamic import failed in release builds. Resolving it with the server module's
createRequirekeeps Cursor keyring access working in packaged builds.UI Changes
Not applicable.
Checklist
Summary by CodeRabbit