fix(server): bump node-pty to 1.2.0-beta.15 for linux-arm64 prebuild - #13748
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped dependency and lockfile update that fixes the server's Linux ARM64 native prebuild availability without changing application source, product defaults, or static-analysis settings. Its runtime impact is limited to replacing the existing Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe server package updates its declared ChangesServer dependency update
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established; the update is mergeable after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ntime node-pty 1.2.0-beta.15 (pingdotgg#13748) ships its Linux binary under prebuilds/linux-<arch>/pty.node instead of build/Release/pty.node, so the Windows packaging check rejected every embedded Linux CLI archive and the Windows builds failed. The check now accepts either location, the same ones the WSL startup probe already looks in.
## What's Changed * feat(observability): write a server heap snapshot on SIGUSR2 by @t3dotgg in pingdotgg/t3code#13694 * perf(server): shutdown no longer rewrites every stopped session row by @t3dotgg in pingdotgg/t3code#13688 * perf(server): build the thread list snapshot without decoding it twice by @t3dotgg in pingdotgg/t3code#13693 * fix(client): slow servers finish loading the thread list instead of loading it twice by @t3dotgg in pingdotgg/t3code#13683 * perf(web): hidden terminal drawers no longer keep full thread history in memory by @t3dotgg in pingdotgg/t3code#13686 * perf(server): per-thread settlement and PR checks no longer rebuild the whole thread list by @t3dotgg in pingdotgg/t3code#13691 * fix(mobile): running threads open at the latest message by @AKolenda in pingdotgg/t3code#13530 * feat(observability): record event loop stalls in the server trace by @t3dotgg in pingdotgg/t3code#13697 * perf(server): stop re-running git for every project each minute by @t3dotgg in pingdotgg/t3code#13689 * fix(usage): hide the Cursor keychain prompt when Cursor isn't set up by @Gigioxx in pingdotgg/t3code#13714 * feat(web): add chat width setting for wide screens by @otavio in pingdotgg/t3code#11594 * fix(opencode): accept v2 serve ready line when spawning server by @shirishpothi in pingdotgg/t3code#13651 * fix(editors): stop treating the agy CLI as the Antigravity IDE by @ishaanko in pingdotgg/t3code#7079 * fix(web): make the empty workspace draggable on desktop by @otavio in pingdotgg/t3code#13713 * fix(server): installed editors no longer vanish when discovery is slow by @bfowler in pingdotgg/t3code#13669 * fix(git): exclude SSH ports from provider URLs by @GaMeRaM in pingdotgg/t3code#12537 * fix(web): Mod+B bolds on non-Latin layouts by @ValeraZSD in pingdotgg/t3code#13409 * fix(server): prune expired replay-protection files from the secrets directory by @t3dotgg in pingdotgg/t3code#13695 * fix(web): terminal links drop a trailing colon by @ValeraZSD in pingdotgg/t3code#13408 * fix(server): bump node-pty to 1.2.0-beta.15 for linux-arm64 prebuild by @Ephraim-9 in pingdotgg/t3code#13748 * Show a focus ring on sidebar thread and draft rows by @ryanilano in pingdotgg/t3code#13344 * fix(mobile): keep composer within folded screen after resume by @PixPMusic in pingdotgg/t3code#13310 * fix(server): let OpenCode generate session titles by @macodev00 in pingdotgg/t3code#13368 * fix(server): let Antigravity inspect unsupported files by path by @Bil0000 in pingdotgg/t3code#13339 * fix(mobile): link URLs with ports and single-label hosts by @Yash-Singh1 in pingdotgg/t3code#13795 * feat(web): add keyboard navigation for usage by @tris203 in pingdotgg/t3code#10158 * perf(observability): stop writing empty spans on spawns, projected events, and idle polls by @t3dotgg in pingdotgg/t3code#13756 * perf(server): opening Diagnostics no longer loads the whole trace ring into memory by @t3dotgg in pingdotgg/t3code#13763 * perf(clients): sort projects and settled threads without re-parsing dates per comparison by @t3dotgg in pingdotgg/t3code#13759 * fix(observability): the renderer trace proxy stops tracing itself by @t3dotgg in pingdotgg/t3code#13761 * perf(server): background sweeps only read threads that can still settle by @t3dotgg in pingdotgg/t3code#13765 * perf(clients): saving the thread list cache no longer freezes the UI by @t3dotgg in pingdotgg/t3code#13767 * perf(server): cut idle wakeups from the Connect relay and session reaper by @t3dotgg in pingdotgg/t3code#13774 * fix(mobile): keep trailing underscores and tildes in autolinked URLs by @Yash-Singh1 in pingdotgg/t3code#13807 * fix(web): queued messages send while their thread is not open by @t3dotgg in pingdotgg/t3code#13764 * fix(server): background git status fetches no longer fill the disk with failed repacks by @t3dotgg in pingdotgg/t3code#13812 * fix(mobile): thread list shows the pull request icon instead of # by @flamboh in pingdotgg/t3code#13742 * fix(accessibility): correct control announcements and sidebar traversal by @blinding-pixels in pingdotgg/t3code#13491 * fix(usage): tolerate newer provider variants by @tris203 in pingdotgg/t3code#10076 * fix(usage): omit Cursor warning when no login is saved by @tris203 in pingdotgg/t3code#13820 * fix(usage): identify client version mismatches by @tris203 in pingdotgg/t3code#8208 * fix(web): stop mistaking offline servers for updates by @tris203 in pingdotgg/t3code#13083 * test(usage): assert contract mismatch details by @Yash-Singh1 in pingdotgg/t3code#13861 * fix(build): validate Linux node-pty prebuilds in Windows artifacts by @Yash-Singh1 in pingdotgg/t3code#13867 ## New Contributors * @otavio made their first contribution in pingdotgg/t3code#11594 * @shirishpothi made their first contribution in pingdotgg/t3code#13651 * @bfowler made their first contribution in pingdotgg/t3code#13669 * @GaMeRaM made their first contribution in pingdotgg/t3code#12537 * @ValeraZSD made their first contribution in pingdotgg/t3code#13409 * @Ephraim-9 made their first contribution in pingdotgg/t3code#13748 * @ryanilano made their first contribution in pingdotgg/t3code#13344 * @macodev00 made their first contribution in pingdotgg/t3code#13368 * @blinding-pixels made their first contribution in pingdotgg/t3code#13491 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260926.2282...v0.0.43-nightly.20260926.2318 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260926.2318
node-pty 1.2.0-beta.15 (upstream pingdotgg#13748) reports pid 0 at spawn on Windows until ConPTY's data pipe connects. The terminal manager reads the pid right after spawn, so every snapshot failed the contract's pid > 0 check and the terminal panel never attached. 1.1.0 knows the pid synchronously. Drop the pin when upstream fixes the Windows pid. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
What Changed
Bumps
apps/server'snode-ptyfrom^1.1.0to^1.2.0-beta.15(+ lockfile). No code changes.Why
Fixes #11556.
node-pty@1.1.0publishes no Linux prebuilds, so on linux-arm64 the released CLI runtime ships an emptynode_modules/node-pty/prebuilds/and the server exits at startup:1.2.0-beta.15shipsprebuilds/linux-arm64/pty.node(andlinux-x64).scripts/build-cli-archive.tsalready keeps the archive's ownprebuilds/<platform>-<arch>directory and strips the rest, so no packaging change is needed.^1.1.0can never resolve to the prerelease on its own, hence the explicit bump.This is the same change as #12406, which its author closed without merging.
Verification (real ARM64 hardware, not emulated)
Oracle Cloud Ampere A1 (aarch64), Ubuntu 20.04:
t3@0.0.42viainstall.sh+t3 service install: service crash-loops with the error above.node-ptywith the stock1.2.0-beta.15tarball (nobuild/directory, onlyprebuilds/linux-arm64kept, matching what the archive script stages): service reachesListening on http://127.0.0.1:3773and stays active; anode-ptyspawn ofsh -c 'uname -m; stty size'withcols: 100, rows: 30returnsaarch64/30 100, exit 0.pnpm install --frozen-lockfile, no source build of node-pty present):vp test run src/terminalinapps/server: 3 files, 94 tests passed;tsc --noEmit: clean.Not exercised: macOS, Windows, linux-x64.
Checklist
Summary by CodeRabbit