fix(server): ship node-pty linux arm64 prebuilds - #12406
maria-rcks wants to merge 2 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, isolated server dependency and lockfile update that supplies node-pty's Linux arm64 prebuild while leaving application source logic and product defaults unchanged. Its impact is limited to dependency resolution and the targeted existing terminal path, with all modified files confined to ignored repository paths. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe server updates Changesnode-pty update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is evident from the dependency update. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bumps node-pty to
^1.2.0-beta.15, which includes the linux arm64 prebuild missing from 1.1.0, and updates the lockfile. fixes #11556 without requiring a c++ toolchain or changing release ci.reproduced the 1.1.0 missing
prebuilds/linux-arm64/pty.nodeerror in a qemu-emulated linux arm64 node 24 slim container.verified on blacksmith: 6 existing adapter tests, server typecheck, server bundle, and manifest formatting. in a qemu-emulated linux arm64 node 24 slim container, installed with scripts disabled and no compiled
build/Release/pty.node, the shipped prebuild spawneduname -m(aarch64); the built server reachedListening on, and authenticated websocket terminal open/write/resize/close passed (stty size:30 100). arm64 hardware, macos, and windows were not exercised.written by
gpt-6-astrausing codex.CI results at e2e9f47. The ARM64 QEMU terminal verification is described above; this screenshot shows the GitHub check results.
Summary by CodeRabbit