Skip to content

fix(server): ship node-pty linux arm64 prebuilds - #12406

Closed
maria-rcks wants to merge 2 commits into
pingdotgg:mainfrom
maria-rcks:maria/easy-11556-pty-arm64
Closed

maria-rcks wants to merge 2 commits into
pingdotgg:mainfrom
maria-rcks:maria/easy-11556-pty-arm64

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

bumps node-pty to ^1.2.0-beta.15, which includes the linux arm64 prebuild missing from 1.1.0, and updates the lockfile. fixes #11556 without requiring a c++ toolchain or changing release ci.

reproduced the 1.1.0 missing prebuilds/linux-arm64/pty.node error in a qemu-emulated linux arm64 node 24 slim container.

verified on blacksmith: 6 existing adapter tests, server typecheck, server bundle, and manifest formatting. in a qemu-emulated linux arm64 node 24 slim container, installed with scripts disabled and no compiled build/Release/pty.node, the shipped prebuild spawned uname -m (aarch64); the built server reached Listening on, and authenticated websocket terminal open/write/resize/close passed (stty size: 30 100). arm64 hardware, macos, and windows were not exercised.

written by gpt-6-astra using codex.

CI results at e2e9f47. The ARM64 QEMU terminal verification is described above; this screenshot shows the GitHub check results.

Linux ARM64 prebuild PR passing CI

Summary by CodeRabbit

  • Chores
    • Updated the terminal functionality dependency to a newer version.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 18, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c19b4cc

Macroscope's review found this PR approvable — This is a small, isolated server dependency and lockfile update that supplies node-pty's Linux arm64 prebuild while leaving application source logic and product defaults unchanged. Its impact is limited to dependency resolution and the targeted existing terminal path, with all modified files confined to ignored repository paths.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a961d45b-0363-415f-b58a-37f16ee0336e

📥 Commits

Reviewing files that changed from the base of the PR and between 7a2cce8 and c19b4cc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • apps/server/package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The server updates node-pty from ^1.1.0 to ^1.2.0-beta.15 in its package dependencies.

Changes

node-pty update

Layer / File(s) Summary
Update node-pty version
apps/server/package.json
The server dependency constraint changes from ^1.1.0 to ^1.2.0-beta.15.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to c19b4

No actionable merge-blocking risk is evident from the dependency update.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #11556 requires Linux arm64 startup without an additional C++ toolchain and requires a working node-pty binary for terminal operations. The PR updates node-pty to ^1.2.0-beta.15, which the PR su…
Out of Scope Changes check ✅ Passed The reported changes are limited to the node-pty dependency update and its lockfile update. These changes directly implement issue #11556. The reported adapter, server, manifest, and Linux arm64 verif…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Title check ✅ Passed The title clearly identifies the server fix and the Linux arm64 node-pty prebuild change.
Description check ✅ Passed The description explains the change, the problem, the solution, verification steps, and untested platforms. It does not use the template headings or checklist, but it provides the required information…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: t3 server fails to start on linux-arm64 — node-pty has no prebuild and no working source-build fallback

1 participant