fix(usage): omit Cursor warning when no login is saved

[tris203]

The Usage page showed “Cursor account history needs a Cursor CLI login saved on this server” even when no Cursor login existed. The account reader already distinguishes an absent login from an error, but UsageService replaced the absent-login result with a setup warning.

Skip the account source when the reader reports a missing login without an error. Web, desktop, and mobile consume the same summary, so they all stop showing the warning. Existing credential errors, account history, and the macOS Keychain opt-in flow keep their current behavior.

Related: #13714 fixed the macOS Keychain prompt; this fixes the separate saved-login warning. #7645 addresses the broader behavior of disabled providers and is not superseded by this change.

Validation: 39 focused service/reader tests passed, including absent file logins on Linux, Windows, and macOS, plus unreadable saved credentials. The new absent-login regression fails on the original code. Server typecheck, targeted lint, and formatting passed.

Verified Cost → 7 days in a headless Chrome browser against the isolated dev server with a real database snapshot and no saved Cursor login. The original code shows the warning; the fixed code loads the usage totals without it. Totals vary slightly because the underlying provider history remains active during capture.

Before	After

Model: GPT-6-Astra. Harness: Codex in T3 Code.

Summary by CodeRabbit

• Bug Fixes
  • Cursor usage is no longer shown as a source when saved login details are missing. Unreadable saved login details still appear with an error message.
  • OpenCode usage results no longer include a Cursor source when Cursor account usage is unavailable.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7d4b7b71-507f-4fa4-ae92-3376e0ebd5c6

📥 Commits

Reviewing files that changed from the base of the PR and between 95030dc and 8dc0cf8.

📒 Files selected for processing (2)

• apps/server/src/usage/UsageService.test.ts
• apps/server/src/usage/UsageService.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

When Cursor account history is missing without an error, usage collection no longer adds a Cursor source. Tests cover missing saved logins across three operating systems and verify that unreadable credentials still produce an error source.

Changes

Cursor usage source handling

Layer / File(s)	Summary
Missing account history handling and coverage apps/server/src/usage/UsageService.ts, apps/server/src/usage/UsageService.test.ts	collectDirs omits Cursor when account history is missing without an error. Tests cover Linux, Windows, macOS, unreadable credentials, and OpenCode history expectations.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to 8dc0c

No merge-blocking issue is identified; the change appears ready to merge after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 8dc0c

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in apps/server/src/usage/UsageService.test.ts: Adds tests asserting that, with file credentials selected but no saved login, Cursor is omitted from sources on Linux, Windows, and macOS; when auth.json exists but contains invalid JSON, the Cursor source reports “Cursor credentials could not be read.”
• observed — Modified behavior in apps/server/src/usage/UsageService.test.ts: In the OpenCode history test, replaces the expectation of a Cursor source with missing status with an assertion that no Cursor source is present.
• observed — Modified behavior in apps/server/src/usage/UsageService.test.ts: Removes the assertion that the missing Cursor source’s message requests a Cursor CLI login.
• observed — Modified behavior in apps/server/src/usage/UsageService.ts: When Cursor account history is missing and the lookup has no error, collectDirs now returns the sources collected so far instead of adding a Cursor source marked as missing or requiring setup.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: omitting the Cursor warning when no login is saved.
Description check	✅ Passed	The description explains what changed, why it changed, validation results, scope, preserved behavior, and UI impact with before-and-after screenshots. It does not include the template's explicit Check…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 8dc0cf8

Macroscope's review found this PR approvable — This is a narrow, well-tested usage fix that suppresses only the Cursor warning for an absent login while preserving errors for unreadable saved credentials. Existing usage aggregation and other provider paths remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}