fix(relay): export tunnel cleanup counters to Axiom - #13528
Conversation
The cron job ran without the Axiom tracer, and the reaper only logged its counters to the Worker console. The dry-run rollout step has no durable place to read them. Provide the relay tracer to the cron job and record each sweep's counters as attributes on its span. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR adds cleanup counters to an existing span and enables Axiom tracing for the production five-minute cron, including external export and flushing before the run ends. Because this activates non-trivial telemetry work on an existing production path, human review is warranted. You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe relay cron task provides relay tracing. The managed endpoint sweep adds its mode and result counters to the current span. A dry-run test checks the span attributes and confirms that no tunnels are deleted. ChangesManaged endpoint sweep tracing
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The scheduled sweep now runs with relay tracing, and successful cleanup counters are recorded on its span. The supplied source evidence shows the tracing scope and counter path are wired together; no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Dismissing prior approval to re-evaluate 015a47d
## What's Changed * fix(web): sidebar Back always returns to the main app by @t3dotgg in pingdotgg/t3code#13516 * fix(desktop): desktop updates reconnect in seconds, not minutes by @t3dotgg in pingdotgg/t3code#12006 * fix(connect): remove tunnels after hosts go offline by @t3dotgg in pingdotgg/t3code#9386 * fix(mobile): capture a lit 6.9-inch lock screen in the agent-activity showcase by @juliusmarminge in pingdotgg/t3code#13522 * feat(grok): offer one-click updates through `grok update` by @juliusmarminge in pingdotgg/t3code#13523 * fix(mobile): make Android subscription usage widgets scrollable by @tris203 in pingdotgg/t3code#13474 * fix(web): keep sidebar terminal pulses in sync by @t3dotgg in pingdotgg/t3code#12962 * feat(web): add iPhone Duo 3D controls by @juliusmarminge in pingdotgg/t3code#12813 * fix(relay): export tunnel cleanup counters to Axiom by @juliusmarminge in pingdotgg/t3code#13528 * fix(server): Grok accounts with no usage yet no longer vanish from Limits by @jakeleventhal in pingdotgg/t3code#12799 * fix(server): report the Grok account email so usage limits merge across environments by @jakeleventhal in pingdotgg/t3code#12588 * feat(web): add usage page keybinding by @jakeleventhal in pingdotgg/t3code#9434 * chore: clear Effect language service suggestions by @juliusmarminge in pingdotgg/t3code#13536 * ci(relay): add a forced manual relay deploy by @juliusmarminge in pingdotgg/t3code#13550 * fix(web): selected text stays visible on a revealed file line by @t3dotgg in pingdotgg/t3code#13548 * fix(web): collapsed composer bar stops flipping its labels while you scroll by @t3dotgg in pingdotgg/t3code#13555 * fix(clients): sync status no longer flickers when opening running threads by @t3dotgg in pingdotgg/t3code#13551 * fix(server): newer Codex models get T3 Code's instructions again by @t3dotgg in pingdotgg/t3code#13547 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260924.2223...v0.0.43-nightly.20260925.2237 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260925.2237
The relay's five-minute cron ran without the Axiom tracer, and the tunnel reaper only logged its counters to the Worker console. The
dry-runstep of the managed tunnel cleanup rollout (#9386) exists so we can read those counters over several sweeps, and right now they only show up in live Worker logs.The cron job now gets the same Axiom tracer as HTTP requests, and each sweep records its result on the
relay.managed_endpoint_reaper.sweepspan asrelay.managed_endpoint_reaper.*attributes (mode,scanned,wouldDelete,skippedLegacy,skippedOrphan,deleted,failed,truncated,listRequests,attempted). The exporter's scope finalizer flushes spans before the scheduled run ends.With cleanup
off, the sweep returns immediately, so each run adds one near-empty cron span and one sweep span to the traces dataset.Verification: relay typecheck, scoped lint, and format pass.
ManagedEndpointReaper.test.tspasses (18 tests), including a new test that records the span and checks the dry-run counters. That test fails when the annotation is removed.🤖 Generated with Claude Code
Summary by CodeRabbit