Skip to content

fix(web): sidebar Back always returns to the main app - #13516

Merged
t3dotgg merged 2 commits into
mainfrom
t3code/fix-sidebar-back-to-app
Sep 24, 2026
Merged

t3dotgg merged 2 commits into
mainfrom
t3code/fix-sidebar-back-to-app

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Back in the sidebar on Settings, Usage, and Pull Requests used browser history. After a few settings pages, Back just stepped to the previous settings page, and it was hard to find the way out to the main app.

Now the app remembers the last main app page (thread, draft, or thread list) and Back goes there directly. If the app was opened straight into settings, Back goes to the thread list. Escape in settings had the same history behavior, so it now does the same thing.

Browser back/forward and the navigation keybindings still walk history as before.

Made with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • The Back action in sidebar utility pages now returns to the most recently visited main app page, instead of relying on browser history or defaulting to the home page.
    • Pressing Escape in Settings now follows the same behavior, returning to the most recently visited main app page.

Back on Settings, Usage, and Pull Requests used browser history, so it
stepped through earlier settings pages instead of leaving. It now goes to
the last thread or main app page you were on. Escape in settings does the
same.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 24, 2026
Comment thread apps/web/src/components/sidebar/mainAppLocation.ts
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB +8 B (+0.1%) 15.1 KiB ✅
Codex Thread snapshot wire 7.1 KiB 7.1 KiB −1 B (−0.0%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.5 KiB 6.5 KiB +9 B (+0.1%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 56.3 KiB 56.3 KiB 0 B (0.0%) 66.4 KiB ✅
Codex Live turn messages 10 10 0 (0.0%) 21 ✅
Claude Total thread wire 13.5 KiB 13.5 KiB −20 B (−0.1%) 15.1 KiB ✅
Claude Thread snapshot wire 7.1 KiB 7.1 KiB −4 B (−0.1%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.4 KiB 6.4 KiB −16 B (−0.2%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: 720490a · PR result: 5fa99d8 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 114.0 KiB
  • Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5fa99d8

Macroscope's review found this PR approvable — This is a narrowly scoped navigation bug fix that replaces history-based utility-page Back behavior with a remembered main-app destination. Its runtime impact is limited to the sidebar and Settings Escape navigation, with no schema, infrastructure, or sensitive-area changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: ff6ccf9e-b25c-40d8-8fcc-101086514b9b

📥 Commits

Reviewing files that changed from the base of the PR and between 720490a and 5fa99d8.

📒 Files selected for processing (4)
  • apps/web/src/components/AppSidebarLayout.tsx
  • apps/web/src/components/sidebar/SidebarChrome.tsx
  • apps/web/src/components/sidebar/mainAppLocation.ts
  • apps/web/src/routes/settings.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

A shared tracker records the latest URL outside utility pages. The sidebar Back action and settings Escape action navigate to that URL, or to / if no URL has been recorded.

Changes

Utility-page return navigation

Layer / File(s) Summary
Record the main-app location
apps/web/src/components/sidebar/mainAppLocation.ts, apps/web/src/components/AppSidebarLayout.tsx
A utility-page predicate identifies settings, project, usage, and pull-request paths. A tracker records the latest non-utility URL and is rendered within SidebarProvider.
Use the recorded location for return actions
apps/web/src/components/sidebar/SidebarChrome.tsx, apps/web/src/routes/settings.tsx
The sidebar Back action and settings Escape action use the shared navigation hook instead of browser-history fallback behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 5fa99

No confirmed issue blocks the utility-page return navigation change; it is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly explains the problem and the implementation, but it does not use the required template sections, include the Checklist, or provide the required video for this interaction chang… Rewrite the description using the What Changed, Why, UI Changes, and Checklist sections. Add a short video showing the sidebar Back and settings Escape behavior, and complete the checklist items.
Docstring Coverage ⚠️ Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: sidebar Back now returns to the main app.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the problem and the implementation, but it does not use the required template sections, include the Checklist, or provide the required video for this interaction change.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@t3dotgg
t3dotgg merged commit 9a91177 into main Sep 24, 2026
25 checks passed
@t3dotgg
t3dotgg deleted the t3code/fix-sidebar-back-to-app branch September 24, 2026 23:38
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 25, 2026
## What's Changed
* fix(web): sidebar Back always returns to the main app by @t3dotgg in pingdotgg/t3code#13516
* fix(desktop): desktop updates reconnect in seconds, not minutes by @t3dotgg in pingdotgg/t3code#12006
* fix(connect): remove tunnels after hosts go offline by @t3dotgg in pingdotgg/t3code#9386
* fix(mobile): capture a lit 6.9-inch lock screen in the agent-activity showcase by @juliusmarminge in pingdotgg/t3code#13522
* feat(grok): offer one-click updates through `grok update` by @juliusmarminge in pingdotgg/t3code#13523
* fix(mobile): make Android subscription usage widgets scrollable by @tris203 in pingdotgg/t3code#13474
* fix(web): keep sidebar terminal pulses in sync by @t3dotgg in pingdotgg/t3code#12962
* feat(web): add iPhone Duo 3D controls by @juliusmarminge in pingdotgg/t3code#12813
* fix(relay): export tunnel cleanup counters to Axiom by @juliusmarminge in pingdotgg/t3code#13528
* fix(server): Grok accounts with no usage yet no longer vanish from Limits by @jakeleventhal in pingdotgg/t3code#12799
* fix(server): report the Grok account email so usage limits merge across environments by @jakeleventhal in pingdotgg/t3code#12588
* feat(web): add usage page keybinding by @jakeleventhal in pingdotgg/t3code#9434
* chore: clear Effect language service suggestions by @juliusmarminge in pingdotgg/t3code#13536
* ci(relay): add a forced manual relay deploy by @juliusmarminge in pingdotgg/t3code#13550
* fix(web): selected text stays visible on a revealed file line by @t3dotgg in pingdotgg/t3code#13548
* fix(web): collapsed composer bar stops flipping its labels while you scroll by @t3dotgg in pingdotgg/t3code#13555
* fix(clients): sync status no longer flickers when opening running threads by @t3dotgg in pingdotgg/t3code#13551
* fix(server): newer Codex models get T3 Code's instructions again by @t3dotgg in pingdotgg/t3code#13547


**Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260924.2223...v0.0.43-nightly.20260925.2237

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260925.2237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant