Skip to content

feat(journal-select): add the method-journal-select skill - #151

Merged
sajor2000 merged 1 commit into
mainfrom
feat/journal-selection-skill
Oct 21, 2026
Merged

sajor2000 merged 1 commit into
mainfrom
feat/journal-selection-skill

Conversation

@sajor2000

Copy link
Copy Markdown
Owner

What

Adds the method-journal-select skill — journal selection for the submission lane (MedSci audit gap #5; competitor parity with find-journal). The skill was built and validated on this branch against the repo's skill-authoring and eval conventions; rebased onto current main and re-validated.

Closes out the journal-selection half of #143's parent gap; the ICMJE COI decision remains separately tracked in #143.

Validation

  • bun test — 1749 pass / 11 skip / 0 fail
  • bun run release:validate — in sync (55 agents, 68 skills, 0 MCP servers)

Close the journal-selection half of audit gap #5 with a new skill that
matches a finished manuscript or abstract to candidate journals:

- builds a 5-8 candidate pool from each journal's own aims-and-scope page
  read via web tools, never from memory or a third-party summary;
- gathers scope-fit evidence by searching PubMed restricted to each
  candidate journal for similar recent studies (count and recency);
- runs a legitimacy screen verifying each candidate's indexing claims
  against the NLM Catalog or DOAJ, flagging unverifiable claims, copycat
  names, and APC-only venues instead of silently dropping or accepting
  them;
- applies the author's must-haves (indexing, access policy and fees,
  review speed) as hard filters, ranks with every cell sourced or marked
  unknown, and recommends a target plus two backups, leaving the choice
  to the author.

Sourcing rules are the core discipline: no impact factor, acceptance
rate, turnaround, or APC from memory; every metric carries a source URL
and date or is marked unknown. Egress mirrors the other research skills:
searches carry study topics, designs, and journal names only.

The listing budget rises from 11,500 to 11,700 for the 68th skill
(11,686 total, the same ~172-char average per skill), and every
displayed count surface (READMEs, website, brand SVG) moves 67 -> 68.
Eval sets follow the skill-creator contract (3 evals, 10/10 triggers).
The audit doc records gap closures: #2 (PR #138), #4 (PR #140), and the
journal-selection half of #5, with the ICMJE COI half left open as a
decision. Description fingerprints regenerated from history.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 270533cf-5c3f-47e9-97ca-51932d0a5b5d
📥 Commits

Reviewing files that changed from the base of the PR and between cfd25e4 and dec3932.

⛔ Files ignored due to path filters: 1
  • website/static/brand/social-preview.svg is excluded by !**/*.svg
📒 Files selected for processing: 12
  • README.md
  • docs/audits/2026-10-19-medsci-skills-competitive-audit.md
  • docs/setup.md
  • evals/methodsmith/skill-creator/method-journal-select/evals.json
  • evals/methodsmith/skill-creator/method-journal-select/trigger-evals.json
  • plugins/methodsmith/README.md
  • plugins/methodsmith/skills/method-journal-select/SKILL.md
  • plugins/methodsmith/skills/method-update/references/renamed-commands.md
  • scripts/rebrand/mapping.json
  • src/data/shipped-description-fingerprints.json
  • tests/skill-best-practices.test.ts
  • website/src/pages/index.js
+--------------------------------------------------------------------------------------------------------------------------------+
| Some things are better done than described. Don't fall into the specification spiral - at some point you need to start coding. |
+--------------------------------------------------------------------------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sajor2000
sajor2000 merged commit 2f55e3b into main Oct 21, 2026
2 of 3 checks passed
@sajor2000
sajor2000 deleted the feat/journal-selection-skill branch October 21, 2026 03:26
@github-actions github-actions Bot mentioned this pull request Oct 21, 2026
sajor2000 added a commit that referenced this pull request Oct 21, 2026
Gaps #3, #5, #7, #10 closed (PRs #150, #151, #153, #154); #1, #6, #8
tracked as issues #141, #144, #146 with scoping; #9 wontfix as #147.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant