Repository navigation
feat(submission-package): collect and cross-check ICMJE COI disclosures - #153
Merged
Merged
Conversation
MedSci audit gap #5 remainder (submission lane; closes the open decision in #143 by implementing Option B): the submission lane now handles ICMJE COI instead of demanding a standalone skill. - SKILL.md step 4c: collect each author's ICMJE disclosure data (financial activities, funding, affiliation; ICMJE Recommendations II.D), write form-ready data only under manuscript/coi/ — never sign for an author — and cross-check the manuscript's COI statement against the collected data and every funder named in manuscript, cover letter, or registry. Missing statement, funder in one source but not another, or a "no conflicts" claim contradicted by the data blocks the package. - journal-package-checklist.md: matching checklist item. - evals: COI expectations folded into evals 1 and 3 (fixed shape: 3 evals, 20 triggers), one trigger query swapped for the COI form-data ask, and a new repository-owned behavioral case method-submission-package-coi-cross- check (funder named in Funding, absent from a no-conflicts statement -> readiness blocked; no signoff) with synthetic fixtures only. Closes #143 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 8
✨ Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements Option B from #143: the submission lane now collects and cross-checks ICMJE COI disclosures as a workflow step inside
method-submission-package, rather than adding a standalone skill (the audit closure record's lean).SKILL.mdstep 4c — collect per-author ICMJE disclosure data (financial activities, funding, affiliation; ICMJE Recommendations II.D), write form-ready data only undermanuscript/coi/(each author signs their own form), and cross-check the manuscript's COI statement against the collected data and every funder named in the manuscript, cover letter, or registry entry. Missing statement, a funder present in one source but absent from another, or a "no conflicts" claim contradicted by the data blocks the package.references/journal-package-checklist.md— matching checklist item.evals/methodsmith/skill-creator/method-submission-package/— COI expectations folded into evals 1 and 3 (shape fixed at 3 evals / 20 triggers per the contract test); one trigger query swapped for the COI form-data ask.evals/methodsmith/cases/method-submission-package-coi-cross-check/— new repository-owned behavioral case: funder named in Funding, absent from a "no conflicts" statement -> readinessblocked, neverready-for-signoff. Synthetic fixtures only.Closes #143
Validation
bun run eval:validate— pass (new case validates)bun test— full suite green (eval-shape and contract tests included)bun run release:validate— in sync (55 agents, 68 skills); no release-owned files touchedmethod-submission-package.manuscript/coi/.