Fix spelling error by rread · Pull Request #3 · daos-stack/daos

rread · 2017-01-11T23:03:19Z

indice -> index

johannlombardi · 2017-03-30T12:38:55Z

Already landed. Thanks!

1. Fixes some benign warnings given by Intel compiler 2. Adds daos_common.so dependence in libdaos.so 3. Updates scons_local to get updates compiler settings On #3, it also fixes the extra warnings we get regarding unknown command line options. Change-Id: I528bfd0f21f2c051c36e7eebc802b20756b3389d Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com> Reviewed-on: https://review.whamcloud.com/32226 Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Liang Zhen <liang.zhen@intel.com>

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

increasing once again. Signed-off-by: Justiniano-pagn <amanda.justiniano-pagn@intel.com>

Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

- Minor refactoring in iv_code - Workaround in D_REALLOC macro to elimiante KW complaints - Few other misc kw fixes Change-Id: I31e7938db2676dbbe393ddd08a073a2cb7a45ac0 Signed-off-by: Alex Oganezov <alexander.a.oganezov@intel.com> Reviewed-on: https://review.whamcloud.com/31591 Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Yulu Jia <yulu.jia@intel.com> Reviewed-by: Ashley Pittman <ashley.m.pittman@intel.com>

Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

Signed-off-by: Sydney Vanda <sydney.m.vanda@intel.com>

Covers src/control and subdirs Skip-build: true Skip-test: true Change-Id: I57927127e843315c451459472c62d77f0f5ea44a Signed-off-by: Hua Kuang <hua.kuang@intel.com>

Fixed some left over head comments. Skip-build: true Skip-test: true Change-Id: I5e906f5f3a5dfd6f5288643d08924c156daf36eb Signed-off-by: Hua Kuang <hua.kuang@intel.com>

Covers src/control and subdirs Signed-off-by: Hua Kuang <hua.kuang@intel.com>

Fix coverity issue: CID 318952 (#3 of 3): Explicit null dereferenced (FORWARD_NULL) 15. var_deref_op: Dereferencing null pointer rank_list. Skip-build-leap15-rpm: true Skip-func-test-leap15: true Skip-build-ubuntu-clang: true Skip-build-leap15-icc: true Skip-coverity-test: true Quick-build: true Test-tag: cart Skip-unit-tests: true Skip-nlt: true Skip-unit-test: true Skip-unit-test-memcheck: true Skip-coverity-test: true Skip-func-hw-test-small: true Skip-func-hw-test-medium: true Skip-func-hw-test-large: true Signed-off-by: Ethan Mallove <ethanx.a.mallove@intel.com>

Fix coverity issue: CID 318952 (#3 of 3): Explicit null dereferenced (FORWARD_NULL) 15. var_deref_op: Dereferencing null pointer rank_list. alloc_fn: Storage is returned from allocation function malloc. 2. var_assign: Assigning: swim_seq = storage returned from malloc(1024UL). CID 318948 (#2 of 2): Resource leak (RESOURCE_LEAK) 4. overwrite_var: Overwriting swim_seq in swim_seq = "" leaks the storage that swim_seq points to. Fix coverity STRING_OVERFLOW issue: CID 318951 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 39. fixed_size_dest: You might overrun the 8-character fixed-size string exp_status by copying cursorCopy + groupArray[g].rm_so without checking the length. Signed-off-by: Ethan Mallove <ethanx.a.mallove@intel.com>

Makito and Samir observed the following assertion failure after restarting engines. #0 raise () from /lib64/libc.so.6 #1 abort () from /lib64/libc.so.6 #2 __assert_fail_base () from /lib64/libc.so.6 #3 __assert_fail () from /lib64/libc.so.6 #4 pool_map_get_version (map=0x0) at src/common/pool_map.c:2852 #5 ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at src/include/daos_srv/pool.h:296 #6 pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at src/rebuild/srv.c:2101 #7 rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at src/rebuild/scan.c:954 #8 crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654 #9 ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at arch/abtd_ythread.c:21 #10 make_fcontext () from /usr/lib64/libabt.so.1 #11 ?? () The ds_pool_get_version call passed a NULL map argument to pool_map_get_version. The ds_pool.sp_map field may be NULL after the pool is started but before the pool receives the initial pool map from the pool service. This patch fixes ds_pool_get_version to return 0, which is less than all valid pool map versions, when sp_map is NULL, resulting in rebuild retries like this: Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...] Target[2] (rank 2 idx 0 status 16 ver 1) is excluded. Also, this patch removes some rebuild code that handles NULL ds_pool.sp_group fields. Those can not happen as we always initialize sp_group (as well as sp_iv_ns) before putting a ds_pool object into the LRU. Signed-off-by: Li Wei <wei.g.li@intel.com>

Makito and Samir observed the following assertion failure after restarting engines. #0 raise () from /lib64/libc.so.6 #1 abort () from /lib64/libc.so.6 #2 __assert_fail_base () from /lib64/libc.so.6 #3 __assert_fail () from /lib64/libc.so.6 #4 pool_map_get_version (map=0x0) at src/common/pool_map.c:2852 #5 ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at src/include/daos_srv/pool.h:296 #6 pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at src/rebuild/srv.c:2101 #7 rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at src/rebuild/scan.c:954 #8 crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654 #9 ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at arch/abtd_ythread.c:21 #10 make_fcontext () from /usr/lib64/libabt.so.1 #11 ?? () The ds_pool_get_version call passed a NULL map argument to pool_map_get_version. The ds_pool.sp_map field may be NULL after the pool is started but before the pool receives the initial pool map from the pool service. This patch fixes ds_pool_get_version to return 0, which is less than all valid pool map versions, when sp_map is NULL, resulting in rebuild retries like this: Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...] Target[2] (rank 2 idx 0 status 16 ver 1) is excluded. Also, this patch removes some rebuild code that handles NULL ds_pool.sp_group fields. Those can not happen as we always initialize sp_group (as well as sp_iv_ns) before putting a ds_pool object into the LRU. Skip-test: true Signed-off-by: Li Wei <wei.g.li@intel.com>

mkdocs.yml debug/fix #3 Doc-only: true Signed-off-by: Michael Hennecke <michael.hennecke@intel.com>

$ nvme get-feature /dev/nvme0 -f 7 get-feature:0x7 (Number of Queues), Current value:00000000 Value is 00000000 which means that this SSD is reporting it only has 1 qpair (1 submission queue and 1 completion queue). Backport a SPDK patch to work around this issue. Install updated SPDK RPMs with workaround for NVMe bug Remove leftover from 1.1.4 and license from README file. Signed-off-by: Johann Lombardi <johann.lombardi@intel.com>

To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>

To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>

To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>

Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>

Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>

Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>

To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix the backoff-less retrying of -DER_AGAINs from container recovery. It has been seen to generate 11 million log messages within 2 minutes. Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Signed-off-by: Li Wei <liwei@hpe.com>

Fix spelling error

a2a4736

indice -> index

johannlombardi closed this Mar 30, 2017

brianjmurrell added a commit that referenced this pull request Oct 3, 2019

Now use build #3 of cart PR

65d3f1d

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

amjustin13 pushed a commit that referenced this pull request Nov 19, 2019

Test case #3 of ior_small test fails with smaller timeout value,

6bd310f

increasing once again. Signed-off-by: Justiniano-pagn <amanda.justiniano-pagn@intel.com>

brianjmurrell added a commit that referenced this pull request Mar 11, 2020

Allow vendor change, try #3

33dcc58

Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

brianjmurrell added a commit that referenced this pull request Mar 17, 2020

Allow vendor change, try #3

b491101

Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

kccain mentioned this pull request May 20, 2020

DAOS-1742 md: rdb/raft regression test update #2708

Merged

dinghwah mentioned this pull request May 28, 2020

DAOS-4860: Update Jenkinsfile with bandit.config #2797

Merged

brianjmurrell added a commit that referenced this pull request Jun 2, 2020

Allow vendor change, try #3

afec68e

Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

PetFet mentioned this pull request Jun 16, 2020

DAOS-4441 Placement: Modify Placement for OS Reintegration #2402

Merged

sydneyvanda added a commit that referenced this pull request Aug 6, 2020

Fix complier errors attempt #3

cb02886

Signed-off-by: Sydney Vanda <sydney.m.vanda@intel.com>

tanabarr mentioned this pull request Dec 22, 2020

DAOS-6063 control: event notifications from harness to MS #4032

Merged

ashleypittman mentioned this pull request Jan 11, 2021

DAOS-6159 test: Run fault injection tests in parallel and prepare for IL testing. #3902

Merged

GitHuaKuang added a commit that referenced this pull request Jan 20, 2021

DAOS-6338 DAOS:Change DAOS license text #3

74bcc18

Covers src/control and subdirs Skip-build: true Skip-test: true Change-Id: I57927127e843315c451459472c62d77f0f5ea44a Signed-off-by: Hua Kuang <hua.kuang@intel.com>

GitHuaKuang added a commit that referenced this pull request Jan 20, 2021

DAOS-6338 DAOS:Change DAOS license text #3

78e61e4

Fixed some left over head comments. Skip-build: true Skip-test: true Change-Id: I5e906f5f3a5dfd6f5288643d08924c156daf36eb Signed-off-by: Hua Kuang <hua.kuang@intel.com>

jolivier23 pushed a commit that referenced this pull request Jan 27, 2021

DAOS-6338 DAOS:Change DAOS license text #3 (#4347)

8a2d585

Covers src/control and subdirs Signed-off-by: Hua Kuang <hua.kuang@intel.com>

wangdi1 mentioned this pull request Aug 2, 2021

DAOS-8082 mgmt: missing collect req put #6340

Merged

tanabarr mentioned this pull request Aug 4, 2021

DAOS-8211 control: storage prepare vmd support #6339

Merged

mjmac mentioned this pull request May 6, 2022

DAOS-9583 proto: DAOS check protocol changes #8941

Merged

bfaccini mentioned this pull request May 9, 2022

DAOS-10206 config: set up extra systemd options #8593

Open

Michael-Hennecke added a commit that referenced this pull request Apr 24, 2023

DAOS-9355 doc: mkdocs.yml debug/fix

cb76ca3

mkdocs.yml debug/fix #3 Doc-only: true Signed-off-by: Michael Hennecke <michael.hennecke@intel.com>

wiliamhuang mentioned this pull request Jul 21, 2023

DAOS-13548 client: enable one NLT fault injection test for libpil4dfs #12664

Closed

18 tasks

tanabarr mentioned this pull request Nov 23, 2023

DAOS-14181 control,bio,mgmt: Return NVMe details over dRPC #13382

Merged

5 of 18 tasks

jolivier23 mentioned this pull request Dec 19, 2023

DAOS-14532 gurt: Replace environment APIs hook #13483

Merged

18 tasks

This was referenced Jan 22, 2024

DAOS-15066 test: Update dfuse/bash and more to vms. #13631

Merged

DAOS-14164 test: Have fault injection test slow down on loaded systems. #13645

Merged

wiliamhuang mentioned this pull request Apr 16, 2024

DAOS-14149 client: add compatible mode for libpil4dfs #13294

Merged

18 tasks

frostedcmos mentioned this pull request Oct 1, 2024

DAOS-16636 cart: force port range for tcp provider #15209

Draft

18 tasks

tanabarr mentioned this pull request Feb 1, 2025

DAOS-16312 control: Always use --force for dmg system stop #15811

Merged

4 of 18 tasks

mchaarawi mentioned this pull request Nov 13, 2025

DAOS-18161 object: refine EC aggregation processing #17092

Merged

6 tasks

dinghwah mentioned this pull request May 29, 2026

DAOS-19021 doc: SLES Quick start guide updates #18376

Merged

6 tasks

ryon-jensen mentioned this pull request Sep 28, 2026

SRE-4015 ci: run full PR verification only on the stack tip #19073

Open

3 tasks

knard38 mentioned this pull request Oct 8, 2026

DAOS-19608 mgmt: fix pool create failing with DER_EXIST behind a slow engine #19162

Merged

5 of 6 tasks

Navigation Menu

Repository navigation

Fix spelling error - #3

Fix spelling error#3
rread wants to merge 1 commit into
daos-stack:masterfrom
rread:spellfix

rread commented Jan 11, 2017

Uh oh!

johannlombardi commented Mar 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

rread commented Jan 11, 2017

Uh oh!

johannlombardi commented Mar 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants