Skip to content

Fixed an error on line 202 - #9

Closed
TheOtherDave wants to merge 1 commit into
daos-stack:masterfrom
TheOtherDave:patch-1
Closed

Fixed an error on line 202#9
TheOtherDave wants to merge 1 commit into
daos-stack:masterfrom
TheOtherDave:patch-1

Conversation

@TheOtherDave

@TheOtherDave TheOtherDave commented Jun 26, 2018

Copy link
Copy Markdown

Changed "$ scons PREFIX=$(daos_prefix_path}" to "$ scons PREFIX=${daos_prefix_path}"
Note the "(" vs "{" preceding "daos_prefix_path"

@TheOtherDave
Fixed an error on line 202
4e55794 
Changed "$ scons PREFIX=$(daos_prefix_path}" to "$ scons PREFIX=${daos_prefix_path}"
Note the "(" vs "{" preceding "daos_prefix_path"
@daos-jenkins

daos-jenkins commented Jun 26, 2018

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@TheOtherDave

TheOtherDave commented Jun 26, 2018

Copy link
Copy Markdown
Author

Line 202 of https://github.com/daos-stack/daos/blob/master/doc/quickstart.md, that is.

@johannlombardi johannlombardi self-assigned this Jun 28, 2018
@johannlombardi

johannlombardi commented Jun 28, 2018

Copy link
Copy Markdown
Contributor

Good catch. If you don't mind, I am just going to reformat the commit message to match our standard.
Could you please also share with me your signed-off-by?
Thanks for your contribution.

@TheOtherDave

TheOtherDave commented Jun 28, 2018

Copy link
Copy Markdown
Author

Yeah, sure. Sorry, I didn't think to look for commit message formatting guidelines first.

I don't know what a "signed-off-by" is. My real-life name is Dave Sweeris, if that's what you mean.

@johannlombardi

johannlombardi commented Jul 2, 2018

Copy link
Copy Markdown
Contributor

np. As for the Signed-off-by, please see https://wiki.hpdd.intel.com/display/DC/Signed-off-by

@TheOtherDave

TheOtherDave commented Jul 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Author

Edit: Now with less automatic formatting and more angle brackets
Ah, ok.
Signed-off-by: Dave Sweeris <davesweeris@mac.com>

@brianjmurrell

brianjmurrell commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Given that this has been fixed in the existing master, I'm going to close this. Thanks for bringing it to our attention.

@kccain kccain mentioned this pull request Jan 31, 2020
Merged
jolivier23 added a commit that referenced this pull request Mar 23, 2020
@jolivier23
CORCI-599 lint: Fix check_script.py (#9)
24a3ff3 
* CORCI-599 lint: Fix check_script.py

The fix_log code at some point was effectively disabled in that
the output it produced was unused.   So SCons errors would point
at the wrong lines effectively making the check less useful.

This fixes that problem.

also add Delete to fake_scons

Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
@ashleypittman ashleypittman mentioned this pull request Jan 11, 2021
Merged
@wangdi1 wangdi1 mentioned this pull request Aug 2, 2021
Merged
liw added a commit that referenced this pull request Jun 7, 2022
@liw
DAOS-10622 pool: Fix ds_pool_get_version for NULL sp_map
4f53ddd 
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <wei.g.li@intel.com>
shimizukko pushed a commit that referenced this pull request Jun 28, 2022
@liw @shimizukko
DAOS-10622 pool: Fix ds_pool_get_version for NULL sp_map
f04db43 
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Skip-test: true
Signed-off-by: Li Wei <wei.g.li@intel.com>
@tanabarr tanabarr mentioned this pull request Jul 5, 2022
Merged
liw added a commit that referenced this pull request Jul 6, 2022
@liw
DAOS-10622 pool: Fix ds_pool_get_version for NULL sp_map
f72f2f7 
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <wei.g.li@intel.com>
jolivier23 pushed a commit that referenced this pull request Jul 19, 2022
@liw
DAOS-10622 pool: Fix ds_pool_get_version for NULL sp_map (#9277)
535febf 
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <wei.g.li@intel.com>
liw added a commit that referenced this pull request Jul 20, 2022
@liw
DAOS-10622 pool: Fix ds_pool_get_version for NULL sp_map (#9277)
0cf02ea 
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <wei.g.li@intel.com>
@liw liw mentioned this pull request Jul 20, 2022
Merged
jolivier23 pushed a commit that referenced this pull request Jul 21, 2022
@liw
DAOS-10622 pool: Fix ds_pool_get_version for NULL sp_map (#9277) (#9753)
d01b8a6 
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <wei.g.li@intel.com>
mlawsonca pushed a commit that referenced this pull request May 16, 2023
@markaolson
DAOS-9507 Modifications for DAOS v2.0 (#9)
7d077d8 
- Changed image build scripts to install and configure
DAOS v2.0.
- Image family name now includes OS. (Ex. daos-server-centos7)
- Changed IO500 install script to install IO500 SC21.
- Updated terraform/examples/io500 to use new os image family
names and run IO500 SC21.
- Refactored env variable names to be more obvious about what
they are used for.
- Image names and image family now include the name of the source
   image.
- No longer installing IO500 in client images.
  mpifileutils and IO500 SC21 will now be installed prior to running the
  IO500 benchmark.
- The cleanup step that runs before an IO500 run will now
  set nr_hugepages in daos_server.yml
- Logging improvements.

Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
@wiliamhuang wiliamhuang mentioned this pull request Jul 21, 2023
Closed
18 tasks
osalyk pushed a commit to osalyk/daos that referenced this pull request Oct 18, 2023
@janekmi
Merge pull request daos-stack#9 from janekmi/vos_dtx_attach
7a16c22 
dumps: refine dtx_update_abort/vos_dtx_attach
@wiliamhuang wiliamhuang mentioned this pull request Apr 16, 2024
Merged
18 tasks
@mchaarawi mchaarawi mentioned this pull request Nov 13, 2025
Merged
6 tasks
liw added a commit that referenced this pull request Mar 11, 2026
@liw
DAOS-18673 pool: Initialize sp_recov_lock
6103f56 
Looks like ds_pool.sp_recov_lock is not initialized via
ABT_rwlock_create. This led to the following ABT error,

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  #6  in cont_iv_ent_update at src/container/container_iv.c:646
  #7  in update_iv_value at src/engine/server_iv.c:280
  #8  in iv_on_update_internal at src/engine/server_iv.c:490
  #9  in ivc_on_update at src/engine/server_iv.c:530
  #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438
  #11 in crt_iv_update at src/cart/crt_iv.c:3559
  #12 in iv_op_internal at src/engine/server_iv.c:1080
  #13 in _iv_op at src/engine/server_iv.c:1129
  #14 in iv_op at src/engine/server_iv.c:1241
  #15 in ds_iv_update at src/engine/server_iv.c:1287
  #16 in cont_iv_update at src/container/container_iv.c:867
  #17 in cont_iv_capability_update at src/container/container_iv.c:1245
  #18 in cont_open at src/container/srv_container.c:2821
  #19 in cont_op_with_cont at src/container/srv_container.c:5613
  #20 in cont_op_with_svc at src/container/srv_container.c:5845
  #21 in ds_cont_op_handler at src/container/srv_container.c:6064
  #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108
  #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747

where the line was

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  1954            DABT_RWLOCK_RDLOCK(pool->sp_recov_lock);

Signed-off-by: Li Wei <liwei@hpe.com>
liw added a commit that referenced this pull request Mar 11, 2026
@liw
DAOS-18673 pool: Initialize sp_recov_lock
da151ae 
Looks like ds_pool.sp_recov_lock is not initialized via
ABT_rwlock_create. This led to the following ABT error,

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  #6  in cont_iv_ent_update at src/container/container_iv.c:646
  #7  in update_iv_value at src/engine/server_iv.c:280
  #8  in iv_on_update_internal at src/engine/server_iv.c:490
  #9  in ivc_on_update at src/engine/server_iv.c:530
  #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438
  #11 in crt_iv_update at src/cart/crt_iv.c:3559
  #12 in iv_op_internal at src/engine/server_iv.c:1080
  #13 in _iv_op at src/engine/server_iv.c:1129
  #14 in iv_op at src/engine/server_iv.c:1241
  #15 in ds_iv_update at src/engine/server_iv.c:1287
  #16 in cont_iv_update at src/container/container_iv.c:867
  #17 in cont_iv_capability_update at src/container/container_iv.c:1245
  #18 in cont_open at src/container/srv_container.c:2821
  #19 in cont_op_with_cont at src/container/srv_container.c:5613
  #20 in cont_op_with_svc at src/container/srv_container.c:5845
  #21 in ds_cont_op_handler at src/container/srv_container.c:6064
  #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108
  #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747

where the line was

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  1954            DABT_RWLOCK_RDLOCK(pool->sp_recov_lock);

Signed-off-by: Li Wei <liwei@hpe.com>
gnailzenh pushed a commit that referenced this pull request Mar 17, 2026
@liw
DAOS-18673 pool: Initialize sp_recov_lock (#17685)
2adb9b5 
Looks like ds_pool.sp_recov_lock is not initialized via
ABT_rwlock_create. This led to the following ABT error,

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  #6  in cont_iv_ent_update at src/container/container_iv.c:646
  #7  in update_iv_value at src/engine/server_iv.c:280
  #8  in iv_on_update_internal at src/engine/server_iv.c:490
  #9  in ivc_on_update at src/engine/server_iv.c:530
  #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438
  #11 in crt_iv_update at src/cart/crt_iv.c:3559
  #12 in iv_op_internal at src/engine/server_iv.c:1080
  #13 in _iv_op at src/engine/server_iv.c:1129
  #14 in iv_op at src/engine/server_iv.c:1241
  #15 in ds_iv_update at src/engine/server_iv.c:1287
  #16 in cont_iv_update at src/container/container_iv.c:867
  #17 in cont_iv_capability_update at src/container/container_iv.c:1245
  #18 in cont_open at src/container/srv_container.c:2821
  #19 in cont_op_with_cont at src/container/srv_container.c:5613
  #20 in cont_op_with_svc at src/container/srv_container.c:5845
  #21 in ds_cont_op_handler at src/container/srv_container.c:6064
  #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108
  #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747

where the line was

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  1954            DABT_RWLOCK_RDLOCK(pool->sp_recov_lock);

Signed-off-by: Li Wei <liwei@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@johannlombardi johannlombardi

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TheOtherDave @daos-jenkins @johannlombardi @brianjmurrell