Just to trigger by mdiep25 · Pull Request #8 · daos-stack/daos

mdiep25 · 2017-11-17T22:09:01Z

Signed-off-by: Minh Diep minh.diep@intel.com

daos-jenkins · 2017-11-17T22:11:01Z

Can one of the admins verify this patch?

Signed-off-by: Minh Diep <minh.diep@intel.com>

mdiep25 · 2017-11-17T23:20:03Z

testing

daos-jenkins · 2017-11-17T23:31:02Z

Can one of the admins verify this patch?

mdiep25 · 2017-11-18T00:15:59Z

just one

Signed-off-by: Minh Diep <minh.diep@intel.com>

#8) clang-format doesn't work on older clang compilers. Rather than skipping the step, instead use fallback of Mozilla if the version isn't suitable. Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>

#8780) It is possible that the error is not reset to 0 when a process is retrieving the private event in a multi-threaded environment since another thread might have processed the event completion. add a lock on daos_event_t for events that are not part of an event queue, including the thread private event. This is required because in a multithreaded environment like dfuse, the event can be completed and the error set non atomically, while the main thread sees the completion but before the error has actually set, causing the owner of the event to reset the event error, with the other thread setting the error after. this affects future use of the event that launches with ev_error already set to the previous error. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>

#8779) It is possible that the error is not reset to 0 when a process is retrieving the private event in a multi-threaded environment since another thread might have processed the event completion. add a lock on daos_event_t for events that are not part of an event queue, including the thread private event. This is required because in a multithreaded environment like dfuse, the event can be completed and the error set non atomically, while the main thread sees the completion but before the error has actually set, causing the owner of the event to reset the event error, with the other thread setting the error after. this affects future use of the event that launches with ev_error already set to the previous error. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>

Makito and Samir observed the following assertion failure after restarting engines. #0 raise () from /lib64/libc.so.6 #1 abort () from /lib64/libc.so.6 #2 __assert_fail_base () from /lib64/libc.so.6 #3 __assert_fail () from /lib64/libc.so.6 #4 pool_map_get_version (map=0x0) at src/common/pool_map.c:2852 #5 ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at src/include/daos_srv/pool.h:296 #6 pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at src/rebuild/srv.c:2101 #7 rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at src/rebuild/scan.c:954 #8 crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654 #9 ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at arch/abtd_ythread.c:21 #10 make_fcontext () from /usr/lib64/libabt.so.1 #11 ?? () The ds_pool_get_version call passed a NULL map argument to pool_map_get_version. The ds_pool.sp_map field may be NULL after the pool is started but before the pool receives the initial pool map from the pool service. This patch fixes ds_pool_get_version to return 0, which is less than all valid pool map versions, when sp_map is NULL, resulting in rebuild retries like this: Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...] Target[2] (rank 2 idx 0 status 16 ver 1) is excluded. Also, this patch removes some rebuild code that handles NULL ds_pool.sp_group fields. Those can not happen as we always initialize sp_group (as well as sp_iv_ns) before putting a ds_pool object into the LRU. Signed-off-by: Li Wei <wei.g.li@intel.com>

Makito and Samir observed the following assertion failure after restarting engines. #0 raise () from /lib64/libc.so.6 #1 abort () from /lib64/libc.so.6 #2 __assert_fail_base () from /lib64/libc.so.6 #3 __assert_fail () from /lib64/libc.so.6 #4 pool_map_get_version (map=0x0) at src/common/pool_map.c:2852 #5 ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at src/include/daos_srv/pool.h:296 #6 pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at src/rebuild/srv.c:2101 #7 rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at src/rebuild/scan.c:954 #8 crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654 #9 ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at arch/abtd_ythread.c:21 #10 make_fcontext () from /usr/lib64/libabt.so.1 #11 ?? () The ds_pool_get_version call passed a NULL map argument to pool_map_get_version. The ds_pool.sp_map field may be NULL after the pool is started but before the pool receives the initial pool map from the pool service. This patch fixes ds_pool_get_version to return 0, which is less than all valid pool map versions, when sp_map is NULL, resulting in rebuild retries like this: Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...] Target[2] (rank 2 idx 0 status 16 ver 1) is excluded. Also, this patch removes some rebuild code that handles NULL ds_pool.sp_group fields. Those can not happen as we always initialize sp_group (as well as sp_iv_ns) before putting a ds_pool object into the LRU. Skip-test: true Signed-off-by: Li Wei <wei.g.li@intel.com>

Makito and Samir observed the following assertion failure after restarting engines. #0 raise () from /lib64/libc.so.6 #1 abort () from /lib64/libc.so.6 #2 __assert_fail_base () from /lib64/libc.so.6 #3 __assert_fail () from /lib64/libc.so.6 #4 pool_map_get_version (map=0x0) at src/common/pool_map.c:2852 #5 ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at src/include/daos_srv/pool.h:296 #6 pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at src/rebuild/srv.c:2101 #7 rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at src/rebuild/scan.c:954 #8 crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654 #9 ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at arch/abtd_ythread.c:21 #10 make_fcontext () from /usr/lib64/libabt.so.1 #11 ?? () The ds_pool_get_version call passed a NULL map argument to pool_map_get_version. The ds_pool.sp_map field may be NULL after the pool is started but before the pool receives the initial pool map from the pool service. This patch fixes ds_pool_get_version to return 0, which is less than all valid pool map versions, when sp_map is NULL, resulting in rebuild retries like this: Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device or resource busy') Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2 Rebuild [started] (pool 3bf68c9c ver=2) Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...] Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...] Target[2] (rank 2 idx 0 status 16 ver 1) is excluded. Also, this patch removes some rebuild code that handles NULL ds_pool.sp_group fields. Those can not happen as we always initialize sp_group (as well as sp_iv_ns) before putting a ds_pool object into the LRU. Signed-off-by: Li Wei <wei.g.li@intel.com>

Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>

…caffolding dumps: dtx_update_abort scaffolding

Looks like ds_pool.sp_recov_lock is not initialized via ABT_rwlock_create. This led to the following ABT error, #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 #6 in cont_iv_ent_update at src/container/container_iv.c:646 #7 in update_iv_value at src/engine/server_iv.c:280 #8 in iv_on_update_internal at src/engine/server_iv.c:490 #9 in ivc_on_update at src/engine/server_iv.c:530 #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438 #11 in crt_iv_update at src/cart/crt_iv.c:3559 #12 in iv_op_internal at src/engine/server_iv.c:1080 #13 in _iv_op at src/engine/server_iv.c:1129 #14 in iv_op at src/engine/server_iv.c:1241 #15 in ds_iv_update at src/engine/server_iv.c:1287 #16 in cont_iv_update at src/container/container_iv.c:867 #17 in cont_iv_capability_update at src/container/container_iv.c:1245 #18 in cont_open at src/container/srv_container.c:2821 #19 in cont_op_with_cont at src/container/srv_container.c:5613 #20 in cont_op_with_svc at src/container/srv_container.c:5845 #21 in ds_cont_op_handler at src/container/srv_container.c:6064 #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108 #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747 where the line was #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 1954 DABT_RWLOCK_RDLOCK(pool->sp_recov_lock); Signed-off-by: Li Wei <liwei@hpe.com>

mdiep25 force-pushed the mdiep-test branch 7 times, most recently from 56cc1c0 to a0a5a6d Compare November 17, 2017 23:12

Just to trigger again

d28364c

Signed-off-by: Minh Diep <minh.diep@intel.com>

mdiep25 force-pushed the mdiep-test branch from a0a5a6d to d28364c Compare November 17, 2017 23:16

mdiep25 force-pushed the mdiep-test branch 8 times, most recently from 5f3f73c to d4ca69b Compare November 18, 2017 00:13

mdiep25 force-pushed the mdiep-test branch 4 times, most recently from 0a58fdf to 951b00a Compare November 18, 2017 00:23

mdiep25 force-pushed the mdiep-test branch 2 times, most recently from 41a6dad to d4cc914 Compare November 28, 2017 01:14

trigger

eed5cf9

Signed-off-by: Minh Diep <minh.diep@intel.com>

mdiep25 force-pushed the mdiep-test branch from d4cc914 to eed5cf9 Compare November 28, 2017 01:29

johannlombardi closed this Jun 28, 2018

johannlombardi deleted the mdiep-test branch August 29, 2018 20:53

bfaccini mentioned this pull request Aug 22, 2020

DAOS-4207 utils: implement [pool,cont] del-attr #3212

Merged

ashleypittman mentioned this pull request Jan 11, 2021

DAOS-6159 test: Run fault injection tests in parallel and prepare for IL testing. #3902

Merged

sylviachanoiyee mentioned this pull request May 4, 2021

DAOS-7148 Test: enable osa/osa_dmg_negative_test.py #5446

Merged

wangdi1 mentioned this pull request Aug 2, 2021

DAOS-8082 mgmt: missing collect req put #6340

Merged

liw mentioned this pull request Jul 20, 2022

DAOS-10622 pool: Fix ds_pool_get_version for NULL sp_map (#9277) #9753

Merged

Nasf-Fan mentioned this pull request Mar 20, 2023

DAOS-12706 object: Some memory corruption issue #11624

Merged

18 tasks

mlawsonca pushed a commit that referenced this pull request May 16, 2023

Speedup deployment and propagate SSH keys on client nodes (#8)

5a92d2b

Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>

wiliamhuang mentioned this pull request Jul 21, 2023

DAOS-13548 client: enable one NLT fault injection test for libpil4dfs #12664

Closed

18 tasks

osalyk pushed a commit to osalyk/daos that referenced this pull request Oct 18, 2023

Merge pull request daos-stack#8 from janekmi/dumps_dtx_update_abort_s…

cde39c7

…caffolding dumps: dtx_update_abort scaffolding

rpadma2 mentioned this pull request Feb 14, 2024

DAOS-7372 test: Check IOR performance with scrubber enabled. #13268

Closed

18 tasks

wiliamhuang mentioned this pull request Apr 16, 2024

DAOS-14149 client: add compatible mode for libpil4dfs #13294

Merged

18 tasks

phender mentioned this pull request Sep 15, 2025

DAOS-17981 build: Fix CI_BUILD_PACKAGES_ONLY use #16857

Merged

6 tasks

mchaarawi mentioned this pull request Nov 13, 2025

DAOS-18161 object: refine EC aggregation processing #17092

Merged

6 tasks

saurabhtandan mentioned this pull request Aug 20, 2026

DAOS-18609 test: Resolving slurm issue for el9 #18294

Merged

6 tasks

ryon-jensen mentioned this pull request Sep 28, 2026

SRE-4015 ci: run full PR verification only on the stack tip #19073

Open

3 tasks

Navigation Menu

Repository navigation

Just to trigger - #8

Just to trigger#8
mdiep25 wants to merge 2 commits into
masterfrom
mdiep-test

mdiep25 commented Nov 17, 2017

Uh oh!

daos-jenkins commented Nov 17, 2017

Uh oh!

mdiep25 commented Nov 17, 2017

Uh oh!

daos-jenkins commented Nov 17, 2017

Uh oh!

mdiep25 commented Nov 18, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

mdiep25 commented Nov 17, 2017

Uh oh!

daos-jenkins commented Nov 17, 2017

Uh oh!

mdiep25 commented Nov 17, 2017

Uh oh!

daos-jenkins commented Nov 17, 2017

Uh oh!

mdiep25 commented Nov 18, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

4 participants