Repository navigation
Phylsbranch - #21
Closed
phylcrandall wants to merge 17 commits into
Closed
Phylsbranch#21phylcrandall wants to merge 17 commits into
phylcrandall wants to merge 17 commits into
Conversation
Bring shell script in to alignment with shellcheck standards. Add set -e to catch unhandled errors. Signed-off-by: Brian J. Murrell <brian.murrell@intel.com> Change-Id: I065ef8469f15f6ac4e9df8bf541de5bde0874f72
When fallocate() fails in tgt_vos_create() it's useful to know why. Display the errno value in the error message returned when fallocate() fails. Change-Id: I85bdccc1af391f96bf10985ce5a529ab39ae9204 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I110f824841086a4647c54a22c8cbfdc3e24c7bdd Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I4462957fc3a3f1ef1a7925645ec03f8de6224be0 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
To add commit statuses to the GitHub PR for the various build/test stages. Change-Id: I8ea1a79a33ea3c0e56e114474403a3374a79ce10 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I5820210f625e1384e80e8b13397918edc58ad49e Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: If665a8b1cad983cb32b278ecd126976e662a2cdc Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: Idd3b13133d866d8a7cbbe9b5d7577c8e728621cd Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: Iffd905dc1b8ba6940df2cce45b292aade68d0862 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I07cec253a4438c2a0a0c967a27271c2ada9935c9 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I73c3bb30999c1cc29106ab5a5ec1e7d6486078e6 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I6281d3b713d7ec8946aadc5eb133da883966073e Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I1933d32d2074b57ba79b7d5fcaae855c62e4cc5d Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I2112293bc32cab6cffb80b3b9668650018127989 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: Idce272d96215072cbb47a0e92afed340faaa1808 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: Ib7a505fbae14a9f3a078fd6842a60e8707d6fbd1 Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Change-Id: I825eeb02b59faa0f770034ec077ce81c7a1535df Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Collaborator
|
Can one of the admins verify this patch? |
jolivier23
pushed a commit
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
mlawsonca
pushed a commit
that referenced
this pull request
May 16, 2023
Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>
liw
added a commit
that referenced
this pull request
Mar 11, 2026
Looks like ds_pool.sp_recov_lock is not initialized via ABT_rwlock_create. This led to the following ABT error, #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 #6 in cont_iv_ent_update at src/container/container_iv.c:646 #7 in update_iv_value at src/engine/server_iv.c:280 #8 in iv_on_update_internal at src/engine/server_iv.c:490 #9 in ivc_on_update at src/engine/server_iv.c:530 #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438 #11 in crt_iv_update at src/cart/crt_iv.c:3559 #12 in iv_op_internal at src/engine/server_iv.c:1080 #13 in _iv_op at src/engine/server_iv.c:1129 #14 in iv_op at src/engine/server_iv.c:1241 #15 in ds_iv_update at src/engine/server_iv.c:1287 #16 in cont_iv_update at src/container/container_iv.c:867 #17 in cont_iv_capability_update at src/container/container_iv.c:1245 #18 in cont_open at src/container/srv_container.c:2821 #19 in cont_op_with_cont at src/container/srv_container.c:5613 #20 in cont_op_with_svc at src/container/srv_container.c:5845 #21 in ds_cont_op_handler at src/container/srv_container.c:6064 #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108 #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747 where the line was #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 1954 DABT_RWLOCK_RDLOCK(pool->sp_recov_lock); Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
that referenced
this pull request
Mar 11, 2026
Looks like ds_pool.sp_recov_lock is not initialized via ABT_rwlock_create. This led to the following ABT error, #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 #6 in cont_iv_ent_update at src/container/container_iv.c:646 #7 in update_iv_value at src/engine/server_iv.c:280 #8 in iv_on_update_internal at src/engine/server_iv.c:490 #9 in ivc_on_update at src/engine/server_iv.c:530 #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438 #11 in crt_iv_update at src/cart/crt_iv.c:3559 #12 in iv_op_internal at src/engine/server_iv.c:1080 #13 in _iv_op at src/engine/server_iv.c:1129 #14 in iv_op at src/engine/server_iv.c:1241 #15 in ds_iv_update at src/engine/server_iv.c:1287 #16 in cont_iv_update at src/container/container_iv.c:867 #17 in cont_iv_capability_update at src/container/container_iv.c:1245 #18 in cont_open at src/container/srv_container.c:2821 #19 in cont_op_with_cont at src/container/srv_container.c:5613 #20 in cont_op_with_svc at src/container/srv_container.c:5845 #21 in ds_cont_op_handler at src/container/srv_container.c:6064 #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108 #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747 where the line was #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 1954 DABT_RWLOCK_RDLOCK(pool->sp_recov_lock); Signed-off-by: Li Wei <liwei@hpe.com>
gnailzenh
pushed a commit
that referenced
this pull request
Mar 17, 2026
Looks like ds_pool.sp_recov_lock is not initialized via ABT_rwlock_create. This led to the following ABT error, #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 #6 in cont_iv_ent_update at src/container/container_iv.c:646 #7 in update_iv_value at src/engine/server_iv.c:280 #8 in iv_on_update_internal at src/engine/server_iv.c:490 #9 in ivc_on_update at src/engine/server_iv.c:530 #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438 #11 in crt_iv_update at src/cart/crt_iv.c:3559 #12 in iv_op_internal at src/engine/server_iv.c:1080 #13 in _iv_op at src/engine/server_iv.c:1129 #14 in iv_op at src/engine/server_iv.c:1241 #15 in ds_iv_update at src/engine/server_iv.c:1287 #16 in cont_iv_update at src/container/container_iv.c:867 #17 in cont_iv_capability_update at src/container/container_iv.c:1245 #18 in cont_open at src/container/srv_container.c:2821 #19 in cont_op_with_cont at src/container/srv_container.c:5613 #20 in cont_op_with_svc at src/container/srv_container.c:5845 #21 in ds_cont_op_handler at src/container/srv_container.c:6064 #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108 #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747 where the line was #5 in ds_cont_tgt_open at src/container/srv_target.c:1954 1954 DABT_RWLOCK_RDLOCK(pool->sp_recov_lock); Signed-off-by: Li Wei <liwei@hpe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.