Repository navigation
Conversation
Minor edits to readme file
Contributor
|
Already landed. |
brianjmurrell
added a commit
that referenced
this pull request
Mar 11, 2020
Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
brianjmurrell
added a commit
that referenced
this pull request
Mar 17, 2020
Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
jolivier23
pushed a commit
that referenced
this pull request
Mar 23, 2020
- Fixes to most critical issues found in scan #11 - CRT_BULK_NULL moved from internal to external header Change-Id: Ib14f5b67ed98d60ce2addf0e295686288fa3a775 Signed-off-by: Alex Oganezov <alexander.a.oganezov@intel.com> Reviewed-on: https://review.whamcloud.com/31579 Tested-by: Maloo <hpdd-maloo@intel.com> Reviewed-by: Ashley Pittman <ashley.m.pittman@intel.com> Reviewed-by: Yulu Jia <yulu.jia@intel.com>
brianjmurrell
added a commit
that referenced
this pull request
Jun 2, 2020
Quick-build: true Skip-checkpatch: true Skip-run_test: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
mallove79
added a commit
that referenced
this pull request
Aug 16, 2020
Clean up (hopefully unneccessary) cart.log printers. Put cart.log's into
default DAOS logs dir from the very beginning.
Competing approaches:
1. Find where cart.log's are currently, and move them to artifacts
dir.
2. Put cart.log's into artifacts dir from the start.
Up to now, this branch has used approach #1. #2 appears to be the far
simpler approach; so KISS, reduce complexity -- try #2.
Skip-build-leap15-rpm: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Skip-checkpatch: true
Quick-build: true
Skip-run_test: true
Test-tag: all_cart
Skip-func-test-leap15: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Signed-off-by: Ethan Mallove <ethanx.a.mallove@intel.com>
tanabarr
added a commit
that referenced
this pull request
Sep 22, 2020
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
frostedcmos
added a commit
that referenced
this pull request
Nov 3, 2020
sylviachanoiyee
pushed a commit
that referenced
this pull request
Nov 3, 2020
mallove79
added a commit
that referenced
this pull request
Jan 8, 2021
* Instead of --shutdown_rank, use --rank $rank_id --shut_only. * Instead of --delete_from_ranklist (black-list sense), use cart_ctl-style white-list: --rank 0,1 (to e.g., remove rank #2 from rank list). Skip-build-leap15-rpm: true Skip-build-ubuntu-clang: true Skip-build-leap15-icc: true Skip-coverity-test: true Skip-checkpatch: true Quick-build: true Test-tag: cart Skip-func-test-leap15: true Skip-func-hw-test-small: true Skip-func-hw-test-medium: true Skip-func-hw-test-large: true Skip-unit-test-memcheck: true Signed-off-by: Ethan Mallove <ethanx.a.mallove@intel.com>
jolivier23
added a commit
that referenced
this pull request
Jan 27, 2021
For these directories and their sub_dirs: daos/src/object daos/src/mgmt daos/src/iosrv daos/src/include daos/src/gurt daos/src/dtx daos/src/placement daos/src/pool daos/src/proto daos/src/rdb daos/src/rebuild daos/src/rsvc Signed-off-by: Hua Kuang <hua.kuang@intel.com> Co-authored-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
This was referenced Feb 3, 2021
mallove79
added a commit
that referenced
this pull request
Feb 24, 2021
alloc_fn: Storage is returned from allocation function malloc.
2. var_assign: Assigning: swim_seq = storage returned from malloc(1024UL).
CID 318948 (#2 of 2): Resource leak (RESOURCE_LEAK)
4. overwrite_var: Overwriting swim_seq in swim_seq = "" leaks the storage that
swim_seq points to.
Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true
Signed-off-by: Ethan Mallove <ethanx.a.mallove@intel.com>
sylviachanoiyee
pushed a commit
that referenced
this pull request
Feb 26, 2021
sylviachanoiyee
pushed a commit
that referenced
this pull request
Mar 11, 2021
Fix coverity issue: CID 318952 (#3 of 3): Explicit null dereferenced (FORWARD_NULL) 15. var_deref_op: Dereferencing null pointer rank_list. alloc_fn: Storage is returned from allocation function malloc. 2. var_assign: Assigning: swim_seq = storage returned from malloc(1024UL). CID 318948 (#2 of 2): Resource leak (RESOURCE_LEAK) 4. overwrite_var: Overwriting swim_seq in swim_seq = "" leaks the storage that swim_seq points to. Fix coverity STRING_OVERFLOW issue: CID 318951 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 39. fixed_size_dest: You might overrun the 8-character fixed-size string exp_status by copying cursorCopy + groupArray[g].rm_so without checking the length. Signed-off-by: Ethan Mallove <ethanx.a.mallove@intel.com>
18 tasks
osalyk
pushed a commit
to osalyk/daos
that referenced
this pull request
Oct 12, 2023
dumps: add DTX placeholders
5 of 18 tasks
18 tasks
This was referenced Jan 22, 2024
18 tasks
18 tasks
jolivier23
added a commit
that referenced
this pull request
Jul 8, 2024
18 tasks
6 tasks
4 of 6 tasks
liw
added a commit
that referenced
this pull request
Jul 14, 2026
To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
that referenced
this pull request
Jul 14, 2026
To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
to liw/daos
that referenced
this pull request
Jul 15, 2026
To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
that referenced
this pull request
Jul 16, 2026
To avoid leaking container children during reintegration, perform container recovery in all reintegration modes. Not addressed by this simple change is the extra delay for a POOL_REINT request. Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Fix an ilog_modify log message that can't be controled by DD_MASK, making it unnecessarily harder to turn on debug messages. Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
that referenced
this pull request
Jul 31, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
that referenced
this pull request
Jul 31, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
to liw/daos
that referenced
this pull request
Aug 3, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
to liw/daos
that referenced
this pull request
Aug 3, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
to liw/daos
that referenced
this pull request
Aug 3, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
to liw/daos
that referenced
this pull request
Aug 4, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
to liw/daos
that referenced
this pull request
Aug 4, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
to liw/daos
that referenced
this pull request
Aug 4, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 daos-stack#1 crt_bulk_transfer at src/cart/crt_bulk.c:306 daos-stack#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 daos-stack#3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
that referenced
this pull request
Aug 4, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
liw
added a commit
that referenced
this pull request
Aug 4, 2026
Fix segfault #0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253 #1 crt_bulk_transfer at src/cart/crt_bulk.c:306 #2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203 #3 crt_handle_rpc at src/cart/crt_rpc.c:1756 that happens when reintegrating a target on the PS leader, likely caused by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk transfers is not addressed by this fix.) Features: rebuild Signed-off-by: Li Wei <liwei@hpe.com>
2 of 6 tasks
daltonbohning
pushed a commit
that referenced
this pull request
Aug 31, 2026
To avoid leaking container children during reintegration, perform
container recovery in all reintegration modes. Not addressed by this
simple change is the extra delay for a POOL_REINT request.
Fix the backoff-less retrying of -DER_AGAINs from container recovery. It
has been seen to generate 11 million log messages within 2 minutes.
Fix an ilog_modify log message that can't be controled by DD_MASK,
making it unnecessarily harder to turn on debug messages.
Fix segfault
#0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253
#1 crt_bulk_transfer at src/cart/crt_bulk.c:306
#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203
#3 crt_handle_rpc at src/cart/crt_rpc.c:1756
that happens when reintegrating a target on the PS leader, likely caused
by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing
bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk
transfers is not addressed by this fix.)
Signed-off-by: Li Wei <liwei@hpe.com>
gnailzenh
pushed a commit
that referenced
this pull request
Sep 23, 2026
To avoid leaking container children during reintegration, perform
container recovery in all reintegration modes. Not addressed by this
simple change is the extra delay for a POOL_REINT request.
Fix the backoff-less retrying of -DER_AGAINs from container recovery. It
has been seen to generate 11 million log messages within 2 minutes.
Fix an ilog_modify log message that can't be controled by DD_MASK,
making it unnecessarily harder to turn on debug messages.
Fix segfault
#0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253
#1 crt_bulk_transfer at src/cart/crt_bulk.c:306
#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203
#3 crt_handle_rpc at src/cart/crt_rpc.c:1756
that happens when reintegrating a target on the PS leader, likely caused
by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing
bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk
transfers is not addressed by this fix.)
Signed-off-by: Li Wei <liwei@hpe.com>
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor edits to readme file