Repository navigation
DAOS-10206 config: set up extra systemd options - #8593
johannlombardi wants to merge 5 commits into
Conversation
Add several options to the systemd unit file of the daos_server to: - increase the scheduling priority over other Linux processes - bind the control plane to core #0 to avoid noises on the engine - reduce the OOM score to kill other processes before the daos_server - dump the content of pmem to core files Signed-off-by: Johann Lombardi <johann.lombardi@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
| ExecStart=/usr/bin/daos_server start | ||
| StandardOutput=journal | ||
| StandardError=journal | ||
| StartLimitBurst=5 |
There was a problem hiding this comment.
What situation do you want to address with this setting ?? Do I correctly understand that this means we will tolerate up to 5 service restarts within StartLimitIntervalSec/DefaultStartLimitIntervalSec=10s before to decide stopping restart attempts ?? Well, my experience with daos_server service startup failures is that there is something wrong that needs to be investigated, so I would better set StartLimitBurst=1 and raise a little bit StartLimitIntervalSec to something like 120s. But I am sure we will had to schedule a specific meeting about this topic where everybody can have a different idea !!
There was a problem hiding this comment.
I only moved this one around and did not change the value. Not sure who added it. @mjmac any idea?
There was a problem hiding this comment.
Hmm. Well, git blame shows that @dpquigl added that line. It looks like StartLimitIntervalSec is set to 60s up in the unit block above this, so this is saying that daos_server can only attempt to restart 5 times within 60s, if I understand correctly.
I do tend to agree that there probably isn't much value in having the service attempt to restart multiple times, as errors which prevent successful startup (bad config, missing hardware, etc) aren't likely to resolve themselves.
@dpquigl: Was there a specific rationale behind choosing that value? Should we just revert to the default?
There was a problem hiding this comment.
From my side, everything seems fine at the exception of this parameter StartLimitIntervalSec . Is there any feedback on the motivation to choose this value ?
There was a problem hiding this comment.
I believe this was set the way it was because without it we were flooding the logs with error messages if DAOS wasn't configured correctly and systemd had it enabled.
Signed-off-by: Johann Lombardi <johann.lombardi@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
| Wants=network-online.target | ||
| After=network-online.target | ||
|
|
||
| StartLimitIntervalSec=60 |
There was a problem hiding this comment.
this looks redundant with line #3 in fact
Signed-off-by: Johann Lombardi <johann.lombardi@intel.com>
Signed-off-by: Johann Lombardi <johann.lombardi@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
jolivier23
left a comment
jolivier23
left a comment
There was a problem hiding this comment.
Should we consider merging latest since it's quite old?
Add several options to the systemd unit file of the daos_server to:
Signed-off-by: Johann Lombardi johann.lombardi@intel.com