[dinghwah]

DAOS-4860 test: To update Jenkinsfile to add bandit.config when bandit run.

Test-tag: pr,hw
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

[daosbuild1]

Test stage Functional completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2797/1/execution/node/722/log

[brianjmurrell]

Shouldn't you change the default disabled state of the bandit stage to default-enabled but skipable?

daos/Jenkinsfile

Lines 374 to 375 in 698d03b

	cachedCommitPragma(pragma: 'Skip-python-bandit',
	def_val: 'true') != 'true'

such as:

daos/Jenkinsfile

Line 321 in 698d03b

expression { ! skip_stage('checkpatch') }

Also, not sure why you added Test-tag: pr,hw,large to your commit message. Adding the large tag for the VM tests doesn't make any sense. What was your goal there?

[daosbuild1]

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2797/2/execution/node/70/log

[dinghwah]

@brian, Thank you for the review and comment.
I think we need to skip the bandit.check by default, since it check all the python codes for every new PR. On commit #3, I enable the bandit.check I am also seeing another 30+ bandit errors for the recent checked-in scripts, we need to take care these issues separately.

[daosbuild1]

Test stage run_test.sh completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2797/3/execution/node/389/log

[brianjmurrell]

I am also seeing another 30+ bandit errors for the recent checked-in scripts, we need to take care these issues separately.

Is there a ticket for that?

TBH, I'm not sure I see the point in landing this if we continue to have bandit disabled. IOW, why not fix the remaining issues, and then land this, enabling bandit?

[dinghwah]

@brian The file bandit.config was missing in the beginning, which should be merged.
Which is not related to enable skip bandit.check turned by default.
The new bandit issue has been tracking by DAOS-5044,