[juliusmarminge]

Problem

When the Pull requests header is condensed (scrolled), Cmd/Ctrl+F reached the topbar search through a counter in state. The keydown handler bumped searchFocusToken, passed it to ExpandableSearch as focusToken, and an effect there compared it against an appliedFocusToken ref to focus and select the input. The event became state, and an effect turned it back into an event.

Change

The keydown handler focuses and selects the topbar input directly, through a ref on the topbar search wrapper. The non-condensed branch already does this for the in-flow input. When the topbar search is closed it has no input yet: setSearchOpen(true) mounts one, and the existing open effect focuses it (select on an empty value does nothing). The searchFocusToken state, the focusToken prop, the appliedFocusToken ref and the token effect are removed. The query is scoped to the wrapper around ExpandableSearch, so it can't match the in-flow copy of the search input in the page body.

setSearchOpen(true) still runs on every condensed Cmd+F, as it did before.

What this improves

• Sync removed: one state-to-effect event relay (state, prop, ref and effect).
• Renders avoided: Cmd+F with the topbar search already open no longer re-renders the column, because setSearchOpen(true) bails out when the value is unchanged. Before, the token bump caused one re-render per press.
• No bug fix is claimed, so there is no regression test. No behavior changes: focus and select land in the same input in every case (closed, open, or kept mounted by a value).

Effects

• apps/web/src/components/pullRequest/PullRequestsColumn.tsx: 5 -> 4. The focus-token effect is removed. The window keydown listener, the IntersectionObserver, the open-focus effect and the condensed-to-in-flow focus handoff stay, because each synchronizes with the DOM.

Verification

• vp run check:changed: format, lint, knip 1/2, knip 2/2 and typecheck (2 packages) all pass.
• This file has no tests, and none were added (no bug fix).

Model: Claude Opus 5.5, Claude Code harness.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 2a4ead2

Macroscope's review found this PR approvable — This localized web refactor removes an intermediate focus-token state relay and scopes direct focus to the condensed topbar search, while preserving the existing focus/select behavior. It introduces no schema, configuration, security, billing, deployment, or static-analysis changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: effect/split-a3-pr-search-focus-token
• File: .coderabbit.config.ts
• Commit: 2a4ead2
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 7677deb4-dc76-4e6e-af4a-2dfedb3ee88b

Commits

Reviewing files that changed from the base of the PR and between dc84b09 and 2a4ead2.

Files selected for processing: 1

• apps/web/src/components/pullRequest/PullRequestsColumn.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

Walkthrough

The pull request column now focuses search when it opens. Cmd/Ctrl+F opens condensed search and focuses and selects its input. In-flow search also remains focusable and selectable through the shortcut.

Changes: Pull request search

Layer / File(s)	Summary
Search focus and shortcut handling apps/web/src/components/pullRequest/PullRequestsColumn.tsx	ExpandableSearch no longer uses a focus token or selects text when it opens. Cmd/Ctrl+F opens condensed search and focuses and selects the input in the relevant search container.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 2a4ea

The search-focus refactor preserves the described open and in-flow focus behavior.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem, implementation, effects, and verification. It does not complete the required Scope and approval section, and it does not provide the required before/after UI scre…	Add the triaged issue or maintainer approval link and comment, or explain why this focused refactor qualifies for an exemption. Add clear before/after screenshots for the UI change, include a recording if needed to demonstrate the interacti…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: direct Cmd/Ctrl+F focus of the topbar search in the pull requests view.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, effects, and verification. It does not complete the required Scope and approval section, and it does not provide the required before/after UI screenshots or state any manual UI check results.

Resolution

Add the triaged issue or maintainer approval link and comment, or explain why this focused refactor qualifies for an exemption. Add clear before/after screenshots for the UI change, include a recording if needed to demonstrate the interaction, and document any manual checks and observed results.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}