Conversation
734039e to
04c5ef1
Compare
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a cross-surface redesign of production connect and pairing authorization pages, including shared auth components, Clerk account labeling, and the server-rendered loopback completion page. Changes under the web auth directory require human review even though the existing pairing and authorization flows are preserved. You can add or adjust custom eligibility rules. Learn more. |
48e56f6 to
9cb3146
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between 68f4da95850c7153bd19a2bd072b3a14687fd2af and c1649f97e854070465288853cff456984967c84d. 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe change adds shared Code branding and environment pills, consolidates pairing surfaces, updates CLI authorization states and callback error handling, and redesigns the loopback authorization completion page. ChangesAuthentication branding and flows
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant Browser
participant ConnectCliCallbackSurface
participant Clerk
CLI->>Browser: Open authorization flow
Browser->>ConnectCliCallbackSurface: Return callback URL
ConnectCliCallbackSurface->>ConnectCliCallbackSurface: Read callback error
ConnectCliCallbackSurface->>Clerk: Sign out on user action
Clerk-->>ConnectCliCallbackSurface: Complete sign-out
ConnectCliCallbackSurface-->>CLI: Display or copy authorization code
Merge Risk: ⚪ Minimal · up to The connect and pairing surfaces now use shared branding and clearer callback, cancellation, sign-out, and retry states. No concrete current-head merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Re-route steering that races completion into idempotent follow-up dispatches - Preserve scheduled-task attribution and provider ownership history across clients
Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2. Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.
Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip. Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.
Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.
Co-authored-by: Vitalii Yehorov <vitalyiegorov@gmail.com>
c1649f9 to
8c18d9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fe4f6ad to
87c67bd
Compare
The styal Link "You're connected" page that `styal link` opens in the browser (`apps/server/src/cloud/cliAuthHtml.ts`) still has the blue and indigo banner from before the cotton reel artwork in fork #477. Upstream `pingdotgg#10027` replaces that banner with a plain card, with the wordmark and a Dev or Nightly pill, and restyles the connect and pairing pages to match. Rather than redraw the page in the fork, this adds `pingdotgg#10027` to `.github/upstream-tracked-prs.json` so the page can be picked up at intake, swapping in the styal wordmark. The PR targets upstream's `t3code/codex-turn-mapping` branch rather than `main`, so it may take a while to arrive. `node scripts/upstream-tracked-prs-report.ts` lists `pingdotgg#10027` as open, and `scripts/upstream-tracked-prs.test.ts` passes. --- Written by an agent (Claude Code, claude-opus-5-5).
Note
🤖 GPT-6 on behalf of Oliver
Problem
Connect and pairing pages use decorative banners and cards unlike the app. Pairing errors also lack an accessible association with the token input.
Fix
Use a plain variant of the shared standalone-page layout with the sidebar's branding. Apply the same styling to the server's loopback completion page. Keep pairing errors in a stable live region and associate them with the invalid input.
Retargeted to
t3code/codex-turn-mappingbecause this includes server-rendered HTML. The port preserves current loopback and device authorization. The old hosted callback, copy-code, and callback sign-out changes were dropped because #11794 removed that flow. Sidebar branding retains the current cap-height sizing.UI Changes
These screenshots are the original design evidence and predate the v2 port. The former hosted callback page is no longer part of the change. No fresh browser verification was run.
Before
After
Validation
Thirteen focused Connect/pairing tests, web typecheck, targeted lint, formatting, and diff checks pass. Lint reports existing ref-access warnings. Clerk's production sign-in flow was not verified locally.
Original implementation by Claude Fable 5.1 in Claude Code. Reviewed and ported to v2 by GPT-6 using Codex.