Skip to content

fix(web): align connect and pairing pages with app styling - #10027

Open
flamboh wants to merge 607 commits into
pingdotgg:t3code/codex-turn-mappingfrom
flamboh:t3code/unslop-authorization-pages
Open

flamboh wants to merge 607 commits into
pingdotgg:t3code/codex-turn-mappingfrom
flamboh:t3code/unslop-authorization-pages

Conversation

@flamboh

@flamboh flamboh commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 GPT-6 on behalf of Oliver

Problem

Connect and pairing pages use decorative banners and cards unlike the app. Pairing errors also lack an accessible association with the token input.

Fix

Use a plain variant of the shared standalone-page layout with the sidebar's branding. Apply the same styling to the server's loopback completion page. Keep pairing errors in a stable live region and associate them with the invalid input.

Retargeted to t3code/codex-turn-mapping because this includes server-rendered HTML. The port preserves current loopback and device authorization. The old hosted callback, copy-code, and callback sign-out changes were dropped because #11794 removed that flow. Sidebar branding retains the current cap-height sizing.

UI Changes

These screenshots are the original design evidence and predate the v2 port. The former hosted callback page is no longer part of the change. No fresh browser verification was run.

Before

SCR-20260905-cald SCR-20260905-bzqf SCR-20260905-bzoe

After

SCR-20260905-canj SCR-20260905-bzrg SCR-20260905-bzou

Validation

Thirteen focused Connect/pairing tests, web typecheck, targeted lint, formatting, and diff checks pass. Lint reports existing ref-access warnings. Clerk's production sign-in flow was not verified locally.

Original implementation by Claude Fable 5.1 in Claude Code. Reviewed and ported to v2 by GPT-6 using Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 5, 2026
@flamboh
flamboh force-pushed the t3code/unslop-authorization-pages branch 2 times, most recently from 734039e to 04c5ef1 Compare September 5, 2026 08:14
@flamboh flamboh changed the title fix(web): make connect and pairing pages look like the app fix(web): deslop, make connect and pairing pages look like the app Sep 5, 2026
Comment thread apps/web/src/components/auth/AuthSurfaceShell.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a cross-surface redesign of production connect and pairing authorization pages, including shared auth components, Clerk account labeling, and the server-rendered loopback completion page. Changes under the web auth directory require human review even though the existing pairing and authorization flows are preserved.

You can add or adjust custom eligibility rules. Learn more.

@flamboh
flamboh force-pushed the t3code/unslop-authorization-pages branch from 48e56f6 to 9cb3146 Compare September 7, 2026 10:57
Comment thread apps/web/src/components/cloud/ConnectCliAuthSurface.tsx Outdated
@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 6e84343f-688d-46aa-bca6-9ed9dd62994e

📥 Commits

Reviewing files that changed from the base of the PR and between 68f4da95850c7153bd19a2bd072b3a14687fd2af and c1649f97e854070465288853cff456984967c84d.

📒 Files selected for processing (1)
  • apps/web/src/components/cloud/ConnectCliAuthSurface.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The change adds shared Code branding and environment pills, consolidates pairing surfaces, updates CLI authorization states and callback error handling, and redesigns the loopback authorization completion page.

Changes

Authentication branding and flows

Layer / File(s) Summary
Shared authentication branding
apps/web/src/components/T3Wordmark.tsx, apps/web/src/components/auth/AuthSurfaceShell.tsx, apps/web/src/components/sidebar/SidebarChrome.tsx
Adds reusable Code wordmark and environment pill components. Updates the authentication shell and sidebar to use them.
Pairing surface consolidation
apps/web/src/components/auth/PairingRouteSurface.tsx
Routes pairing states through the shared shell and message components. Updates environment wording, accessibility attributes, and authentication guidance.
CLI authorization flow
apps/web/src/cloud/connectCliAuth.ts, apps/web/src/cloud/connectCliAuth.test.ts, apps/web/src/components/cloud/ConnectCliAuthSurface.tsx
Adds callback error parsing and tests. Updates authorization and callback states for cancellation, failure, sign-out, account display, and code copying.
Loopback authorization page
apps/server/src/cloud/cliAuthHtml.ts
Replaces the gradient layout with a card layout using an inline Code wordmark, conditional stage pill, CSS variables, and dark-mode support.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CLI
  participant Browser
  participant ConnectCliCallbackSurface
  participant Clerk
  CLI->>Browser: Open authorization flow
  Browser->>ConnectCliCallbackSurface: Return callback URL
  ConnectCliCallbackSurface->>ConnectCliCallbackSurface: Read callback error
  ConnectCliCallbackSurface->>Clerk: Sign out on user action
  Clerk-->>ConnectCliCallbackSurface: Complete sign-out
  ConnectCliCallbackSurface-->>CLI: Display or copy authorization code
Loading

Merge Risk: ⚪ Minimal · up to c1649

The connect and pairing surfaces now use shared branding and clearer callback, cancellation, sign-out, and retry states. No concrete current-head merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.53% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 8 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: aligning the Connect and pairing pages with the application styling. It is concise and relevant, although it does not mention the related loopback page up…
Description check ✅ Passed The description explains the problem, the fix, UI changes, screenshots, and validation results. It uses Problem and Fix headings instead of the template's What Changed and Why headings, and it omits t…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Comment thread apps/web/src/components/cloud/ConnectCliAuthSurface.tsx Outdated
- Re-route steering that races completion into idempotent follow-up dispatches
- Preserve scheduled-task attribution and provider ownership history across clients
Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2.

Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.
Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip.

Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.
Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.
@flamboh flamboh changed the title fix(web): deslop, make connect and pairing pages look like the app fix(web): align connect and pairing pages with app styling Sep 21, 2026
@flamboh
flamboh changed the base branch from main to t3code/codex-turn-mapping September 21, 2026 16:48
@flamboh
flamboh force-pushed the t3code/unslop-authorization-pages branch from c1649f9 to 8c18d9b Compare September 21, 2026 16:48
@macroscopeapp

This comment has been minimized.

@macroscopeapp

This comment has been minimized.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 10 times, most recently from fe4f6ad to 87c67bd Compare September 25, 2026 05:55
incognitojam added a commit to incognitojam/styal that referenced this pull request Sep 26, 2026
The styal Link "You're connected" page that `styal link` opens in the
browser (`apps/server/src/cloud/cliAuthHtml.ts`) still has the blue and
indigo banner from before the cotton reel artwork in fork #477.

Upstream `pingdotgg#10027` replaces that banner with a plain card, with the
wordmark and a Dev or Nightly pill, and restyles the connect and pairing
pages to match. Rather than redraw the page in the fork, this adds
`pingdotgg#10027` to `.github/upstream-tracked-prs.json` so the page can be
picked up at intake, swapping in the styal wordmark. The PR targets
upstream's `t3code/codex-turn-mapping` branch rather than `main`, so it
may take a while to arrive.

`node scripts/upstream-tracked-prs-report.ts` lists `pingdotgg#10027` as open,
and `scripts/upstream-tracked-prs.test.ts` passes.

---
Written by an agent (Claude Code, claude-opus-5-5).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants