THRIFT-5660: lib: cpp: TTransportException: create thrift::numeric_cast

[cfriedt]

This adds an equivalent implementation of boost::numeric_cast written purely in standard c++.

The implementation is relatively trivial and reduces the dependency on boost.

Adapted from
https://stackoverflow.com/a/49658950/5636218

• Did you create an Apache Jira ticket? (not required for trivial changes)
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?

[cfriedt]

Currently seeing a bunch of MSVC errors like the one below:

C:\projects\thrift\lib\cpp\src\thrift/numeric_cast.h(47): warning C4003: not enough arguments for function-like macro invocation 'max' [C:\projects\build\MSVC2017\x64\lib\cpp\thrift.vcxproj]
C:\projects\thrift\lib\cpp\src\thrift/numeric_cast.h(50): warning C4003: not enough arguments for function-like macro invocation 'max' [C:\projects\build\MSVC2017\x64\lib\cpp\thrift.vcxproj]
  ThreadManager.cpp
  TimerManager.cpp
  PeekProcessor.cpp
...
C:\projects\thrift\lib\cpp\src\thrift/numeric_cast.h(47): error C2589: '(': illegal token on right side of '::' 

It looks as though MSVC defines max(a, b) as a macro everywhere. This is ~questionable for C, but not good for C++ since we have std::max() but then also std::numeric_limits::max() and likely others.

[Jens-G]

@cfriedt I guess this broke sth.
https://app.travis-ci.com/github/apache/thrift/jobs/589120686

[4/354] Building CXX object lib/cpp/CM...ansport/TNonblockingServerSocket.cpp.o
FAILED: lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/transport/TNonblockingServerSocket.cpp.o
/usr/bin/g++ -DBOOST_ALL_DYN_LINK -DBOOST_TEST_DYN_LINK -DTHRIFT_STATIC_DEFINE -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/cpp -I../lib/cpp -I. -I../lib/cpp/src -O2 -g -DNDEBUG -std=c++11 -MD -MT lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/transport/TNonblockingServerSocket.cpp.o -MF lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/transport/TNonblockingServerSocket.cpp.o.d -o lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/transport/TNonblockingServerSocket.cpp.o -c ../lib/cpp/src/thrift/transport/TNonblockingServerSocket.cpp
In file included from ../lib/cpp/src/thrift/transport/TTransport.h:25:0,
from ../lib/cpp/src/thrift/transport/TSocket.h:25,
from ../lib/cpp/src/thrift/transport/TNonblockingServerTransport.h:23,
from ../lib/cpp/src/thrift/transport/TNonblockingServerSocket.h:23,
from ../lib/cpp/src/thrift/transport/TNonblockingServerSocket.cpp:54:
../lib/cpp/src/thrift/transport/TTransportException.h:25:10: fatal error: thrift/numeric_cast.h: No such file or directory
#include <thrift/numeric_cast.h>
^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.
The command "build/docker/run.sh" exited with 1.

[Jens-G]

We can fix it or revert it. Your decision.

BTW this also looks strange but don't know yet if it is related, may be caused by another patch.

https://app.travis-ci.com/github/apache/thrift/jobs/589120685

[cfriedt]

@cfriedt I guess this broke sth.
https://app.travis-ci.com/github/apache/thrift/jobs/589120686

That's weird - I'll take a look. Was that an autotools build or CMake build?

[Jens-G]

CMake I'd say

[cfriedt]

We can fix it or revert it. Your decision.

BTW this also looks strange but don't know yet if it is related, may be caused by another patch.

https://app.travis-ci.com/github/apache/thrift/jobs/589120685

I've seen this before and it's due to header reordering. I've been careful to avoid that FWIR.

There is that one header that defines THRIFT_IOCTL etc macros and because it does not itself include unistd, ioctl, fcntl, etc, it's ordering is fragile.

[cfriedt]

CMake I'd say

I see the issue. thrift/numeric_cast.h needs to be installed (of course). make-dist.sh tests builds from the distributed tarball.

Should be a quick fix.

[cfriedt]

We can fix it or revert it. Your decision.
BTW this also looks strange but don't know yet if it is related, may be caused by another patch.
https://app.travis-ci.com/github/apache/thrift/jobs/589120685

I've seen this before and it's due to header reordering. I've been careful to avoid that FWIR.

There is that one header that defines THRIFT_IOCTL etc macros and because it does not itself include unistd, ioctl, fcntl, etc, it's ordering is fragile.

Ah, this one is because <thrift/config.h> is not included

[cfriedt]

@Jens-G fixes are in #2733