[kou]

It seems that Apache Thrift wants to drop Boost dependency eventually.
See also:

thrift/lib/cpp/CMakeLists.txt

Lines 20 to 21 in 4646a35

	# Remove the following once lib/cpp no longer depends on boost headers:
	include(BoostMacros)

# Remove the following once lib/cpp no longer depends on boost headers:
include(BoostMacros)

This is a step for it. We don't need to use boost::scoped_array because
we can use std::unique_ptr. We require C++11 or later and std::unique_ptr
can be used with C++11 or later.

• Did you create an Apache Jira ticket? (not required for trivial changes)
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

[emmenlau]

Dear @kou , your changes are highly appreciated! But since the build failed in Appveyor and Travis, could you kindly rebase on latest master and force push again, to see if the build errors go away? If not, we need to see if they are related to your changes...

[kou]

Rebased. I hope that all CI jobs are green...

[kou]

The AppVeyor job is green but some Travis CI jobs are still failed. But the same Travis CI jobs on master are failed:

• master: https://app.travis-ci.com/github/apache/thrift/builds/255364984
• This pull request: https://app.travis-ci.com/github/apache/thrift/builds/255364984

It seems that these Travis CI failures aren't related to this change.

[emmenlau]

Yep, I agree, the errors are unrelated, so your changes look good! Thanks for pushing this forward. I'll test it locally in my CI and then merge.

[emmenlau]

I've tested the changes also against our internal build with some different compilers, and run test suites on Linux, Windows and MacOS. Everything looks good, so merging. Thanks for the nice cleanup!

[kou]

Thanks!

[emmenlau]

Thanks to you! If you have more such changes, please keep them coming!

[cfriedt]

Great change @kou - standards FTW! 👍