Repository navigation
THRIFT-5658: lib: cpp: TProtocol: support zephyr byteorder - #2681
Merged
Merged
Conversation
24 of 25 tasks
cfriedt
pushed a commit
to zephyrproject-rtos/gsoc-2022-thrift
that referenced
this pull request
Oct 1, 2022
apache/thrift#2687 apache/thrift#2681 apache/thrift#2680 apache/thrift#2630 apache/thrift#2682 Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
pushed a commit
to zephyrproject-rtos/gsoc-2022-thrift
that referenced
this pull request
Oct 1, 2022
With this, we're starting to clean up the commit history a bit. See #147 for details. apache/thrift#2687 apache/thrift#2681 apache/thrift#2680 apache/thrift#2630 apache/thrift#2682 Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
pushed a commit
to zephyrproject-rtos/gsoc-2022-thrift
that referenced
this pull request
Oct 1, 2022
With this, we're starting to clean up the commit history a bit. See #147 for details. apache/thrift#2687 apache/thrift#2681 apache/thrift#2680 apache/thrift#2630 apache/thrift#2682 Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
pushed a commit
to zephyrproject-rtos/gsoc-2022-thrift
that referenced
this pull request
Oct 1, 2022
With this, we're starting to clean up the commit history a bit. See #147 for details. apache/thrift#2687 apache/thrift#2681 apache/thrift#2680 apache/thrift#2630 apache/thrift#2682 apache/thrift#2689 Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
pushed a commit
to zephyrproject-rtos/gsoc-2022-thrift
that referenced
this pull request
Oct 2, 2022
With this, we're starting to clean up the commit history a bit. See #147 for details. apache/thrift#2687 apache/thrift#2681 apache/thrift#2680 apache/thrift#2630 apache/thrift#2682 apache/thrift#2689 Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
force-pushed
the
zephyr-sys-byteorder
branch
from
October 22, 2022 16:06
2287a36 to
0973460
Compare
Contributor
Author
|
rebased |
Zephyr's byteorder is defined in `<zephyr/sys/byteorder.h>`. However, the `bswap_xx` macros are also defined there. They need to be `#undef`d first when building for big-endian architectures, since the Thrift byteorder macros are no-ops for little-endian architectures. Signed-off-by: Chris Friedt <cfriedt@fb.com>
cfriedt
force-pushed
the
zephyr-sys-byteorder
branch
from
October 25, 2022 11:17
0973460 to
a7f2b09
Compare
Contributor
Author
|
cfriedt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zephyr's byteorder is defined in
<zephyr/sys/byteorder.h>. However, thebswap_xxmacros are also defined there. They need to be#undefd first when building for big-endian architectures, since the Thrift byteorder macros are no-ops for little-endian architectures.