Repository navigation
THRIFT-6394: refactor(cpp): Build the C++ library without Boost - #3975
Open
slachiewicz wants to merge 2 commits into
Open
slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
mergeable
Bot
added
c++
slachiewicz
marked this pull request as ready for review
September 28, 2026 12:06
slachiewicz
changed the title
Client: cpp Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… tests Client: cpp Threads, timing, random numbers and paths now come from the C++11 standard library, so lib/cpp/test links boost_unit_test_framework alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slachiewicz
force-pushed
the
THRIFT-6394
branch
from
September 30, 2026 18:26
4bcd632 to
0df33fa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the eight remaining Boost uses in
lib/cpp/srcwith C++11 code (the table in the ticket lists each one) and dropsREQUIRE_BOOST_HEADERS()from the CMake build of the library and the tutorials. The opt-inTUuid(const boost::uuids::uuid&)constructor stays. The unit tests now use Boost only for Boost.Test (second commit); the autotools build still needs Boost.THeaderTransport's checked cast replacesboost::numeric_cast, which THRIFT-5660 tried in #2689 and reverted because0ULtoint32_tthrew. New tests cover UUID parsing, JSON\uescapes and case-insensitive HTTP header matching; they pass against the Boost code too.Verified: differential check of each replacement against the Boost call it replaces (all
THeaderTransportconversions at their limits, exhaustive short inputs for the tokenizer and header matching, UUID string mutations, UTF-16 sequences up to 3 units) → 212,707 comparisons, 0 differences, at C++11 and C++17.Verified: Ubuntu 24.04 arm64, GCC 13, Release → ctest 60/60 at C++11 and at C++17; with
-DBUILD_TESTING=OFFin a container with no Boost installed, the library and tutorials build.