Repository navigation
Fix cpp header issues - #2733
Conversation
The `<thrift/numeric_cast.h>` header should be part of the installed thrift artifacts since it is included by other installed headers. Signed-off-by: Chris Friedt <cfriedt@meta.com>
The `PlatformSocket.h` defines some macros that reference symbols in the libc without including the necessary headers. Moreover, the headers are protected by config macros (i.e. `#ifdef HAVE_UNISTD_H`). This makes header ordering rather fragile. Explicitly include `<thrift/config.h>` and conditionally include `<unistd.h>` prior to referencing them. A future improvement to reduce fragility would be to add includes directly in `PlatformSocket.h`. Signed-off-by: Chris Friedt <cfriedt@meta.com>
|
I merged it because it changes the situation to the better. However I would say there is sth else: The c_glib tests use a C++ server to test against. Seems there are some adjustments needed too, because now it complains about missing sleep(), fork() and throw() |
|
@cfriedt : Thoughts? |
@Jens-G - I noticed that as well. Shall I put together a fix for c_glib? I'm not sure what the root cause is yet. (Sorry for the late response, i had left my comment in draft by accident) |
|
That would be super awesome. |
2 participants
2 commits to address 2 issues:
cc @Jens-G