Repository navigation
Remove the GitHub delivery-board metrics panel - #1370
Merged
Merged
Conversation
The owner deleted the repository metrics panel (#1363). Opening Tasks shows that Bot's task board again; Workflow stays. The delivery-board and delivery-probe endpoints, the probe script, and the delivery card skin are gone. core/test/no-delivery-board.test.js fails if they return. The unreleased #1326 and #1360 changelog fragments advertised that panel, so those fragments are dropped. The issue matcher the dispatcher uses stays.
cursor
Bot
force-pushed
the
remove-delivery-board-1363
branch
from
October 27, 2026 07:13
3cf64a7 to
970de79
Compare
Collaborator
Author
|
Verdict: PASS at 970de79 Ran:
Head is |
Birfy
enabled auto-merge
October 27, 2026 07:14
This was referenced Oct 27, 2026
HugoXK
pushed a commit
to HugoXK/FlyBot
that referenced
this pull request
Oct 27, 2026
…FlowLab#1371) (ThinkFlowLab#1372) Owner: Dev Reviewer: Reviewer Fixes ThinkFlowLab#1371 Tip SHA: 5da667e **`ThinkFlowLab#1352` removed the frozen-branch seal and left its data file in the tree; this deletes that file and nothing else.** ## Reproduce `ThinkFlowLab#1352` merged at `07:12:44Z`, removing `FROZEN_PATH`, `frozenList()`, `frozenRefusal()` and every call site from `.github/scripts/enqueue-guard.mjs`. The document those functions read — `.github/agent/frozen-branches.json` — is still there, byte-identical to what the seal shipped (blob `12c3f3fe`): ```json { "branches": ["cursor/"], "markers": ["CURSOR_AGENT_PR_BODY"] } ``` **Nothing on `main` reads it.** On a tree extracted from `main` `9c8e51bf`: `grep -rIn frozen .github/` → the only hit is `check-dsh-task-shape.mjs:70` talking about a frozen *task record*, not this file. `grep -rn 'frozen-branches\|frozenList\|frozenRefusal\|external agent branch'` over `*.mjs`, `*.md`, `*.json`, `*.yml`, `*.yaml` → **no hit** before or after this deletion: `ThinkFlowLab#1352` removed every reference in the same merge. The file is dead config. **It could not be deleted in `ThinkFlowLab#1352`.** `enqueue-guard.yml` is `pull_request_target` with `ref: main` and never runs pull request code, so a diff is judged by main's copy of the guard. When `ThinkFlowLab#1352` first pushed the deletion (`8f97e4f5`, main still carrying the seal), the check answered: ``` do not enqueue ThinkFlowLab#1352: frozen: .github/agent/frozen-branches.json is not editable by a pull request ``` With the seal on `main` there is no such rule and no reader, so the deletion is an ordinary change now. **What kind of change it is, is not mine to pick:** `.github/**` sits at the top of `.github/agent/risk-rules.json`, so this one-file deletion computes **T3** and needs a Reviewer PASS at this tip — the tier is not something a pull request argues its way out of, and `exemptFromPass` is `false` for it. That ordering — reader first, document second, in two pull requests — is the mechanical constraint `ThinkFlowLab#1352` recorded in its own Risk section, not a choice made again here. ## What changed 1. **`.github/agent/frozen-branches.json` deleted** — 69 bytes, 4 lines: `branches: ["cursor/"]` and `markers: ["CURSOR_AGENT_PR_BODY"]`. 2. **Nothing else.** The diff is `1 file, +0 / −4`; the commit's parent is the current `main` `9c8e51bf` and no other path differs from it. 3. **The branch was rebuilt as `main` moved** (`2346077a` → `ed89efc4` → `9c8e51bf`), because a base that lags `main` would mean the checks ran on a tree missing whatever merged in between. The content of the change never changed: one deletion. ## What I ran On `/data/w1372`, a tree extracted from the repository's own tarball of `main` `9c8e51bf`: - **Control, the unmodified tree with the file still present:** `node --test ".github/scripts/*.test.mjs"` → **538 tests, 536 pass, 0 fail, 2 skipped**. - **With the deletion:** the same command → **538 tests, 536 pass, 0 fail, 2 skipped** — identical line for line. Nothing in the suite reads the file, which is the point of the change. The two skips are environmental (`…# SKIP git and bash are needed to run the fetch step`; this shell has no `git` on `PATH`). - `node --test .github/scripts/enqueue-guard.test.mjs` → **88 / 88 pass**. - `node .github/scripts/check-mojibake.mjs` → `ok — 0 occurrences of U+FFFD in 1163 text file(s)`. - `node .github/scripts/testing-layers.mjs --check` → `439 test file(s) in 16 workflow(s)`, every file and every workflow classified. - `grep` for the seal's four names, deletion in place → 0 lines (exit 1). - GitHub's own read of this pull request: `1 file, +0 / −4`, base `9c8e51bf`. ## Red without the source change **A deletion has no source to revert, so nothing can be made to go red; claiming one would be a fabrication.** The mechanical substitutes, each run: 1. **The same diff, two copies of the guard.** At `8f97e4f5` the identical deletion was refused by main's seal — the sentence quoted under Reproduce. On this tip the same deletion is judged by the ordinary rules only. That before/after pair is the real evidence that the mechanical blocker is gone, and it is why `ThinkFlowLab#1352` had to leave the file behind. 2. **Suite identity.** 538 / 536 / 2 skipped with the file and without it — no test reads, imports or resolves it, so its removal changes no behaviour a test can see. 3. **The grep.** 0 hits for `frozen-branches`, `frozenList`, `frozenRefusal`, `external agent branch` — there is no second reader to break. 4. **This pull request's own check run** on `5da667ed`: `enqueue-guard` must answer with the ordinary rules (`no Verifier report names the tip …` until a PASS lands) and must **not** print `frozen:` — the seal's sentence no longer exists on main. ## Not run - `npm run verify`, `node scripts/ds-bot-patches.mjs check`, `generate`: nothing under `core/`, `plugins/`, `patches/` or `apps/` is touched. - `check-arch-docs`: its rule reads `core/` changes; there are none. - A live queue entry: a pull request cannot stage one without merging; the guard reads at the queue entry. ## Risk - **The last trace of the seal goes away with it.** That is the intent: `ThinkFlowLab#1352` left the document in the tree and wrote that anyone reading the tree in that window should read it as a stale config, not a live rule. Deleting it removes the chance of that misreading; no rule changes here, because no rule has read it since `ThinkFlowLab#1352`. - **A revert of `ThinkFlowLab#1352` would need this file restored too.** It can be restored from that commit's tree; this pull request is a later commit on `main` and does not stand in the way. - **Nothing outside this repository is known to read the path.** The only reader in the tree was `enqueue-guard.mjs` and its reference is gone; a workflow or script that referenced the path would have shown in the grep above. - **It needs a PASS, not a tier argument.** `.github/**` is the top rule in `risk-rules.json`; the computed tier is T3 and `exemptFromPass` is false. The verdict has to name `5da667ed`. - **`ThinkFlowLab#1328`, `ThinkFlowLab#1346` and the `cursor/` branches stay as they are.** This is cleanup of dead data, not a re-litigation of the seal's decision. ## Scope - `.github/agent/frozen-branches.json` — deleted. Not touched: `.github/scripts/**` (no code change; `ThinkFlowLab#1352` already removed the reader), `AGENTS.md`, `docs/`, `core/`, `patches/`, `.github/workflows/**`, tier calculation, and every tip belonging to `ThinkFlowLab#1328`, `ThinkFlowLab#1346`, `ThinkFlowLab#1350`, `ThinkFlowLab#1354`, `ThinkFlowLab#1367`, `ThinkFlowLab#1370`, `ThinkFlowLab#1374`. ## Checkpoint <!-- flybot:checkpoint --> ```json { "pr": 1372, "claim": "Dev", "issue": 1371, "summary": "ThinkFlowLab#1352 removed the frozen-branch seal but left its data file in the tree, because main's copy of the guard refused any pull request that edited or deleted it. This deletes .github/agent/frozen-branches.json and nothing else: one file, +0/-4, rebuilt on the current main. A grep for the seal's four names returns nothing, and the .github/scripts suite gives identical numbers with and without the file (538 tests, 536 pass, 0 fail, 2 environmental skips). Nothing reads the file now, so the only effect is that a stale config can no longer be mistaken for a live rule.", "files": [".github/agent/frozen-branches.json"], "checks": { "ran": "node --test \".github/scripts/*.test.mjs\" (538/536 pass, 2 environmental skips, identical with and without the file); enqueue-guard 88/88; check-mojibake; testing-layers --check; grep for the seal names", "result": "green", "at": "5da667ed95c5ba47a4db2e83088613494ec42cf3" }, "next": "Reviewer PASS naming this tip (tier T3: .github/** is the highest rule in risk-rules.json), then the queue" } ``` <!-- /flybot:checkpoint -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1363
Replaces #1369. GitHub left that pull request on
cursor/remove-delivery-board-f8a9after the branch was renamed, so this is the same change onremove-delivery-board-1363.What changed
The repository metrics panel is gone. Opening Tasks shows that Bot's task board: three columns, task cards, Start and Complete, and group subtask nesting. There is no Today / 7-day GitHub block, no Retry or Diagnose, and no "from the package" repository header.
The
delivery-boardanddelivery-probeendpoints are no longer served. A reading host answersbot/read-only; a writable host answersbot/not-found. The probe script, the delivery card skin, and the workflow column planner that only the metrics panel used are gone. Workflow settings and the per-Bot task board stay. The click-through fixes onmain(#1362) stay.#1361 merged while this was rebased. Its host matcher (
issue-ref.js, used by dispatch) stays. The delivery view it nested records under is deleted with the rest of the panel. The unreleased changelog fragments for #1326 and #1360 advertised that panel, so those fragments are dropped.changelog.d/1363.removed.mdrecords the removal.Group subtask nesting returns because the dialog mounts
BoardViewagain. That is the product path #1358 describes. This pull request does not close #1358.Verification at the tip
Tip SHA: 970de79
Ran:
TZ=UTC npm run verify(exit 0) on the removal tree that becamea1f988eb4e364933e50487da297a9bbcc2bb2f97. Rebasing that commit onto2346077changed only files this branch does not edit (the gate seal drop already onmain).origin/mainis an ancestor of the tip.263d123b644dc4f1137a5b89b5733671cce116e1,node --test test/no-delivery-board.test.jsincore/failed 3 of 3. After the fix the same test is green insideverify.Not run (and why):
dev/bench.sh): no../deepseek-harnesscheckout in this environment.packagejob extras (typecheck, actionlint, pack).verifyis the local stand-in fortests-okminus that job.verifyafter the final rebase onto2346077. That rebase did not edit the removal.Checkpoint
{ "pr": 1370, "claim": "Dev", "issue": 1363, "summary": "The owner removed the GitHub repository metrics panel. Opening Tasks shows that Bot's task board: columns, task cards, Start and Complete, and group subtask nesting. There is no Today or 7-day block, no Retry or Diagnose, and no package-default repository header. The delivery-board and delivery-probe endpoints are gone. Workflow settings and the per-Bot task board stay, including the click-through fixes and the dispatch issue matcher already on main.", "files": ["core/src/client/kanban.js", "core/src/host/channel.js", "core/src/host/authz.js", "core/src/client/board-card.js", "core/src/shared/board-card.js", "core/src/client/i18n.js", "core/index.js", "core/test/no-delivery-board.test.js", "core/test/kanban.test.js", "docs/subsystems/core-host.md", "changelog.d/1363.removed.md"], "checks": { "ran": "TZ=UTC npm run verify", "result": "green", "at": "a1f988eb4e364933e50487da297a9bbcc2bb2f97" }, "next": "none — ready for review" }