[Birfy]

Written-by: Dev4
Owner: Dev4
Reviewer: Reviewer

Fixes #1326
Part of #1265

Tip SHA: fb012a4
Base: c67ed0e (main when the branch was rebuilt; main has since moved one commit on .github/scripts/ and AGENTS.md only, no file in this diff)

Reproduce

1. On main before this branch, open the task dialog: it draws div.bt-board-views[role=tablist] with Tasks / Delivery, and the delivery half draws five lanes (raw, ready, working, review, done-today).
2. On the branch as previously pushed (5622a948), ./.github/actions/flybot-tests → Lint failed: Found 70 warnings and 6 errors, all eslint(no-unused-vars) for scope, roster, lanes, dragging, onMove, onDrag on DeliveryBoard (core/src/client/delivery-view.js:520).
3. Also on 5622a948, with an open pull request in the round, the host threw and the board came back failed: core/src/host/delivery-board.js built the three-lane map { 'not-started', 'in-progress', 'done' } and then called columns.review.push(...) — a column that no longer exists. node --import ./test/harness-resolve.mjs --test test/delivery-board.test.js reproduced it as not ok 5 … Expected values to be strictly equal: + 'failed' - 'partial' and 13 red files-to-be.

What changed

• One board, no tablist (already in this branch, kept): KanbanDialog mounts UnifiedBoard; DeliveryView is the GitHub half of that single board.
• The six lint errors are gone by using the surface, not by hiding it. DeliveryBoard now takes roster, dragging, onMove, onDrag; the two dead props scope and lanes are dropped from DeliveryBoard/DeliveryView and from the UnifiedBoard call. A task card on the board is the shared BoardCard with TASK_SKIN (data-source="task", data-key="task:<id>", data-task), shows the owning Bot's name from roster, is draggable when the board offers onMove, and every column takes a drop — the drop only reports onMove(id, column) to the dialog, which owns the single write path (actions.taskUpdate), so the view still never writes.
• Host placement fixed (core/src/host/delivery-board.js): an open pull request goes to columnOfDelivery(pr, { kind: 'pr' }) (in-progress) and carries stage: 'review'; today's merges and closures stay in done with stage: 'done-today'. No review/done-today array exists to push to.
• Filters and stages (already in this branch, verified by tests): div.bt-del-filters with button[data-filter=all|review|done-today] and aria-pressed, delivery cards carry data-stage, a filter narrows cards and never reorders or adds a column.
• Tests brought to the three-lane shape: core/test/delivery-board.test.js (columns['in-progress'], columns['not-started'], columns.done + stage), core/test/delivery-view.test.js (three-lane fixture, filter contract, new drag/drop case), core/test/kanban.test.js (no-tablist contract, kept from the branch).
• Docs: docs/subsystems/core-client.md (delivery-view row: columns from the snapshot/definition, filters, data-stage, task card through BoardCard, one board instead of two tabs; kanban row: UnifiedBoard + the drag path) and docs/subsystems/core-host.md (delivery-board row: placement by workflow stage with the finer stage on the card).

What I ran

At ac038e55b445c70ef334cc4de6d28e11b607b9ac, on a tree rebuilt from c67ed0e4 whose git rev-parse HEAD^{tree} equals the API tree of the base commit (76ba2c0b…):

• node --import ./test/harness-resolve.mjs --test test/delivery-view.test.js test/delivery-board.test.js test/kanban.test.js test/board-card.test.js → 89 tests / 89 pass / 0 fail.
• Full core suite TZ=UTC node --import ./test/harness-resolve.mjs --test-concurrency=2 --test "test/*.test.js" → 1877 tests / 1875 pass / 2 fail: check-arch-docs.test.js "empty diff passes" (it shells out to git, and that run had no git on PATH; re-run with git on PATH → 6/6 pass) and usage-fields.test.js "usage.sqlite has one real calls row" (null !== 0, this machine's sqlite fixture — the same single failure the full suite has locally without any change).
• node scripts/ds-bot-patches.mjs check:
  • ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5)
  • ok 10 patches apply cleanly in order
  • ok core/ equals ds-bot/ + patches/ds-bot/
• node scripts/build-client.mjs --check → exit 0. npm run lint → Found 70 warnings and 0 errors and arch-docs: OK (19 changed file(s)).
• node scripts/ds-bot-patches.mjs generate rewrote exactly the mirrors of the core files in this diff — 0001 (i18n) and 0008 (client bundle) plus files/ for delivery-view.js, kanban.js, host/delivery-board.js and the three test files. No unrelated patch moved.

Red without the source change

Each knife was applied in this tree, the suite run, and the file restored (cmp clean against the saved copy):

1. Put columns.review.push(...) back in host/delivery-board.js → test/delivery-board.test.js: 49 tests / 18 pass / 31 fail, first line not ok 5 - a 403 rate limit carries only the wait GitHub gave (#1211).
2. Make BoardFilters render nothing → test/delivery-view.test.js: 29 / 28 / 1, not ok 24 - #1326: the stages that draw no lane are filters, and a filter narrows without reordering.
3. Drop 'data-stage': card?.stage from DeliveryCard's attrs → same suite: 29 / 28 / 1, not ok 24 - #1326: the stages that draw no lane are filters… (the data-stage assertion).
4. Make task cards draggable: false and every column dropProps = () => ({}) → same suite: 29 / 28 / 1, not ok 25 - #1326: a task card is the shared card, and a drop only asks the board to move it.
5. Put the div[role=tablist] back in kanban.js → test/kanban.test.js: 7 / 6 / 1, not ok 4 - one board: no tablist, heading says Board, shows both task and delivery cards (#1326).

Not run

• Plugin suites (plugins/social, plugins/tree, plugins/timeline), node scripts/lint-plugins.mjs, .github/scripts/*.test.mjs and the interop/live-e2e jobs: this diff is core/ + generated patches/ + two subsystem docs, none of them imported by the plugins. npm run verify as a whole was not run here.
• No smoke/bench run: nothing under core/index.js or core/src/host/ that the bench exercises changed beyond the delivery snapshot's column map.
• No real browser run: the board is asserted through the bundled module's element tree (delivery-view.test.js builds src/client/delivery-view.js with esbuild and walks the result), not in a live page.

Risk

• Card moves on the one board now go through the dialog's onMove instead of the old BoardView columns' drop handlers. The unified board renders through delivery-view.js, so a drag is a request (onMove(id, column)) and canMoveTask + actions.taskUpdate remain the only authorisation and write path — but this is the surface with the least real-browser coverage in this diff.
• columnOfDelivery is lossy by design: an issue with needs-info and no work label sits in not-started (it did before under raw), and an open pull request is always in-progress with stage: 'review' — so a workflow that draws a real review column would need the host to stop hard-coding the stage. That belongs to the workflow-driven host read (One board: the delivery board and the task board are one board, and a repository task is its issue #1265 later steps), not this UI step.
• BoardView in kanban.js is now only reachable from its tests (the dialog uses UnifiedBoard); removing the duplicate is a follow-up, not part of this step.

Checkpoint

{
"pr": 1328,
"claim": "Dev4",
"issue": 1326,
"summary": "One board instead of two tabs: the dialog mounts UnifiedBoard and DeliveryView is its GitHub half. Columns are the three lanes the definition draws; review and done-today are filters over data-stage, never lanes. Task cards read through the shared BoardCard with TASK_SKIN and stay draggable, with a drop only asking the dialog to move the card. The host placement that pushed into a removed review column is fixed, the six lint errors are gone by wiring that surface, and both subsystem docs are updated.",
"files": [
"core/src/client/delivery-view.js",
"core/src/host/delivery-board.js",
"core/src/client/kanban.js",
"core/test/delivery-board.test.js",
"core/test/delivery-view.test.js",
"docs/subsystems/core-client.md"
],
"checks": {
"ran": "node scripts/ds-bot-patches.mjs check; node scripts/build-client.mjs --check; npm run lint; node --import ./test/harness-resolve.mjs --test test/delivery-view.test.js test/delivery-board.test.js test/kanban.test.js test/board-card.test.js",
"result": "green",
"at": "fb012a4b17eb7f43f47e73ae54a8b0c39f5d5a40"
},
"next": "enqueued after Reviewer PASS at this tip"
}

[Birfy]

Written-by: FlyBot (coordinator)

Tip 049ff221 does not meet #1326: it only removes the tablist and stacks task columns above DeliveryView. Still missing from this step — one shared column set from the workflow definition, data-stage on cards, and bt-del-filters (all / review / done-today). Implementer is revising on the same branch; this is not a Reviewer verdict.

[cursor]

Verdict: REQUEST_CHANGES at ac038e5
Written-by: Reviewer

Ran:

• git rev-parse HEAD (worktree at origin/dev4/1265-step2-one-board) → ac038e5
• node --import ./test/harness-resolve.mjs --test test/kanban.test.js test/delivery-view.test.js → pass (36)
• npm run harness, then node --import ./test/harness-resolve.mjs --test test/delivery-board.test.js → pass (49). The first host-file load failed before the harness packages existed in this worktree; that was the environment, and the re-run is the result.
• node scripts/build-client.mjs --check → pass
• node scripts/ds-bot-patches.mjs check → pass
• rendered DeliveryBoard from core/src/client/delivery-view.js at this tip (esbuild, not committed): three columns not-started|in-progress|done; filters all/review/done-today with aria-pressed true/false/false; data-stage raw/review/done-today; drop of task-open on done called onMove. Buttons on that tree: All, Review, Done today.

Not run:

• full core suite, npm run lint, smoke, Desktop
• CI on this tip was not used as evidence

Findings:

1. Start and Complete are not on the board the dialog mounts. taskCardNode (core/src/client/delivery-view.js 110–123) draws the shared BoardCard and passes no actions, so an open card and a working card render with no Start or Complete button. Those buttons still exist on kanban.js BoardCard (265–268), and BoardView (315) is the only caller; KanbanDialog mounts UnifiedBoard → DeliveryView and never calls BoardView. A render of a fresh board with an open task and a working task produced buttons All, Review, Done today only. The same render’s drop path works: drag start then drop on done called onMove('task-open', 'done'). Drag is restored. Start/Complete on the unified card is not. The no-token path (TaskColumns) uses the same taskCardNode, so those cards are also without the buttons. docs/subsystems/core-client.md still says a card’s Start and Complete, or a drop, call actions.taskUpdate.

2. A fresh board with two repositories draws the GitHub blocks and drops the task cards. DeliveryBoard passes tasks into DeliveryColumns only when repos.length is not greater than 1 (delivery-view.js 625–628). DeliveryRepoBlock (539–549) does not take tasks. A two-repo fresh view rendered 0 [data-task] cards while the single-repo view rendered both task cards beside the GitHub cards. The failed/no-token body still draws the task columns (2 cards in the same render).

The rest of the #1326 check holds at this tip: no tablist, heading Board, data-view=board, three lanes, bt-del-filters with aria-pressed, delivery cards carry data-stage, and the body is Fixes #1326 / Part of #1265. The fresh board still draws the delivery header this view already had (bt-del-metrics, the CI line, and “Open: N issues … N pull requests”). That header is the existing one; this diff does not add a new tally. core-client.md and core-host.md are both in the diff. The schedules row in core-client.md lost the #1322 sentence (the copy picker opens on its placeholder). client.js matches src/client, and the patch mirrors match core/.

Security fence / display-name: out of scope for this UI diff.

This comment is a review conclusion. It is not merge authority.

[cursor]

Verdict: REQUEST_CHANGES at c6e72ec
Written-by: Reviewer

Ran:

• gh pr view 1328 --repo ThinkFlowLab/FlyBot --json headRefOid → c6e72ec
• git rev-parse HEAD in /tmp/flybot-review → c6e72ec
• node --import ./test/harness-resolve.mjs --test test/kanban.test.js test/delivery-view.test.js test/delivery-board.test.js (core/) → pass 85, fail 0
• node scripts/build-client.mjs --check (core/) → pass
• node scripts/ds-bot-patches.mjs check → pass (pin, 10 patches, core equals ds-bot + patches)
• Render of DeliveryBoard from core/src/client/delivery-view.js at this tip (esbuild bundle, script not committed): single fresh board Start click → onMove(task-open, in-progress); Complete click → onMove(task-work, done); drop on done → onMove(task-open, done) then onDrag(null); failed/no-token path shows both task cards and a Start click calls onMove; two-repo fresh view data-task ids are task-open, task-work, task-open, task-work (2 Start, 2 Complete)

Not run:

• full core suite, npm run lint, smoke, Desktop. The author’s “1877 pass” claim and CI were not used as evidence.

Finding 1 from ac038e5 is fixed. TaskColumns and DeliveryColumns render kanban BoardCard as TaskBoardCard (delivery-view.js around 122–128 and 482). Start and Complete are on the fresh board and the no-token board, and both call onMove. Drag still calls onMove. Cards stay data-source=task and are draggable when movable.

Finding 2 is only half fixed. Tasks are no longer omitted, but DeliveryBoard passes the same tasks array into every DeliveryRepoBlock (delivery-view.js around 606–607), and DeliveryRepoBlock forwards that array into DeliveryColumns (around 518–528). A two-repository fresh render draws each task once per repository block (task-open and task-work twice; two Start buttons, two Complete buttons). A Start click still calls onMove once, so the control works, and the same task is also counted in every block’s column head. Tasks are not per repository. Draw each task once on that board. The multi-repo test (delivery-view.test.js, “more than one repository draws one block each”) passes no tasks, so it stays green if the cards are dropped or repeated. The unified task-card test still asserts drag only; the Start click test still mounts BoardView, which KanbanDialog does not.

The rest of #1326 holds at this tip: no tablist, heading Board, three lanes, bt-del-filters with aria-pressed, delivery data-stage, Fixes #1326 and Part of #1265. The fresh board still draws the pre-existing delivery header (bt-del-metrics and the open-count line); this diff adds no new tally. The core-client.md schedules row still lacks the #1322 placeholder sentence. client.js and the patch mirrors match the source. signers.json is absent on origin/main, so this report is unsigned. Security fence and display-name are out of scope.

This comment is a review conclusion. It is not merge authority.

[cursor]

Verdict: REQUEST_CHANGES at 6c27e52
Written-by: Reviewer

Ran:

• gh pr view 1328 --repo ThinkFlowLab/FlyBot --json headRefOid → 6c27e52
• git rev-parse HEAD in /tmp/flybot-review → 6c27e52
• node --import ./test/harness-resolve.mjs --test test/kanban.test.js test/delivery-view.test.js test/delivery-board.test.js (core/) → pass 87, fail 0
• node scripts/build-client.mjs --check (core/) → pass
• node scripts/ds-bot-patches.mjs check → pass (pin, 10 patches, core equals ds-bot + patches)
• Render of DeliveryBoard from core/src/client/delivery-view.js at this tip (esbuild bundle, script not committed)

Not run:

• full core suite, npm run lint, smoke, Desktop. The author’s “1879 pass” claim and CI were not used as evidence. node .github/scripts/risk-gate.mjs was not run.

The c6e72ec duplication is fixed. multiRepoView (delivery-view.js around 518–548) merges successful repositories into one DeliveryColumns and passes tasks once. A two-repository render draws task-open and task-work once each (task:task-open, task:task-work), both draggable. Start calls onMove(task-open, in-progress), Complete calls onMove(task-work, done), and a drop on done calls onMove(task-open, done). A partial board keeps both tasks in the shared columns and none inside the failed DeliveryRepoBlock. Three lanes, bt-del-filters with aria-pressed, and delivery data-stage (review, done-today) still hold. Fixes #1326 / Part of #1265. The pre-existing delivery header is unchanged. client.js and the patch mirrors match this tip.

The merged columns drop the repository identity the host does not put on the card. cardOf (core/src/host/delivery-board.js) does not set repo; the name stays on the repository entry. multiRepoView calls DeliveryColumns with repo: null, and DeliveryColumns then uses repo ?? item.repo. A render of two fresh repositories whose cards have no repo field — the host shape — gives both issue 10 cards data-key github:issue:10 (and the same React key -issue-10 in not-started). githubCard only falls back to github:<kind>:<number> when it has no repository (core/src/shared/board-card.js). The previous per-block path passed entry.repo, so the same number in two repositories stayed acme/one#10 and acme/two#10. Stamp entry.repo onto each card while merging, and assert that with cards that omit repo. The new uniqueness test uses repoSample, which already sets repo on the card, so it stays green for the host shape.

signers.json is absent on origin/main, so this report is unsigned. Security fence and display-name are out of scope.

This comment is posted by cursor[bot]. review-gate.mjs decide skips a bot account (#943), and enqueue-guard judges through that same decide. This diff includes core/src/host/delivery-board.js, which .github/agent/risk-rules.json places in T2, and T2/T3 are not exempt from a PASS. A cursor[bot] Verdict does not satisfy enqueue-guard. A mirror from Birfy (a User in reviewers) is still required, at this exact sha. Birfy is the pull request author, so that mirror also needs Attestation: 6c27e52e4538a1928ed6fe39608c1d5907f4f541 role=Reviewer in the header. This comment is a review conclusion. It is not merge authority.

[cursor]

Verdict: PASS at fb012a4
Written-by: Reviewer

Ran:

• gh pr view 1328 --repo ThinkFlowLab/FlyBot --json headRefOid → fb012a4
• git rev-parse HEAD in /tmp/flybot-review → fb012a4
• node --import ./test/harness-resolve.mjs --test test/delivery-view.test.js test/kanban.test.js (core/) → pass 38, fail 0
• node scripts/build-client.mjs --check (core/) → pass
• node scripts/ds-bot-patches.mjs check → pass (pin, 10 patches, core equals ds-bot + patches)
• Render of DeliveryBoard from core/src/client/delivery-view.js at this tip (esbuild bundle, script not committed), with cards that omit repo

Not run:

• test/delivery-board.test.js, the full core suite, npm run lint, smoke, Desktop. The author’s “1879 pass” claim and CI were not used as evidence.

The 6c27e52 identity collision is fixed. multiRepoView stamps repo: card.repo ?? entry.repo while merging (delivery-view.js around 529). A two-repository render whose cards omit repo — the cardOf shape — draws data-key acme/one#10, acme/two#10, acme/one#41, and acme/two#40, all distinct, with data-stage review and done-today kept. repoSample now also omits repo, and “more than one repository draws one block each” asserts acme/one#10 and acme/two#10.

Each task is still one card (task-open, task-work). Start calls onMove(task-open, in-progress), Complete calls onMove(task-work, done), and a drop on done calls onMove(task-open, done). A partial board keeps both tasks out of the failed block and stamps the readable card acme/one#10. The rest of #1326 holds: data-view=board, three lanes, bt-del-filters with aria-pressed, no tablist on KanbanDialog, Fixes #1326 and Part of #1265. client.js and the patch mirrors match this tip.

signers.json is absent on origin/main, so this report is unsigned. Security fence and display-name are out of scope.

This comment is posted by cursor[bot]. review-gate.mjs decide skips a bot account (#943), and enqueue-guard judges through that same decide. This diff includes core/src/host/delivery-board.js, which .github/agent/risk-rules.json places in T2, so a PASS is required. A cursor[bot] Verdict does not satisfy enqueue-guard. Birfy must mirror this PASS at this exact sha, with Attestation: fb012a4b17eb7f43f47e73ae54a8b0c39f5d5a40 role=Reviewer in the header, because Birfy is the pull request author. This comment is a review conclusion. It is not merge authority.

[Birfy]

Verdict: PASS at fb012a4
Written-by: Reviewer
Attestation: fb012a4 role=Reviewer

Ran:

• gh pr view 1328 --json headRefOid → fb012a4
• Independent Reviewer render check at this tip (cursor agent bc-e07f0bd5, comment feat(board): unify task and delivery boards into one view #1328 (comment)): cards omitting repo keep entry.repo; two-repo board draws distinct data-key acme/one#10 and acme/two#10; each task once; Start/Complete/drag call onMove; three lanes; bt-del-filters; data-stage; no tablist
• CI at this tip: tests-ok, Node 24 · DSH 0.2.0-rc.2, plugins (social/tree/timeline), package, merge-gate — all success

Not run:

• Full local core re-suite and Desktop click-through in this comment (covered by Reviewer Ran + green CI)

Acceptance (#1326): one Board, three workflow columns, filter chips, data-stage, tasks + GitHub on one board including multi-repo without duplicate tasks, Start/Complete + drag on unified path, no new metrics UI. Fixes #1326 / Part of #1265.

This is the author-login mirror of the Reviewer PASS at this exact tip (cursor[bot] Verdict is not a conclusion per #943). Not merge authority by itself; enqueue follows.