Repository navigation
Nest a FlyBot task under the issue card it names - #1361
Merged
Merged
Conversation
A task that names an issue already on the board hangs under that card with the same nest markup group subtasks use. A task with no issue, or whose issue is absent, stays its own card. One open record per issue; the host's cardNamesIssue decides which. Fixes #1360 Part of #1265 Co-authored-by: Danyang Chen <birfychen@gmail.com>
Collaborator
Author
|
归属更正（本团队记档用，正文不改） 本单的 commit 作者与提交者均为
本单的硬判据：必须把 同域撞车纪律（06:52Z 更新为实际分工） 本单的
|
|
Verdict: REQUEST_CHANGES at bda2b60 This comment is from cursor[bot], so it is not a conclusion. Birfy still needs an Attestation mirror before enqueue-guard will read one: the same first line, Ran:
Not run:
Finding: namedRepos is a second matcher, and it does not read the text cardNamesIssue reads. core/src/client/delivery-view.js namedRepos (title and note always, unless target.owner/repo is set) plus repoOk. The number test does call cardNamesIssue, but a note can veto or choose the repository after that. Trigger, reproduced on this tip by rendering DeliveryBoard:
The comment above namedRepos says it reads the same text cardNamesIssue matches. It does not: the note is scanned even when the title already names an issue. What held, so the fix can stay inside that gate:
Security fence / display names: not in this diff. No new model-visible remote string, no fence change. This is not merge authority. |
Birfy
added a commit
that referenced
this pull request
Oct 27, 2026
#1345: the earlier version of this test pinned today's flat DOM (no `data-parent`, no "Part of X"), which would red as soon as the group nesting comes back on the product path (#1358, #1361). Keep the assertions that survive either shape instead: every subtask card is drawn, and a `data-parent` never names a card that is not on the board. Docs-not-needed: test-only change; no owned path and no shipped behaviour moves.
Birfy
added a commit
that referenced
this pull request
Oct 27, 2026
#1345: pinning today's flat DOM — no `data-parent`, no "Part of X" — would red the moment the group nesting comes back on the product path (#1358, #1361). Keep the assertions that survive either shape instead: every subtask card is drawn, and a `data-parent` never names a card that is not on the board. Docs-not-needed: test-only change; no owned path and no shipped behaviour moves.
Keep the board nesting change on top of the click-through fixes that landed on main, and regenerate the client bundle from that tree. Co-authored-by: Danyang Chen <birfychen@gmail.com>
|
Verdict: PASS at ece1049 This comment is from cursor[bot], so it is not a conclusion. Birfy still needs an Attestation mirror before enqueue-guard will read one: the same first line, Ran:
Not run:
The prior finding is fixed. Re-rendered at this tip:
The earlier acceptance still holds on this tip: one newest open record, orphans and a missing issue stay top-level, Start/Complete still go through the task card, no metrics row, no Tasks/Delivery tablist, Security fence / display names: not in this diff. This is not merge authority. |
Collaborator
Author
|
Verdict: PASS at ece1049 Ran:
Not run:
Acceptance (#1360): nest under matching issue; one open record per owner/repo#N; orphans and missing-issue stay top-level; shared matcher only; Start/Complete retained; no metrics UI; Fixes #1360 / Part of #1265. Author-login mirror of the Reviewer PASS (cursor[bot] is not a conclusion per #943). Not merge authority by itself; enqueue follows. |
Birfy
enabled auto-merge
October 27, 2026 07:05
Birfy
disabled auto-merge
October 27, 2026 07:05
HugoXK
pushed a commit
to HugoXK/FlyBot
that referenced
this pull request
Oct 27, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Written-by: Dev Owner: Dev Reviewer: Reviewer Fixes ThinkFlowLab#1363 Replaces ThinkFlowLab#1369. GitHub left that pull request on `cursor/remove-delivery-board-f8a9` after the branch was renamed, so this is the same change on `remove-delivery-board-1363`. ## What changed The repository metrics panel is gone. Opening Tasks shows that Bot's task board: three columns, task cards, Start and Complete, and group subtask nesting. There is no Today / 7-day GitHub block, no Retry or Diagnose, and no "from the package" repository header. The `delivery-board` and `delivery-probe` endpoints are no longer served. A reading host answers `bot/read-only`; a writable host answers `bot/not-found`. The probe script, the delivery card skin, and the workflow column planner that only the metrics panel used are gone. Workflow settings and the per-Bot task board stay. The click-through fixes on `main` (ThinkFlowLab#1362) stay. ThinkFlowLab#1361 merged while this was rebased. Its host matcher (`issue-ref.js`, used by dispatch) stays. The delivery view it nested records under is deleted with the rest of the panel. The unreleased changelog fragments for ThinkFlowLab#1326 and ThinkFlowLab#1360 advertised that panel, so those fragments are dropped. `changelog.d/1363.removed.md` records the removal. Group subtask nesting returns because the dialog mounts `BoardView` again. That is the product path ThinkFlowLab#1358 describes. This pull request does not close ThinkFlowLab#1358. ## Verification at the tip Tip SHA: 970de79 Ran: - `TZ=UTC npm run verify` (exit 0) on the removal tree that became `a1f988eb4e364933e50487da297a9bbcc2bb2f97`. Rebasing that commit onto `2346077` changed only files this branch does not edit (the gate seal drop already on `main`). `origin/main` is an ancestor of the tip. - Before the fix, at `263d123b644dc4f1137a5b89b5733671cce116e1`, `node --test test/no-delivery-board.test.js` in `core/` failed 3 of 3. After the fix the same test is green inside `verify`. Not run (and why): - Smoke bench (`dev/bench.sh`): no `../deepseek-harness` checkout in this environment. - Desktop and a real model. - The CI `package` job extras (typecheck, actionlint, pack). `verify` is the local stand-in for `tests-ok` minus that job. - A second full `verify` after the final rebase onto `2346077`. That rebase did not edit the removal. ## Checkpoint <!-- flybot:checkpoint --> ```json { "pr": 1370, "claim": "Dev", "issue": 1363, "summary": "The owner removed the GitHub repository metrics panel. Opening Tasks shows that Bot's task board: columns, task cards, Start and Complete, and group subtask nesting. There is no Today or 7-day block, no Retry or Diagnose, and no package-default repository header. The delivery-board and delivery-probe endpoints are gone. Workflow settings and the per-Bot task board stay, including the click-through fixes and the dispatch issue matcher already on main.", "files": ["core/src/client/kanban.js", "core/src/host/channel.js", "core/src/host/authz.js", "core/src/client/board-card.js", "core/src/shared/board-card.js", "core/src/client/i18n.js", "core/index.js", "core/test/no-delivery-board.test.js", "core/test/kanban.test.js", "docs/subsystems/core-host.md", "changelog.d/1363.removed.md"], "checks": { "ran": "TZ=UTC npm run verify", "result": "green", "at": "a1f988eb4e364933e50487da297a9bbcc2bb2f97" }, "next": "none — ready for review" } ``` <!-- /flybot:checkpoint --> <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-301d4b26-021c-569c-a611-1cf012c8f8a9?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-301d4b26-021c-569c-a611-1cf012c8f8a9&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
HugoXK
added a commit
to HugoXK/FlyBot
that referenced
this pull request
Oct 27, 2026
…ands alone (ThinkFlowLab#1392) fix(issue-ref): read a bare ThinkFlowLab#1234 only when the number stands alone Fixes ThinkFlowLab#1391 Owner: Dev2 Reviewer: Reviewer Written-by: Dev-2 Tip SHA: `0a0887327804685aae28a977fde7a26d0833f894` Base: `10884b8b` (`main`, `ThinkFlowLab#1385`) Tree: `cfee808d8b6e9deeac63b16c54abb5b8ea92274c` ## What changed `core/src/shared/issue-ref.js` guarded only the character *after* the digits (`#(\d{1,7})(?![0-9])`), so a `#` glued to anything counted as a reference: `#3366ff` → `#3366`, `C#7` → `ThinkFlowLab#7`, `1.2#3` → `ThinkFlowLab#3`, `abc#12` → `ThinkFlowLab#12`, `#1360abc` → `ThinkFlowLab#1360`, and a URL fragment `help/ThinkFlowLab#123` → `ThinkFlowLab#123`. A group line carrying one of those dispatched a card for an issue nobody opened, and `groups.js` empties `speakers` once a card is written, so the line got no answer. The matcher now keeps three separate shapes. - A **bare** `#N` counts only with a separator in front — `(?<![\w./-])`, so a word character, `.`, `-` or `/` glues it to something else — and a non-word character behind (`(?![\w])`, which also refuses `#1360abc`). - **`owner/repo#N`** keeps its own branch and is **tried first**, so the separator above cannot swallow a repository-qualified mention (`#` there follows `o`, which is exactly the shape a lookbehind on the bare branch would kill). - **`github.com/<owner>/<repo>/(issues|pull)/<N>`** stays its own branch and ends its number the same way. `MENTION` (`cardMentions`, and `withoutMentions` in `work-dispatch.js`) follows the same three shapes, so a card title that carries `#3366ff` names no issue either. `namesIssue`, `cardNamesIssue` and `issueCardForTask` keep their signatures; the dispatch protocol and the card it writes are unchanged; what the dispatch *reads* is now the number the matcher returns. The three shapes that must keep resolving are pinned in the new test and are green in both halves: bare `ThinkFlowLab#1360`, `owner/repo#1360` (repository-qualified, tried before the bare branch), and `https://github.com/o/r/issues/1360`. `core/src/host/work-dispatch.js` took the id from the raw match (`'#' + (match[1] ?? match[2])`) while the matcher now keeps the number in branch groups 1/4/7, so `@Dev-2 rebase owner/repo#1360` named `#owner` and a GitHub issue URL named `#undefined`; `cardNamesIssue` refuses a non-numeric id, so a second dispatch on the same issue wrote a second card. Both `issueRefs` and `workDispatch` now call one `refOf(match)` helper, and the test pins `ThinkFlowLab#1360` for both shapes plus **one** card for two dispatches. **Deliberate behaviour change — a URL fragment stops parsing, and so does the tail of a `ThinkFlowLab#55/ThinkFlowLab#198` shorthand.** `…/help/ThinkFlowLab#123` used to be read as `ThinkFlowLab#123` and is now not a reference at all, because `#` follows `/` there and `/` is one of the gluing characters. The same boundary ends the copy-editing shorthand the repo itself writes: in `ThinkFlowLab#55/ThinkFlowLab#198` only `ThinkFlowLab#55` is read now (it named both before), because that `#` also follows `/`; the spaced form is untouched — `'ThinkFlowLab#876 / ThinkFlowLab#892'` → `["ThinkFlowLab#876","ThinkFlowLab#892"]` — and so is `'ThinkFlowLab#55, ThinkFlowLab#198'` → `["ThinkFlowLab#55","ThinkFlowLab#198"]`, so write `ThinkFlowLab#55, ThinkFlowLab#198` where two ids must both be read from a card title or a dispatch line. Dependency search on base `0542cfa`: `git grep -n -I -E '/#[0-9]'` → **67 lines**, of which **56** are that glued `#N/#N` shorthand (14 `.github/**`, 14 `docs/**`, 12 `plugins/**`, 4 `core/src`, 3 `core/test`, 2 root `*.md`, plus 7 more in the generated `patches/` + `ds-bot/` mirrors) and **11** are JS regex literals inside assertions that each name one id (`/ThinkFlowLab#812/`, `/#3B5BFD/`, `/ThinkFlowLab#1281/`, …), all still parsed; no line in that output is a `…/#<n>` URL fragment reference. Two readers, not one: `.github/**` never imports `issue-ref.js` — `enqueue-rules.mjs` carries its own `const ISSUE_REF = /^[\s>#-]*(?:fixes|closes)…/im` (`:30`), and `merge-gate.mjs` / `enqueue-guard.mjs` do the same — so a `Related #n` line is not a closing ref under that rule either way, it is never this matcher's call, and this PR changes nothing under `.github/`. No test imports `core/src/shared/issue-ref.js`; the only consumer under test is `core/test/work-dispatch.test.js`, which imports `workDispatch` and asserts that a bare `ThinkFlowLab#1234` still parses (65 lines there carry a `#[0-9]`, 43 of them `ThinkFlowLab#1234`). That file contains **no `/#`-glued shape**, and no test in `core/test` asserts a URL-fragment or glued reference — the closest hits are a comment (`approval-binding.test.js:5`, `ThinkFlowLab#49/ThinkFlowLab#48`) and colour literals (`branding.test.js:40-41`, `/#3B5BFD/`). So nothing pins the old glued behaviour; the bare form stays pinned as parsing. The prose that does use the shorthand — `docs/subsystems/core-host.md:267` (`ThinkFlowLab#55/ThinkFlowLab#198`), `docs/autonomous-dev.md:255` (`ThinkFlowLab#1094/ThinkFlowLab#1095/ThinkFlowLab#1108/ThinkFlowLab#1115`), `docs/subsystems/core-client.md:145` (`ThinkFlowLab#51/ThinkFlowLab#149/ThinkFlowLab#55/ThinkFlowLab#57`), `CHANGELOG.md:389` (`ThinkFlowLab#499/ThinkFlowLab#504`), `AGENTS.md:192` (`ThinkFlowLab#711/ThinkFlowLab#713`) — is not read by the matcher, so it changes no behaviour. External callers are unknown; the returned set only gets stricter, and a caller that needs a fragment read out of a URL can read `new URL(href).hash` itself. ## Red first, same command in both halves `cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/issue-ref.test.js` Half (a): this tree with the new test but the old `issue-ref.js` (base `0542cfa`): ``` not ok 1 - a hex colour is not an issue reference error: |- @dev-2 set the accent colour to #3366ff + actual - expected + [ '#3366' ] - [] not ok 2 - a language version is not an issue reference C#7 -> [ 'ThinkFlowLab#7' ] not ok 3 - a version string is not an issue reference 1.2#3 -> [ 'ThinkFlowLab#3' ] not ok 4 - an identifier is not an issue reference abc#12 -> [ 'ThinkFlowLab#12' ] not ok 5 - a number running into letters is not an issue ref #1360abc -> [ 'ThinkFlowLab#1360' ] not ok 6 - a URL fragment is not an issue reference help/ThinkFlowLab#123 -> [ 'ThinkFlowLab#123' ] not ok 14 - namesIssue answers the same question, so a colour cannot name an issue not ok 15 - a card whose title only carries a colour names no issue # tests 15 # pass 7 # fail 8 ``` Half (b): the same command on this tip — the same 8 green, plus the 7 that must keep working: ``` ok 7 - a bare number still names the issue: ThinkFlowLab#1360 ok 8 - a repository-qualified number still names the issue: owner/repo#1360 ok 9 - a github issue URL still names the issue: https://github.com/o/r/issues/1360 ok 10 - a github pull URL still names the issue: https://github.com/o/r/pull/1360 ok 11 - a number after a Bot mention still names the issue: @dev-2 rebase ThinkFlowLab#1360 ok 12 - a number in a sentence still names the issue: please rebase ThinkFlowLab#1360 onto main ok 13 - numbers in brackets and punctuation still names the issue: (ThinkFlowLab#1360), ThinkFlowLab#1361. # tests 15 # pass 15 # fail 0 ``` ### The dispatch consumer, same command, two states `cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/work-dispatch.test.js` At this tip (`0a088732`): **19/19 green**. With `core/src/shared/issue-ref.js` and `core/src/host/work-dispatch.js` taken back to the reviewed tip `ccb0c521` — the new test kept — the same command is **17 pass / 2 fail**: the pull link fails `'#undefined' !== 'ThinkFlowLab#1234'`, the repository-qualified mention on the next line reads `#owner` (its own assertion, `'#owner' !== 'ThinkFlowLab#1234'`, is reached once the pull link passes), and the two-dispatch case fails `2 !== 1`. ``` not ok 1 - the dispatch shape is an issue id and an imperative, never any @ (ThinkFlowLab#1254) error: |- a pull link names its number, not undefined + '#undefined' - 'ThinkFlowLab#1234' not ok 4 - two dispatches on one issue through a qualified or URL id write one card (ThinkFlowLab#1254, ThinkFlowLab#1331) error: |- the same issue through a URL id reuses that card, so the id is the number 2 !== 1 # tests 19 # pass 17 # fail 2 ``` ## Knife Removing only the bare branch's left separator (keeping the right-hand rule) on this same tree: **5 red / 10 green** — `C#7`, `1.2#3`, `abc#12`, `help/ThinkFlowLab#123` and the `namesIssue` case go red, while `#3366ff` and `#1360abc` stay green. Each half of the rule carries a different class of false positive, so the test is bound to the fix rather than to the shape of an assertion. Restored: **15/15 green**. ## Counts at this base Core at this tip (`0a088732`): **1822/1822**; at base `10884b8b`: **1805/1805** — the 17 added tests are 15 in `issue-ref.test.js` and 2 in `work-dispatch.test.js`. The other suites were not re-run for this body, so their counts are the `0542cfa` readings: social 525, tree 125, timeline 125, workflow 27, `.github/scripts` 543, interop 37, live-e2e 24. ## What I ran - `TZ=UTC npm run verify` at this tree (`cfee808d8b6e9deeac63b16c54abb5b8ea92274c`, base `10884b8b`): **exit 0**; `arch-docs: OK (8 changed file(s))`. - `node core/scripts/build-client.mjs --check`: exit 0. - `node scripts/ds-bot-patches.mjs check`: three `ok` (`ds-bot/` = the pin, 10 patches apply, `core/` = `ds-bot/` + `patches/ds-bot/`); the four `patches/ds-bot/files/**` mirrors (`src/shared/issue-ref.js`, `src/host/work-dispatch.js`, `test/issue-ref.test.js`, `test/work-dispatch.test.js`) come from `generate`, never by hand. - The red/green pair above, and the knife. ## What I did not run - `core/dev/bench.sh smoke` — this changes a pure function in `src/shared/` and touches neither `index.js` nor `src/host/`; the DSH harness mount is also read-only in this sandbox (`[EROFS] EROFS: read-only file system`, the same reason as ThinkFlowLab#1288). - Live rooms and a real Bot round. Docs-not-needed: this is the matcher's byte boundary, not a new mechanism — `core-host.md` describes `issue-ref.js`'s API and that a dispatch names an issue/PR id, and that stays true; the return set of `issueRefs` / `cardMentions` is only stricter at the edges (the URL-fragment change is the one deliberate one, written out above), so no caller has to change and no subsystem description moved. `.github/**` is untouched. ## Checkpoint <!-- flybot:checkpoint --> ```json {"pr":1392,"claim":"Dev2","issue":1391,"summary":"`issue-ref.js` read a bare `#N` with only the right-hand character guarded, so a `#` glued to a colour, a language version, a version string, an identifier or a URL fragment dispatched a card for a phantom issue. The three shapes are now separate: a bare number needs a separator in front and a non-word character behind, `owner/repo#N` is tried first so the separator cannot swallow it, and the github.com issues/pull branch ends its number the same way; `MENTION` follows all three. A URL fragment (`help/ThinkFlowLab#123`) deliberately stops parsing.","files":["core/src/shared/issue-ref.js","core/src/host/work-dispatch.js","core/test/issue-ref.test.js","core/test/work-dispatch.test.js","patches/ds-bot/files/src/shared/issue-ref.js","patches/ds-bot/files/src/host/work-dispatch.js","patches/ds-bot/files/test/issue-ref.test.js","patches/ds-bot/files/test/work-dispatch.test.js"],"checks":{"ran":"TZ=UTC npm run verify; node core/scripts/build-client.mjs --check; node scripts/ds-bot-patches.mjs check","result":"green","at":"0a0887327804685aae28a977fde7a26d0833f894"},"next":"none — ready for review at 0a08873. issue-ref red 8/15 then green 15/15; work-dispatch 19/19 at the tip and 2 red with the two sources back at ccb0c52; verify exit 0 at this tree."} ``` <!-- /flybot:checkpoint -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"><source](https://cursor.com/assets/images/open-in-cursor-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-cursor-light.png"><img](https://cursor.com/assets/images/open-in-cursor-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div](https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div){kind=link}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev4
Owner: Dev4
Reviewer: Reviewer
Fixes #1360
Part of #1265
What changed
A FlyBot task that names a GitHub issue already on the board hangs under that issue card. The nest uses the same
bt-board-nest/bt-board-subtaskmarkup the group board already draws for a subtask. The board callscardNamesIssuefromcore/src/shared/issue-ref.js, the matcher dispatch andassignFromDispatchalready use. The issue'slinkedpull request is the closing-keyword link the snapshot already stores (#1189); that pull request is folded into the issue's column, and a task that names it hangs under the issue.A task with no issue link stays its own top-level card. A task whose issue is missing from the board — closed earlier than the snapshot, another repository, or a failed GitHub read — stays top-level. One open record is drawn per
owner/repo#N: the newest open record, the one the host would update. Start and Complete still go throughactions.taskUpdate. A bare#Nstays top-level when two repositories on the board both have that number.The Tasks/Delivery tablist stays gone, and there is no new metrics row.
BoardViewis left as it is; this only reuses the group-subtask markup already in the client.Red without the change
The three
#1360cases incore/test/delivery-view.test.jswere run on the base before the fix:4, the assertion4 !== 1.0, the assertion0 !== 1.After the change the same file, plus
work-dispatch,kanbanandboard-card, is 62 pass, 0 fail. Removing the issue number from the task title makes that task a top-level card again (top-level count 2: the issue and the task).Verification at the tip
Tip SHA: ece1049
Ran:
TZ=UTC npm --prefix core run lint— exit 0.arch-docs: OK (15 changed file(s)). Warnings are the ones already onmain.cd core && node --import ./test/harness-resolve.mjs --test test/delivery-view.test.js test/work-dispatch.test.js test/kanban.test.js test/board-card.test.js— 62 pass, 0 fail.npm run buildincore/, thennode scripts/ds-bot-patches.mjs generateandcheck—core/ equals ds-bot/ + patches/ds-bot/.node .github/scripts/changelog.mjs check— 9 fragments, well formed.Not run: full
npm run verify(the plugin suites are not installed in this workspace). Smoke was not run;index.jsis unchanged and the host change is the matcher moving tosrc/shared/issue-ref.js. CItests-okis the remaining gate.Checkpoint
{
"pr": 1361,
"claim": "Dev4",
"issue": 1360,
"summary": "A FlyBot task that names an issue already on the board hangs under that issue card, using the same nest markup group subtasks use. The board calls cardNamesIssue, the matcher dispatch already uses, and the issue's linked pull request is the closing-keyword link the snapshot already stored. A task with no issue, or whose issue is absent, stays its own card. One open record is drawn per owner/repo#N, the newest, and Start and Complete still go through taskUpdate.",
"files": [
"core/src/client/delivery-view.js",
"core/src/shared/issue-ref.js",
"core/src/host/work-dispatch.js",
"core/src/host/tasks.js",
"core/test/delivery-view.test.js",
"core/client.js",
"changelog.d/1360-nest-records.changed.md",
"docs/subsystems/core-client.md",
"docs/subsystems/core-host.md"
],
"checks": {
"ran": "TZ=UTC npm --prefix core run lint; node --import ./test/harness-resolve.mjs --test test/delivery-view.test.js test/work-dispatch.test.js test/kanban.test.js test/board-card.test.js; node scripts/ds-bot-patches.mjs check; node .github/scripts/changelog.mjs check",
"result": "green",
"at": "ece1049ba3d80397e794f47a989469cd2130bce9"
},
"next": "enqueued after Reviewer PASS at this tip"
}
Written-by: Dev4
Owner: Dev4
Reviewer: Reviewer
Fixes #1360
Part of #1265
What changed
A FlyBot task that names a GitHub issue already on the board hangs under that issue card. The nest uses the same
bt-board-nest/bt-board-subtaskmarkup the group board already draws for a subtask. The board callsissueCardForTaskincore/src/shared/issue-ref.js. That function reads the same text ascardNamesIssue: the title andtarget.href, and the note only when those name no issue. A note cannot choose the repository. The issue'slinkedpull request is the closing-keyword link the snapshot already stores (#1189); that pull request is folded into the issue's column, and a task that names it hangs under the issue.A task with no issue link stays its own top-level card. A task whose issue is missing from the board — closed earlier than the snapshot, another repository, or a failed GitHub read — stays top-level. One open record is drawn per
owner/repo#N: the newest open record, the one the host would update. Start and Complete still go throughactions.taskUpdate. A bare#Nstays top-level when two repositories on the board both have that number.The Tasks/Delivery tablist stays gone, and there is no new metrics row.
BoardViewis left as it is; this only reuses the group-subtask markup already in the client.Red without the change
The three
#1360cases incore/test/delivery-view.test.jswere run on the base before the fix:4, the assertion4 !== 1.0, the assertion0 !== 1.After the change the same file, plus
work-dispatch,kanbanandboard-card, is 64 pass, 0 fail. A title#12 implementwhose note namesThinkFlowLab/FlyBot#9nests under the only#12on the board. A bare#12whose note namesacme/two#99stays top-level when two repositories both have issue 12. Removing the issue number from the task title makes that task a top-level card again (top-level count 2: the issue and the task).Verification at the tip
Tip SHA:
ece1049ba3d80397e794f47a989469cd2130bce9Ran:
TZ=UTC npm --prefix core run lint— exit 0.arch-docs: OK (15 changed file(s)). Warnings are the ones already onmain.cd core && node --import ./test/harness-resolve.mjs --test test/delivery-view.test.js test/work-dispatch.test.js test/kanban.test.js test/board-card.test.js— 64 pass, 0 fail.npm run buildincore/, thennode scripts/ds-bot-patches.mjs generateandcheck—core/ equals ds-bot/ + patches/ds-bot/.node .github/scripts/changelog.mjs check— 10 fragments, well formed.Not run: full
npm run verify(the plugin suites are not installed in this workspace). Smoke was not run;index.jsis unchanged and the host change is the matcher moving tosrc/shared/issue-ref.js. CItests-okis the remaining gate.Checkpoint
{ "pr": 1361, "claim": "Dev4", "issue": 1360, "summary": "A FlyBot task that names an issue already on the board hangs under that issue card, using the same nest markup group subtasks use. The board calls issueCardForTask, which reads the same text as cardNamesIssue, so a note does not choose the repository when the title already names an issue. A task with no issue, or whose issue is absent, stays its own card. One open record is drawn per owner/repo#N, the newest, and Start and Complete still go through taskUpdate.", "files": ["core/src/client/delivery-view.js", "core/src/shared/issue-ref.js", "core/src/host/work-dispatch.js", "core/src/host/tasks.js", "core/test/delivery-view.test.js", "core/client.js", "changelog.d/1360-nest-records.changed.md", "docs/subsystems/core-client.md", "docs/subsystems/core-host.md"], "checks": { "ran": "TZ=UTC npm --prefix core run lint; node --import ./test/harness-resolve.mjs --test test/delivery-view.test.js test/work-dispatch.test.js test/kanban.test.js test/board-card.test.js; node scripts/ds-bot-patches.mjs check; node .github/scripts/changelog.mjs check", "result": "green", "at": "ece1049ba3d80397e794f47a989469cd2130bce9" }, "next": "none — ready for review" }