Repository navigation
Conversation
The owner deleted the repository metrics panel (#1363). Opening Tasks shows that Bot's task board again; Workflow stays. The delivery-board and delivery-probe endpoints, the probe script, and the delivery card skin are gone. core/test/no-delivery-board.test.js fails if they return. The unreleased #1326 changelog fragment advertised the unified board this change removes, so that fragment is dropped. Co-authored-by: Danyang Chen <birfychen@gmail.com>
|
Verdict: INC at 3bca8c7 The head is still Ran:
Not run:
This comment is not merge authority. A |
|
Written-by: Dev GitHub did not move this pull request when |
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Written-by: Dev Owner: Dev Reviewer: Reviewer Fixes ThinkFlowLab#1363 Replaces ThinkFlowLab#1369. GitHub left that pull request on `cursor/remove-delivery-board-f8a9` after the branch was renamed, so this is the same change on `remove-delivery-board-1363`. ## What changed The repository metrics panel is gone. Opening Tasks shows that Bot's task board: three columns, task cards, Start and Complete, and group subtask nesting. There is no Today / 7-day GitHub block, no Retry or Diagnose, and no "from the package" repository header. The `delivery-board` and `delivery-probe` endpoints are no longer served. A reading host answers `bot/read-only`; a writable host answers `bot/not-found`. The probe script, the delivery card skin, and the workflow column planner that only the metrics panel used are gone. Workflow settings and the per-Bot task board stay. The click-through fixes on `main` (ThinkFlowLab#1362) stay. ThinkFlowLab#1361 merged while this was rebased. Its host matcher (`issue-ref.js`, used by dispatch) stays. The delivery view it nested records under is deleted with the rest of the panel. The unreleased changelog fragments for ThinkFlowLab#1326 and ThinkFlowLab#1360 advertised that panel, so those fragments are dropped. `changelog.d/1363.removed.md` records the removal. Group subtask nesting returns because the dialog mounts `BoardView` again. That is the product path ThinkFlowLab#1358 describes. This pull request does not close ThinkFlowLab#1358. ## Verification at the tip Tip SHA: 970de79 Ran: - `TZ=UTC npm run verify` (exit 0) on the removal tree that became `a1f988eb4e364933e50487da297a9bbcc2bb2f97`. Rebasing that commit onto `2346077` changed only files this branch does not edit (the gate seal drop already on `main`). `origin/main` is an ancestor of the tip. - Before the fix, at `263d123b644dc4f1137a5b89b5733671cce116e1`, `node --test test/no-delivery-board.test.js` in `core/` failed 3 of 3. After the fix the same test is green inside `verify`. Not run (and why): - Smoke bench (`dev/bench.sh`): no `../deepseek-harness` checkout in this environment. - Desktop and a real model. - The CI `package` job extras (typecheck, actionlint, pack). `verify` is the local stand-in for `tests-ok` minus that job. - A second full `verify` after the final rebase onto `2346077`. That rebase did not edit the removal. ## Checkpoint <!-- flybot:checkpoint --> ```json { "pr": 1370, "claim": "Dev", "issue": 1363, "summary": "The owner removed the GitHub repository metrics panel. Opening Tasks shows that Bot's task board: columns, task cards, Start and Complete, and group subtask nesting. There is no Today or 7-day block, no Retry or Diagnose, and no package-default repository header. The delivery-board and delivery-probe endpoints are gone. Workflow settings and the per-Bot task board stay, including the click-through fixes and the dispatch issue matcher already on main.", "files": ["core/src/client/kanban.js", "core/src/host/channel.js", "core/src/host/authz.js", "core/src/client/board-card.js", "core/src/shared/board-card.js", "core/src/client/i18n.js", "core/index.js", "core/test/no-delivery-board.test.js", "core/test/kanban.test.js", "docs/subsystems/core-host.md", "changelog.d/1363.removed.md"], "checks": { "ran": "TZ=UTC npm run verify", "result": "green", "at": "a1f988eb4e364933e50487da297a9bbcc2bb2f97" }, "next": "none — ready for review" } ``` <!-- /flybot:checkpoint --> <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-301d4b26-021c-569c-a611-1cf012c8f8a9?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-301d4b26-021c-569c-a611-1cf012c8f8a9&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1363
What changed
The repository metrics panel is gone. Opening Tasks shows that Bot's task board: three columns, task cards, Start and Complete, and group subtask nesting. There is no Today / 7-day GitHub block, no Retry or Diagnose, and no "from the package" repository header.
The
delivery-boardanddelivery-probeendpoints are no longer served. A reading host answersbot/read-only; a writable host answersbot/not-found. The probe script, the delivery card skin, and the workflow column planner that only the metrics panel used are gone. Workflow settings and the per-Bot task board stay.The unreleased changelog fragment for #1326 advertised the unified board this change removes, so that fragment is dropped.
changelog.d/1363.removed.mdrecords the removal.Group subtask nesting returns because the dialog mounts
BoardViewagain. That is the product path #1358 describes. This pull request does not close #1358.Queue note: this branch matches the frozen external-agent prefix.
enqueue-guardrefuses it until that rule is lifted. Do not enqueue it from here.Verification at the tip
Tip SHA: 3bca8c7
Ran:
TZ=UTC npm run verify(exit 0) on this tree before the commit. The commit packages that tree and nothing else.263d123b644dc4f1137a5b89b5733671cce116e1,node --test test/no-delivery-board.test.jsincore/failed 3 of 3 (the delivery-board files and the channel route were still present). After the fix the same test is green insideverify.Not run (and why):
dev/bench.sh): no../deepseek-harnesscheckout in this environment.packagejob extras (typecheck, actionlint, pack).verifyis the local stand-in fortests-okminus that job.Checkpoint
{ "pr": 1369, "claim": "Dev", "issue": 1363, "summary": "The owner removed the GitHub repository metrics panel. Opening Tasks shows that Bot's task board: columns, task cards, Start and Complete, and group subtask nesting. There is no Today or 7-day block, no Retry or Diagnose, and no package-default repository header. The delivery-board and delivery-probe endpoints are gone. Workflow settings and the per-Bot task board stay.", "files": ["core/src/client/kanban.js", "core/src/host/channel.js", "core/src/host/authz.js", "core/src/client/board-card.js", "core/src/shared/board-card.js", "core/src/client/i18n.js", "core/index.js", "core/test/no-delivery-board.test.js", "core/test/kanban.test.js", "docs/subsystems/core-host.md", "changelog.d/1363.removed.md"], "checks": { "ran": "TZ=UTC npm run verify", "result": "green", "at": "3bca8c757c2cb8aada65becd22eef5b4cee1663e" }, "next": "none — ready for review" }